Open
sundials4py: expose optional KLU SUNLinearSolver bindings#966
Conversation
Copilot
AI
changed the title
Python: expose optional SUNLinSol_KLU in sundials4py
sundials4py: expose optional KLU SUNLinearSolver bindings
Jun 24, 2026
Copilot created this pull request from a session on behalf of
balos1
June 24, 2026 18:07
View session
balos1
requested changes
Jun 25, 2026
balos1
left a comment
balos1
left a comment
Member
There was a problem hiding this comment.
We need to add a python example that uses the KLU SUNLinearSolver too. A python version of https://github.com/llnl/sundials/blob/main/examples/arkode/C_klu/ark_brusselator1D_klu.c would be good.
We also need to add to the docs how one can build sundials4py with KLU enabled.
Member
|
@copilot the format_check is failing, apply the formatting |
Contributor
Author
Applied the formatting fix in commit |
balos1
approved these changes
Jul 1, 2026
drreynolds
reviewed
Jul 6, 2026
Co-authored-by: Daniel R. Reynolds <dreynolds@umbc.edu> Co-authored-by: Cody Balos <cjbalos@gmail.com>
balos1
reviewed
Jul 6, 2026
balos1
reviewed
Jul 6, 2026
Co-authored-by: Cody Balos <cjbalos@gmail.com>
#966 (comment) #966 (comment) #966 (comment) #966 (comment) #966 (comment) Keep the KLU example mention removed from the Python usage text while preserving the examples role target so the documentation link remains valid. Signed-off-by: Cody Balos <balos1@llnl.gov>
#966 (comment) Add Python unit-test coverage for the KLU solver constructor, reinit, ordering, and factorization accessors. Register the opaque KLU accessor types so the getter bindings can return Python objects by reference. Signed-off-by: Cody Balos <balos1@llnl.gov>
#966 (comment) Use NumPy reshape in the KLU Brusselator example so N_Vector data is handled as (N, 3) arrays for state, residual, Jacobian, masks, and output. Signed-off-by: Cody Balos <balos1@llnl.gov>
Member
|
@copilot apply the changes in the diff produced by the failing litgen_check |
Contributor
Author
Applied the |
balos1
reviewed
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sundials4pyexposedSUNLINEARSOLVER_KLUin enums but did not expose the KLU constructor/configuration APIs.sunlinsol_klu.cpp) and generated binding surface (sunlinsol_klu_generated.hpp) forSUNLinSol_KLU,SUNLinSol_KLUReInit,SUNLinSol_KLUSetOrdering, andSUNKLU_*constants.sundials4py.cppbehind#if defined(SUNDIALS_KLU_ENABLED).bindings/sundials4py/CMakeLists.txtto compile/link KLU bindings only whenSUNDIALS_ENABLE_SUNLINSOL_KLUis enabled.sunlinsol_kluentry tobindings/sundials4py/sunlinsol/generate.yaml.test_sunlinearsolver.pywith runtime skip when KLU is unavailable.examples/python/arkode/ark_brusselator1D_klu.py, a Python port of the C KLU example (examples/arkode/C_klu/ark_brusselator1D_klu.c) demonstratingSUNLinSol_KLUin an ARKODE solve.doc/shared/Python/Usage.rstwith instructions for buildingsundials4pywith KLU enabled viaCMAKE_ARGS(including SuiteSparse discovery) and referenced the new KLU Python example.