[Moore][ImportVerilog] Add %c format to FormatString pipeline#10580
Open
VecoMr wants to merge 1 commit into
Open
[Moore][ImportVerilog] Add %c format to FormatString pipeline#10580VecoMr wants to merge 1 commit into
VecoMr wants to merge 1 commit into
Conversation
- Add `moore.fmt.char` Moore Op who corresponds to the %c format specifier. - Lower it to `sim.fmt.char`. - Add some tests in `builtins.sv`. Signed-off-by: adouard <alexandre.douard@ens-lyon.fr>
fzi-hielscher
approved these changes
Jun 3, 2026
Contributor
fzi-hielscher
left a comment
fzi-hielscher
left a comment
There was a problem hiding this comment.
LGTM
Could you also add a test for the MooreToCore conversion?
fabianschuiki
approved these changes
Jun 3, 2026
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
LGTM 💯, modulo @fzi-hielscher's comment on adding a conversion test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moore.fmt.char, which corresponds to the %c format specifier.sim.fmt.char.builtins.sv.