[ESI] System reset functionality#10592
Draft
teqdruid wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an end-to-end “design reset request” path for the ESI cosim BSP and runtime, triggered by writing a reset magic value to the header MMIO slot at offset 0x38, and validates it via a new esitester reset subcommand + integration test.
Changes:
- Introduce reset request detection in the PyCDE MMIO header and propagate a one-cycle
reset_requestpulse up to the cosim top, which asserts a delayed full-design reset. - Add C++ runtime/API support for requesting reset via MMIO (
AcceleratorConnection::reset()), plus a newesitester resettest mode. - Add an integration test that runs the new
esitester resetpath against cosim.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/Dialect/ESI/runtime/tests/integration/test_esitester.py | Adds a new integration test invoking esitester ... reset and checking expected output. |
| lib/Dialect/ESI/runtime/python/esiaccel/bsp/cosim.py | Wires reset_request up from MMIO and combines a delayed design reset into the user-module reset. |
| lib/Dialect/ESI/runtime/python/esiaccel/bsp/common.py | Defines reset constants, adds header MMIO reset-detect logic, and introduces DesignResetController. |
| lib/Dialect/ESI/runtime/cpp/tools/esitester.cpp | Adds reset subcommand and an implementation that verifies telemetry clears after reset. |
| lib/Dialect/ESI/runtime/cpp/lib/Accelerator.cpp | Implements AcceleratorConnection::reset() by writing the reset magic to the reset-request MMIO offset. |
| lib/Dialect/ESI/runtime/cpp/include/esi/backends/Xrt.h | Marks XRT backend reset as unsupported (always returns false). |
| lib/Dialect/ESI/runtime/cpp/include/esi/backends/Trace.h | Marks Trace backend reset as unsupported (always returns false). |
| lib/Dialect/ESI/runtime/cpp/include/esi/Accelerator.h | Adds reset magic/offset constants and a new virtual reset() API to AcceleratorConnection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Write to 0x00000E510000B007 to MMIO 0x38 to get the system to request that the BSP reset it. Assisted-by: vscode:Claude Opus 4.8
teqdruid
force-pushed
the
teqdruid/esi-reset
branch
from
610fdb9 to
e38f630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write to 0x00000E510000B007 to MMIO 0x38 to get the system to request that the BSP reset it.
Assisted-by: vscode:Claude Opus 4.8