feat(console): add app access control rules tab#8899
Merged
charIeszhao merged 1 commit intoJun 2, 2026
Merged
Conversation
charIeszhao
requested review from
gao-sun,
wangsijie and
xiaoyijun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/consts/page-tabs.ts | 📈 +19 Bytes |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/ApplicationAccessControl/index.module.scss | 📈 +1.08 KB |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/ApplicationAccessControl/index.tsx | 📈 +6.29 KB |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/ApplicationAccessControl/utils.test.ts | 📈 +1.02 KB |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/ApplicationAccessControl/utils.ts | 📈 +629 Bytes |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/MachineToMachineTabs.tsx | 📈 +1.83 KB |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/index.tsx | 📈 +710 Bytes |
| packages/phrases/src/locales/ar/translation/admin-console/application-details.ts | 📈 +2.37 KB |
| packages/phrases/src/locales/de/translation/admin-console/application-details.ts | 📈 +1.83 KB |
| packages/phrases/src/locales/en/translation/admin-console/application-details.ts | 📈 +1.48 KB |
| packages/phrases/src/locales/es/translation/admin-console/application-details.ts | 📈 +1.88 KB |
| packages/phrases/src/locales/fr/translation/admin-console/application-details.ts | 📈 +2 KB |
| packages/phrases/src/locales/it/translation/admin-console/application-details.ts | 📈 +1.79 KB |
| packages/phrases/src/locales/ja/translation/admin-console/application-details.ts | 📈 +2.1 KB |
| packages/phrases/src/locales/ko/translation/admin-console/application-details.ts | 📈 +1.8 KB |
| packages/phrases/src/locales/pl-pl/translation/admin-console/application-details.ts | 📈 +1.9 KB |
| packages/phrases/src/locales/pt-br/translation/admin-console/application-details.ts | 📈 +1.79 KB |
| packages/phrases/src/locales/pt-pt/translation/admin-console/application-details.ts | 📈 +1.89 KB |
| packages/phrases/src/locales/ru/translation/admin-console/application-details.ts | 📈 +2.8 KB |
| packages/phrases/src/locales/th/translation/admin-console/application-details.ts | 📈 +3.07 KB |
| packages/phrases/src/locales/tr-tr/translation/admin-console/application-details.ts | 📈 +1.76 KB |
| packages/phrases/src/locales/zh-cn/translation/admin-console/application-details.ts | 📈 +1.42 KB |
| packages/phrases/src/locales/zh-hk/translation/admin-console/application-details.ts | 📈 +1.48 KB |
| packages/phrases/src/locales/zh-tw/translation/admin-console/application-details.ts | 📈 +1.51 KB |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an App-level access control “Rules” tab to the Application Details page (behind isDevFeaturesEnabled), including localized copy and a new UI section that lazily loads and summarizes configured rule counts.
Changes:
- Add
ApplicationDetailsTabs.Rulesand render a new “Rules” tab (non–machine-to-machine apps, dev features only). - Introduce
ApplicationAccessControlUI that fetchesGET /applications/:id/access-controlonly when the tab is active and displays rule counters + enable switch. - Refactor machine-to-machine tab content into a dedicated
MachineToMachineTabscomponent.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/phrases/src/locales/en/translation/admin-console/application-details.ts | Adds English i18n strings for the new access control tab/section. |
| packages/phrases/src/locales/zh-cn/translation/admin-console/application-details.ts | Adds Simplified Chinese i18n strings for access control UI. |
| packages/phrases/src/locales/zh-hk/translation/admin-console/application-details.ts | Adds Traditional Chinese (HK) i18n strings for access control UI. |
| packages/phrases/src/locales/zh-tw/translation/admin-console/application-details.ts | Adds Traditional Chinese (TW) i18n strings for access control UI. |
| packages/console/src/consts/page-tabs.ts | Adds Rules to ApplicationDetailsTabs. |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/index.tsx | Wires the “Rules” tab + content; extracts M2M tab content into a separate component. |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/MachineToMachineTabs.tsx | New component encapsulating M2M-specific tab panels. |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/ApplicationAccessControl/index.tsx | New access control tab content: enable switch, SWR fetch, notifications, and rule rows. |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/ApplicationAccessControl/index.module.scss | Styles for access control tab UI. |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/ApplicationAccessControl/utils.ts | Adds helpers for determining whether rules exist + counting org-role rules. |
| packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/ApplicationAccessControl/utils.test.ts | Unit tests for the new access control helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wangsijie
approved these changes
May 29, 2026
Contributor
wangsijie
left a comment
wangsijie
left a comment
There was a problem hiding this comment.
Overall LGTM, you can translate all locales
charIeszhao
force-pushed
the
charles-log-13488-build-console-rules-tab-and-access-control-card
branch
from
ad698bc to
bfe821c
Compare
charIeszhao
force-pushed
the
charles-log-13488-build-console-rules-tab-and-access-control-card
branch
from
bfe821c to
08da617
Compare
charIeszhao
deleted the
charles-log-13488-build-console-rules-tab-and-access-control-card
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a Rules tab to application details for configuring app-level access control. The tab shows the access-control switch from application details, loads the rule config only when the tab is active, and displays rule rows for users, user roles, organizations, and organization roles.
Testing
Unit tests
Checklist
.changeset