Fix missing Trio FPU entries - #741
Merged
Merged
Conversation
aug0211
commented
Aug 16, 2026
Contributor
- LoopFollow was deduplicating Nightscout treatments by Trio's shared FPU ID, which hid the first scheduled entry from the graph
- Deduplicate by event type and occurrence time as well, preserving distinct FPU entries while still collapsing true duplicates
LoopFollow was deduplicating Nightscout treatments by Trio's shared FPU ID, which hid the first scheduled entry from the graph. Deduplicate by event type and occurrence time as well, preserving distinct FPU entries while still collapsing true duplicates.
aug0211
requested review from
bjorkert,
codebymini and
marionbarker
as code owners
August 16, 2026 03:49
bjorkert
approved these changes
Aug 26, 2026
bjorkert
left a comment
Member
There was a problem hiding this comment.
Verified against Trio's uploader: FPU siblings are uploaded with the shared fpuID as id and only created_at (Trio's NightscoutTreatment has no timestamp field), with entries spaced by the minute interval (min 10), so the occurrence key always splits siblings correctly. Ran the suite plus a simulator A/B against mock Nightscout data: dev collapsed 5 siblings to one dot (carbs today 32), with this fix all 5 render (40) and true duplicates (same id, same created_at, different _id) still collapse — the #569 behavior is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.