Skip to content

fix: conditionally import param and requestBody in controller template #11646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmustafasenoglu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: conditionally import param and requestBody in controller template #11646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/cli/generators/openapi/spec-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,13 @@
controllerSpec.methods = entry.operations.map(op =>
buildMethodSpec(controllerSpec, op, options),
);
// Track whether param and requestBody decorators are used
controllerSpec.usesParam = controllerSpec.methods.some(m =>

Check failure on line 459 in packages/cli/generators/openapi/spec-helper.js

View workflow job for this annotation

GitHub Actions / Code Lint 

Delete `m·=>`
m.signature && m.signature.includes('@param('),

Check failure on line 460 in packages/cli/generators/openapi/spec-helper.js

View workflow job for this annotation

GitHub Actions / Code Lint 

Insert `·m·=>`
);
controllerSpec.usesRequestBody = controllerSpec.methods.some(m =>

Check failure on line 462 in packages/cli/generators/openapi/spec-helper.js

View workflow job for this annotation

GitHub Actions / Code Lint 

Delete `m·=>`
m.signature && m.signature.includes('@requestBody('),

Check failure on line 463 in packages/cli/generators/openapi/spec-helper.js

View workflow job for this annotation

GitHub Actions / Code Lint 

Insert `·m·=>`
);
controllerSpec.methodMappingObject = printSpecObject(
controllerSpec.methodMapping,
);
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/generators/openapi/templates/src/controllers/controller-template.ts.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {api, operation, param, requestBody} from '@loopback/rest';<%if (withImplementation) { %>
import {api, operation<% if (usesParam) { %>, param<% } %><% if (usesRequestBody) { %>, requestBody<% } %>} from '@loopback/rest';<%if (withImplementation) { %>
import {inject} from '@loopback/core';

import {<%- serviceClassName %>} from '../services';
Expand Down
Loading