Contributors license agreement#2460
Conversation
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
There was a problem hiding this comment.
Looks fairly good to me. A few minor comments (see inline).
Also, is it intentional that the CLA.md Markdown file is not following the OpenTitan standard style of one sentence per line? I note that README.md change is using a different style again, but is consistent with the rest of that file.
828b283 to
54703a1
Compare
SamuelRiedel
left a comment
SamuelRiedel
left a comment
There was a problem hiding this comment.
Thanks for implementing this @marnovandermaas. I really appreciate it. Just a few minor questions. And finally, do we need the sign-off line and the CLA signed in the comment? If so, I think we should specify this in the README. In any case, I think it could help adding just a quick mention in the README that we will prompt new users to sign the CLA when they open their first PR. Otherwise, it might be a bit confusing to figure out how to sign the CLA.
|
I've now also added the "SIGNATURE_REPO_SECRET" to the repository. |
This agreement is distinct from but still inspired by the OpenTitan CLA: https://github.com/lowRISC/opentitan/blob/master/CLA Co-authored-by: Alex Bradbury <asb@lowrisc.org> Co-authored-by: Jay Alphey <jay.alphey@lowrisc.org> Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
This automatically checks whether people have signed the CLA for each pull request. Co-authored-by: Jay Alphey <jay.alphey@lowrisc.org> Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
This commit adds a workflow to check that all contributors sign the contributor license agreement. It also includes the lint scripts used in OpenTitan to make sure that everyone uses a sign-off message in their commit. Signed-off-by: Marno van der Maas <mvdmaas+git@lowrisc.org>
3 participants
This pull request adds a contributors license agreement to the Ibex repository. It also adds automatic checks in CI.
There is a private repository (for privacy reasons) where the signatures are stored: https://github.com/lowRISC/cla-signatures
And a private repository that shows how the action works: https://github.com/lowRISC/cla-test