Skip to content

[ibex, rtl] Move to ratified bitmanip extensions#30502

Draft
thommythomaso wants to merge 25 commits into
lowRISC:masterfrom
thommythomaso:tbenz/bitmanip
Draft

[ibex, rtl] Move to ratified bitmanip extensions#30502
thommythomaso wants to merge 25 commits into
lowRISC:masterfrom
thommythomaso:tbenz/bitmanip

Conversation

@thommythomaso

Copy link
Copy Markdown
Contributor

No description provided.

@thommythomaso thommythomaso self-assigned this Jun 24, 2026
@thommythomaso thommythomaso added the CI:Rerun Rerun failed CI jobs label Jun 26, 2026
@github-actions github-actions Bot removed the CI:Rerun Rerun failed CI jobs label Jun 26, 2026
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
* pointer.
*
* Clobbers a0, t0 and t1.
* Clobbers a0, t0, t1, t2 and t3.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This t3 clobber conflicts with the usage on line 128 (see the explanation on line 155).

(You'll probably want to change the version on sram_start_no_ast_init.S as well, for consistency, even though it shouldn't make a difference there)

@ziuziakowska ziuziakowska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instruction changes look good to me - all the unratified instructions that needed removing have been removed, and the ones that needed changing to match the ratified specification have been changed accordingly 👍

Some typos and nits: I think it makes more sense to refer to the unratified extensions without the X vendor prefix in commit messages as they were official extensions and the 0p93 captures their unratified status. There are a few typos in commit messages too, 6dbb6c6 'org.b' -> 'orc.b', and 1aebdad 'Zbkk' -> 'Zbkb'

@marnovandermaas marnovandermaas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this pull request. I think it makes sense to prepare a pull request for Ibex including RISCV-DV integration. Then we can pull those changes in here.

@thommythomaso

Copy link
Copy Markdown
Contributor Author

Thanks for preparing this pull request. I think it makes sense to prepare a pull request for Ibex including RISCV-DV integration. Then we can pull those changes in here.

Agreed. I ported my changes to lowRISC/ibex#2459.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants