[ibex, rtl] Move to ratified bitmanip extensions#30502
Conversation
2ccbfe1 to
3e8aa44
Compare
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
085b1c0 to
465cc6c
Compare
| * pointer. | ||
| * | ||
| * Clobbers a0, t0 and t1. | ||
| * Clobbers a0, t0, t1, t2 and t3. |
There was a problem hiding this comment.
This t3 clobber conflicts with the usage on line 128 (see the explanation on line 155).
(You'll probably want to change the version on sram_start_no_ast_init.S as well, for consistency, even though it shouldn't make a difference there)
There was a problem hiding this comment.
The instruction changes look good to me - all the unratified instructions that needed removing have been removed, and the ones that needed changing to match the ratified specification have been changed accordingly 👍
Some typos and nits: I think it makes more sense to refer to the unratified extensions without the X vendor prefix in commit messages as they were official extensions and the 0p93 captures their unratified status. There are a few typos in commit messages too, 6dbb6c6 'org.b' -> 'orc.b', and 1aebdad 'Zbkk' -> 'Zbkb'
marnovandermaas
left a comment
There was a problem hiding this comment.
Thanks for preparing this pull request. I think it makes sense to prepare a pull request for Ibex including RISCV-DV integration. Then we can pull those changes in here.
Agreed. I ported my changes to lowRISC/ibex#2459. |
No description provided.