Development: Port new gender contracts - #2638
Open
ge94zec wants to merge 12 commits into
Open
Conversation
- display gender decoder results and balance indicator in the AI sidebar - reuse status pills with counts, loading state, and active styling - highlight non-inclusive wording with wavy underlines in the editor - allow filtering between gender and compliance highlights - deduplicate and sanitize non-inclusive words in a shared utility - add English and German translations for the gender pill - remove unrelated background process and analysis pause changes - simplify tests
…accuracy-using-ai' into feat/2378-improve-genderdecoder-accuracy-using-ai
- strip compliance and gender highlight markup from editor values - track gender analysis loading independently per editor field - bind the gender pill to its dedicated loading state - center the gender balance indicator without fixed offsets - cover editor event handling and pill loading states
… feat/2637-port-new-gender-contracts # Conflicts: # src/main/webapp/app/job/job-creation-form/job-creation-form.component.html # src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts # src/main/webapp/app/shared/components/atoms/editor/editor.component.ts # src/main/webapp/app/shared/components/molecules/ai-assistant-card/ai-assistant-card.component.ts # src/main/webapp/app/shared/gender-bias-analysis/gender-bias-analysis.ts # src/main/webapp/app/shared/gender-bias-analysis/gender-bias-analysis.utils.ts # src/test/webapp/app/shared/components/atoms/editor/editor.component.spec.ts # src/test/webapp/util/gender-bias-analysis.service.mock.ts
8 tasks
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 medium |
| CodeStyle | 3 minor |
🟢 Metrics 17 complexity
Metric Results Complexity 17
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
- replace the removed gender-bias analysis response with BiasedIssueDTO arrays - derive inclusive, non-inclusive, and neutral states from biased issue types - update the editor highlights, analysis dialog, assistant card, and review count - source gender findings and loading state from the existing job analysis workflow - remove client-side gender-bias analysis service and test mock - update affected component and utility tests for the new contracts
ge94zec
changed the base branch from
main
to
bugfix/2379-fix-excessive-api-requests-triggering-genderdecoder
August 22, 2026 10:46
Development: Port new gender contracts
Contributor
|
📊 Client Test Coverage Too Low 🔍 View coverage locally: pnpm run test:ci
open build/test-results/vitest/coverage/index.html🌐 View coverage from GitHub: |
Contributor
|
🤖 No OpenAPI or client changes needed. |
Contributor
|
🤖 No OpenAPI or client changes needed. |
ge94zec
marked this pull request as ready for review
August 22, 2026 11:00
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
General
Client
Motivation and Context
This PR ports the Gender Decoder integration to the new BiasedIssue / JobAnalysisDTO contracts ahead of the dependent PRs being merged, so the required compatibility changes are already prepared and don’t block on merge order.
Fixes: #2637 resulting from #2630 and #2465 will collide head-on.
Description
The editor no longer subscribes to
GenderBiasAnalysisService.getAnalysisForField(). It receives findings through a newbiasedAnalysisinput instead, so the removed endpoint is no longer referenced from the atom.toObservable,fieldIdChanges$and the service injection are gone;genderBiasHighlightsnow derives from the input.Contract migration
GenderBiasAnalysisResponse/BiasedWordDTO→BiasedIssueDTOcodingstring values ('non-inclusive-coded','inclusive-coded') →computeCodingStatus()returning'NON_INCLUSIVE'/'INCLUSIVE'/'NEUTRAL'type: 'non-inclusive'→BiasedIssueDTOTypeEnum.NON_INCLUSIVEComplianceIssue→ComplianceIssueDTOin the assistant card and filter typesPrerequisites:
Review Progress
Code Review
Manual Tests
Screenshots
Test Coverage
Warning: Some tests failed in the PR check. Coverage may be incomplete. Please check the workflow logs.
Client
Last updated: 2026-08-22 10:51:49 UTC