Skip to content

Boundary conditions docs, PR stack of #2062 - #2063

Open
echen5503 wants to merge 6 commits into
lululxvi:masterfrom
echen5503:boundary_conditions_docs
Open

echen5503 wants to merge 6 commits into
lululxvi:masterfrom
echen5503:boundary_conditions_docs

Conversation

@echen5503

Copy link
Copy Markdown
Contributor

IC/BC is underdocumented, basic documentation added where necessary.

Please review #2062 first as this is a PR stack.

@lululxvi

Copy link
Copy Markdown
Owner

Fix the conflict.

@echen5503

Copy link
Copy Markdown
Contributor Author

Resolved merge conflicts.

Comment thread deepxde/icbc/boundary_conditions.py Outdated
@echen5503

Copy link
Copy Markdown
Contributor Author

Deleted unnecessary pass.

Comment thread deepxde/icbc/boundary_conditions.py Outdated
"""Robin boundary conditions: dy/dn(x) = func(x, y)."""
"""Robin boundary condition: $\frac{\partial y}{\partial n}(x) = f(x, y)$.

A weighted combination of Dirichlet and Neumann conditions.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this line.

Removed unnecessary comments from RobinBC class.
@echen5503

Copy link
Copy Markdown
Contributor Author

Deleted the comment that is a bit misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants