Skip to content

Update cmake build tools#347

Draft
jingyuexing wants to merge 2 commits into
lunarmodules:masterfrom
jingyuexing:cmake-build
Draft

Update cmake build tools#347
jingyuexing wants to merge 2 commits into
lunarmodules:masterfrom
jingyuexing:cmake-build

Conversation

@jingyuexing

Copy link
Copy Markdown

No description provided.

@alerque

alerque commented Mar 19, 2022

Copy link
Copy Markdown
Member

I'm curious why you call this an "update" since it seems to be adding CMake tooling from scratch. Did this originate somewhere else? I'm happy to consider this, but I'm a little hesitant to add an alternative build system before we clean up the one we have and get automated testing working properly. Also I'd like to hear what the use-case for this is that would make in worth the maintenance overhead above just having a normal LuaRocks based install. Lastly, will you be around to keep iterating on this as we possibly shuffle things around in the build. It would be good if we had somebody that was actually going to maintain the CMake side of things if we're going to include it here.

@alerque alerque left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in a position to test this, so (in addition to answering the questions in my other comment) automated tests will be required before we even consider merging. Consider rebasing or a merge from master after testing related PRs like #356 have landed. We'll want some sort of check to that confirms the CMake system is functional with the matching current source tree.

@alerque alerque marked this pull request as draft March 19, 2022 18:51
@jingyuexing

Copy link
Copy Markdown
Author

I'm curious why you call this an "update" since it seems to be adding CMake tooling from scratch. Did this originate somewhere else? I'm happy to consider this, but I'm a little hesitant to add an alternative build system before we clean up the one we have and get automated testing working properly. Also I'd like to hear what the use-case for this is that would make in worth the maintenance overhead above just having a normal LuaRocks based install. Lastly, will you be around to keep iterating on this as we possibly shuffle things around in the build. It would be good if we had somebody that was actually going to maintain the CMake side of things if we're going to include it here.

I believe there are many people who have the same problem as me, which is "cannot compile socket library on windows". Because makefiles are better for development environment on *nix systems

@alerque

alerque commented Nov 8, 2023

Copy link
Copy Markdown
Member

#415 added some Windows CI jobs checking the build on the Windows side of things, at least with MSCV. #315 also has some cmake related stuff with a different route to build. @leso-kn Any input here? I'm not a Windows guy at all. I'm happy to facilitate contributions but I'm kind of out of my depth on the Windows side of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants