🛡️ Sentinel: Fix missing blacklist check in token verification - #23
🛡️ Sentinel: Fix missing blacklist check in token verification#23google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Added explicit check to `AuthService.verifyToken` to reject tokens that are present in the blacklist (Redis). - Ensures that logged-out users (or revoked tokens) cannot continue to access protected resources until token expiration. - This addresses a logic flaw where `verifyToken` relied only on signature verification and user existence.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes a security vulnerability in the authentication logic. Previously,
verifyTokendid not check if a token was blacklisted (e.g., after logout), allowing revoked tokens to be used until their natural expiration. This change adds a call toisTokenBlacklistedwithinverifyTokento ensure revoked tokens are rejected immediately. Verified with unit tests mocking Redis and Prisma.PR created automatically by Jules for task 1742037873470770609 started by @Magnopiro-oficial