🛡️ Sentinel: [HIGH] Fix Token Revocation Bypass - #41
Conversation
🚨 Severity: HIGH 💡 Vulnerability: Improper Session Management (Token Revocation Bypass). The application was using `request.jwtVerify()` which only checks signature/expiration, ignoring the token blacklist (Redis). Revoked tokens (e.g., from logout) remained valid until expiration. 🎯 Impact: Users could continue using the API after logging out, or if a token was compromised and revoked, it would still work. 🔧 Fix: 1. Created `authenticate` middleware in `backend/src/shared/middleware/auth.middleware.ts` that checks both signature AND blacklist status. 2. Updated `verifyToken` in `AuthService` to also check blacklist. 3. Refactored all protected routes (`user`, `project`, `ama`, `analytics`) to use the new `authenticate` middleware. ✅ Verification: 1. Created unit test `backend/src/shared/middleware/auth.middleware.test.ts`. 2. Verified that middleware rejects blacklisted tokens with 401. Co-authored-by: Magnopiro-oficial <122941268+Magnopiro-oficial@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Improper Session Management (Token Revocation Bypass). The application was using
request.jwtVerify()which only checks signature/expiration, ignoring the token blacklist (Redis). Revoked tokens (e.g., from logout) remained valid until expiration.🎯 Impact: Users could continue using the API after logging out, or if a token was compromised and revoked, it would still work.
🔧 Fix:
authenticatemiddleware inbackend/src/shared/middleware/auth.middleware.tsthat checks both signature AND blacklist status.verifyTokeninAuthServiceto also check blacklist.user,project,ama,analytics) to use the newauthenticatemiddleware.✅ Verification:
backend/src/shared/middleware/auth.middleware.test.ts.PR created automatically by Jules for task 10488602334314933430 started by @Magnopiro-oficial