π‘οΈ Sentinel: [HIGH] Fix Auth Bypass via Token Blacklist - #44
π‘οΈ Sentinel: [HIGH] Fix Auth Bypass via Token Blacklist#44Magnopiro-oficial wants to merge 1 commit into
Conversation
Co-authored-by: Magnopiro-oficial <122941268+Magnopiro-oficial@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Insecure Session Management / Auth Bypass. The application was verifying JWT signatures but failing to check the token blacklist (Redis), allowing revoked tokens (e.g., after logout) to continue accessing protected endpoints until expiration.
π― Impact: An attacker (or a user on a shared device) could use a stolen or logged-out token to access sensitive user data (
/me,/users/*) or perform actions (2fasetup) even after the user explicitly logged out.π§ Fix: Introduced a centralized
authenticatemiddleware inbackend/src/shared/middleware/auth.middleware.tsthat enforcesAuthService.isTokenBlacklisted(token). Refactoredauth.routes.tsanduser.routes.tsto use this middleware instead of rawjwtVerify.β Verification:
npm run buildinbackend/-> Passed.npm testinbackend/(after addingjest.config.jsandjest.setup.jsand unit tests) -> Passed.authenticatereturns 401 ifisTokenBlacklistedreturns true.PR created automatically by Jules for task 2451513121567140727 started by @Magnopiro-oficial