Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix Auth Bypass via Token Blacklist - #44

Open
Magnopiro-oficial wants to merge 1 commit into
mainfrom
sentinel/fix-auth-bypass-2451513121567140727
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix Auth Bypass via Token Blacklist#44
Magnopiro-oficial wants to merge 1 commit into
mainfrom
sentinel/fix-auth-bypass-2451513121567140727

Conversation

@Magnopiro-oficial

Copy link
Copy Markdown
Contributor

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Insecure Session Management / Auth Bypass. The application was verifying JWT signatures but failing to check the token blacklist (Redis), allowing revoked tokens (e.g., after logout) to continue accessing protected endpoints until expiration.
🎯 Impact: An attacker (or a user on a shared device) could use a stolen or logged-out token to access sensitive user data (/me, /users/*) or perform actions (2fa setup) even after the user explicitly logged out.
πŸ”§ Fix: Introduced a centralized authenticate middleware in backend/src/shared/middleware/auth.middleware.ts that enforces AuthService.isTokenBlacklisted(token). Refactored auth.routes.ts and user.routes.ts to use this middleware instead of raw jwtVerify.
βœ… Verification:

  1. Ran npm run build in backend/ -> Passed.
  2. Ran npm test in backend/ (after adding jest.config.js and jest.setup.js and unit tests) -> Passed.
  3. Unit tests confirm that authenticate returns 401 if isTokenBlacklisted returns true.

PR created automatically by Jules for task 2451513121567140727 started by @Magnopiro-oficial

Co-authored-by: Magnopiro-oficial <122941268+Magnopiro-oficial@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant