Fix setuptools constraint for pip >= 26.2 via PIP_BUILD_CONSTRAINT - #227
Merged
Conversation
pip 26.2 enforces that PIP_CONSTRAINT no longer applies to isolated build environments, so the setuptools pin stopped protecting the mmcv sdist build (setup.py imports pkg_resources, removed in setuptools 82). Export PIP_BUILD_CONSTRAINT alongside PIP_CONSTRAINT and relax the unittests pin to the verified bound (<82, matching end2end and constraints.txt).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request applies ChangesBuild constraint updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
dtronmans
approved these changes
Jul 31, 2026
Test Results 6 files 6 suites 14m 23s ⏱️ Results for commit 36462c3. |
klemen1999
added a commit
to luxonis/luxonis-ml
that referenced
this pull request
Jul 31, 2026
Picks up the PIP_BUILD_CONSTRAINT fix (luxonis/tools#227) needed since pip >= 26.2 no longer applies PIP_CONSTRAINT to isolated build environments, which broke the mmcv sdist build in the BOM tools tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
pip 26.2 enforces that PIP_CONSTRAINT no longer applies to isolated build environments, so the setuptools pin stopped protecting the mmcv sdist build (setup.py imports pkg_resources, removed in setuptools 82). Export PIP_BUILD_CONSTRAINT alongside PIP_CONSTRAINT and relax the unittests pin to the verified bound (<82, matching end2end and constraints.txt).
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
AI Usage
Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Submitted code was reviewed by a human: YES/NO
The author is taking the responsibility for the contribution: YES/NO
Summary by CodeRabbit
Documentation
Chores