feature: add musl pre-built builds for utp-native#51
Open
SilentBot1 wants to merge 13 commits into
Open
Conversation
…ython 3.12, which is now default for the version of the ubuntu 16 action runner.
… same, as while being tagged with musl, nothing musl was actually being set.
FEAT: Add MUSL support
This was referenced Jun 16, 2024
This ensures that we use an early version of glibc is used to provide the widest compatibility.
Update ubuntu 18.04 to 20.04 as the runner for 18.04 was removed earlier this year, causing the run to hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
This PR updates the GitHub actions to get it back to a running state and introduces
muslpre-built builds ofutp-nativeto allow utp-native to function on alpine-based docker images or systems which use musl over glibc.The changes include:
musl-toolsandmuslfor Ubuntu to allow musl pre-builds to be generatednode-gypto the devDependencies, as this is required bynode-gyp-build, and the version installed in the GitHub npm cache for the ubuntu-latest runner does not work with the version of python installed in the runner.Which issue (if any) does this pull request address?