This repository was archived by the owner on Jan 28, 2025. It is now read-only.
fix(eval): fixes variadic helper calls - #14
Open
pbedat wants to merge 2 commits into
Open
Conversation
args was fixed to the number of arguments of the function, but only iterated over the provided parameters the last arg remained an invalid value that led to a panic the args are now appended on demand to correctly match the variadic signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see aymerick#14
args was fixed to the number of arguments of the function, but only iterated over the provided parameters
the last arg remained an invalid value that led to a panic
the args are now appended on demand to correctly match the variadic signature