Repository navigation
add projects API #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
add projects API #67
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ffe4db3
add projects API
jurgens ddbef79
fix documentation
jurgens 8f5b1d6
fix spec
jurgens 4a92345
upd docs
jurgens 5f8111c
fix code review comments
jurgens 7af80f2
remove unused method and spec, do not use default env values as they …
jurgens 67830f9
add cassettes
jurgens b608f3e
remove constructor, fix attribute type
jurgens 48a4cc5
improve sensitive data scrubbing, re-record cassettes
jurgens 0dec44c
rename variable in a spec
jurgens ba37008
style edits
jurgens f24d820
update cassettes
jurgens 0e67855
ignore .claude
jurgens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ | |
| *.DS_Store | ||
| .vscode | ||
| .idea | ||
| .claude | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module Mailtrap | ||
| # Data Transfer Object for Project | ||
| # @see https://api-docs.mailtrap.io/docs/mailtrap-api-docs/ee252e413d78a-create-project | ||
| # @attr_reader id [Integer] The project ID | ||
| # @attr_reader name [String] The project name | ||
| # @attr_reader share_links [Hash] Admin and viewer share links | ||
| # @attr_reader inboxes [Array] Array of inboxes | ||
| # @attr_reader permissions [Hash] List of permissions | ||
| Project = Struct.new( | ||
| :id, | ||
| :name, | ||
| :share_links, | ||
| :inboxes, | ||
| :permissions, | ||
| keyword_init: true | ||
| ) do | ||
| # @return [Hash] The project attributes as a hash | ||
| def to_h | ||
| super.compact | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require_relative 'base_api' | ||
| require_relative 'project' | ||
|
|
||
| module Mailtrap | ||
| class ProjectsAPI | ||
| include BaseAPI | ||
|
|
||
| self.supported_options = %i[name] | ||
|
|
||
| self.response_class = Project | ||
|
|
||
| # Lists all projects for the account | ||
| # @return [Array<Project>] Array of projects | ||
| # @!macro api_errors | ||
| def list | ||
| base_list | ||
| end | ||
|
|
||
| # Retrieves a specific project | ||
| # @param project_id [Integer] The project ID | ||
| # @return [Project] Project object | ||
| # @!macro api_errors | ||
| def get(project_id) | ||
| base_get(project_id) | ||
| end | ||
|
|
||
| # Creates a new project | ||
| # @param [Hash] options The parameters to create | ||
| # @option options [String] :name The project name | ||
| # @return [Project] Created project object | ||
| # @!macro api_errors | ||
| # @raise [ArgumentError] If invalid options are provided | ||
| def create(options) | ||
| base_create(options) | ||
| end | ||
|
|
||
| # Updates an existing project | ||
| # @param project_id [Integer] The project ID | ||
| # @param [Hash] options The parameters to update | ||
| # @return [Project] Updated project object | ||
| # @!macro api_errors | ||
| # @raise [ArgumentError] If invalid options are provided | ||
| def update(project_id, options) | ||
| base_update(project_id, options) | ||
| end | ||
|
|
||
| # Deletes a project | ||
| # @param project_id [Integer] The project ID | ||
| # @return nil | ||
| # @!macro api_errors | ||
| def delete(project_id) | ||
| base_delete(project_id) | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def base_path | ||
| "/api/accounts/#{account_id}/projects" | ||
| end | ||
|
|
||
| def wrap_request(options) | ||
| { project: options } | ||
| end | ||
| end | ||
| end |
176 changes: 89 additions & 87 deletions
176
...ssettes/Mailtrap_EmailTemplatesAPI/_create/maps_response_data_to_EmailTemplate_object.yml
Large diffs are not rendered by default.
Oops, something went wrong.
170 changes: 86 additions & 84 deletions
170
.../Mailtrap_EmailTemplatesAPI/_create/when_API_returns_an_error/raises_a_Mailtrap_Error.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be Inboxes API. It will define Inbox model. Project should return not the list of hashes but the list of inboxes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I will check
as for tests - they are passing for me locally
I don't have access to test results here (I see them all as "waiting") so please advise what I would need to do to get them pass - I guess it might be some sort of setup issue