Skip to content

Configuration: Support YAML anchors and aliases in .herb.yml #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matiasleidemer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Configuration: Support YAML anchors and aliases in .herb.yml #1632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/herb/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def load_config
return deep_merge(DEFAULTS, {}) unless @config_path&.exist?

begin
user_config = YAML.safe_load_file(@config_path, permitted_classes: [Symbol]) || {}
user_config = YAML.safe_load_file(@config_path, permitted_classes: [Symbol], aliases: true) || {}
deep_merge(DEFAULTS, user_config)
rescue Psych::SyntaxError => e
warn "Warning: Invalid YAML in #{@config_path}: #{e.message}"
Expand Down
18 changes: 18 additions & 0 deletions test/configuration_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,24 @@ def write_config(content, filename = ".herb.yml")
assert_includes config.file_include_patterns, "**/*.custom.erb"
end

test "loads configuration using YAML anchors and aliases" do
write_config(<<~YAML)
version: "0.9.6"
files:
include: &patterns
- "**/*.custom.erb"
- "**/*.other.erb"
exclude: *patterns
YAML

config = Herb::Configuration.load(@temp_dir)

assert_includes config.file_include_patterns, "**/*.custom.erb"
assert_includes config.file_include_patterns, "**/*.other.erb"
assert_includes config.file_exclude_patterns, "**/*.custom.erb"
assert_includes config.file_exclude_patterns, "**/*.other.erb"
end

test "searches parent directories for config file" do
subdir = File.join(@temp_dir, "app", "views")
FileUtils.mkdir_p(subdir)
Expand Down