This repository was archived by the owner on May 22, 2026. It is now read-only.
fix infinite loading#18
Open
ptcc wants to merge 1 commit into
Open
Conversation
djhi
approved these changes
May 24, 2018
Member
|
I fail to see how that fixes the issue, can you elaborate on the solution? |
Author
|
by moving the put of FETCH_START inside the try/catch block we ensure that FETCH_CANCEL will still be dispatched if the saga is canceled after the FETCH_START put and before the (and that is exactly where it gets canceled in the case described in the issue) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #17