Conversation
In CachingMode.Lazy, handler wrappers were registered in DI using the message type as the service type. ASP.NET Core Minimal APIs then bound message parameters from DI instead of from the request body (martinothamar#278). Wrappers are now registered by their own type, and message types are mapped to wrapper types for lookups based on the runtime type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #278
Problem
In
CachingMode.Lazy, handler wrappers were registered in DI using the message type as the service type:ASP.NET Core Minimal APIs use
IServiceProviderIsServiceto decide where to bind a parameter from.MyCommandwas reported as a service, so it was bound from DI instead of the request body. The result was anInvalidCastException.Fix
RequestHandlerWrapper<,>,NotificationHandlerWrapper<>, ...), and the typedSend/Publish/CreateStreammethods resolve them by that type.ContainerMetadatanow has aHandlerWrapperTypesmap from message type to wrapper type. It only holdstypeofpairs, so the wrappers themselves are still resolved lazily.Commits
IServiceProviderIsService+GetService)cm=Lsnapshots change)Testing
mainin Lazy mode (7/7) and passes with the fixMediator.Testson net10.0: all lifetimes (Singleton/Scoped/Transient) × sizes (Default/Large) × caching modes (Eager/Lazy) passMediator.SourceGenerator.Tests: 182/190 pass. The 8SampleTestsfailures are the same as onmain(NuGet audit warnings), fixed by Bump Scriban to 7.4.0 to fix known vulnerabilities #288 and Bump sample package versions to fix known vulnerabilities #289