Repository navigation
Conversation
|
@0Miles is attempting to deploy a commit to the Aoyue Team on Vercel. A member of the Team first needs to authorize it. |
The package had no executable binary entry; pnpm install -g produced nothing in the global bin directory, so non-VSCode LSP hosts (Neovim, Helix, Sublime) couldn't spawn it. - Adds src/bin/index.ts (CJS shim that requires the built core and calls new CSSLanguageServer().start()) - Adds bin field to package.json: mcss-language-server and master-css-language-server both point to ./dist/bin/index.cjs - CJS over ESM because vscode-languageserver/node and vscode-css-languageservice/lib/umd/... have no exports map and fail Node 22 ESM resolution - Real spawn test in tests/bin.test.ts: spawns the built bin, sends LSP initialize, asserts capabilities reply - Updates css-docs/modules/language-server.md Closes master-co#313
0Miles
force-pushed
the
fix/313-language-server-bin
branch
from
April 30, 2026 19:00
957a308 to
1289152
Compare
Member
|
Already supported; no action needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #313. The
@master/css-language-serverpackage had no executable binary entry —pnpm install -g @master/css-language-serverproduced nothing in the global bin directory, so non-VSCode LSP hosts (Neovim, Helix, Sublime) couldn't spawn it.Changes
src/bin/index.ts(CJS shim that requires the builtcoreand callsnew CSSLanguageServer().start())binfield topackage.json:mcss-language-serverandmaster-css-language-serverboth point to./dist/bin/index.cjscss-docs/modules/language-server.mdwith a "Standalone binary" sectionWhy CJS, not ESM
The existing ESM build of this server re-exports through nested dependency subpaths (
vscode-languageserver/node,vscode-css-languageservice/lib/umd/...) that have no `exports` map and therefore fail Node ≥ 22 ESM resolution. CJS `require` is forgiving and is what every LSP host ends up spawning anyway.Testing