Repository navigation
Fix(CSS): {prop:val|val} group declarations render literal pipe - #417
Merged
Merged
Conversation
|
@0Miles is attempting to deploy a commit to the Aoyue Team on Vercel. A member of the Team first needs to authorize it. |
| to space in {prop:val|val} group declarations, resolve #363{paint-order:stroke|fill} produced paint-order: stroke|fill (literal
pipe) which browsers reject. Master CSS uses | as a class-name-safe
space separator (because actual spaces would break HTML class
attribute parsing) but the { ... } group declarer was preserving the
literal pipe in the value.
- declarers/core.group.ts:addProp replaces | with space when
extracting the property value
- 4 regression tests covering single value, 2-value list, 3-value
list, and bg:white|red regression (regular non-group rule still
works)
- Real Chrome verification: pre-fix paint-order rejected (computed
"normal"); post-fix accepted (computed "stroke")
Closes master-co#363
0Miles
force-pushed
the
fix/363-property-fallback
branch
from
April 30, 2026 19:02
e521fb8 to
dd7bf65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #363.
Summary
`{paint-order:stroke|fill}` produced `paint-order: stroke|fill` (literal pipe) which browsers reject. Master CSS uses `|` as a class-name-safe space separator (because actual spaces would break HTML class attribute parsing) but the `{ ... }` group declarer was preserving the literal pipe in the value.
Changes
Testing