Skip to content

Don't add file:// to windows path in CommonJS files. (mathjax/MathJax#3585)#1519

Merged
dpvc merged 1 commit into
developfrom
issue3585
Jul 2, 2026
Merged

Don't add file:// to windows path in CommonJS files. (mathjax/MathJax#3585)#1519
dpvc merged 1 commit into
developfrom
issue3585

Conversation

@dpvc

@dpvc dpvc commented Jul 2, 2026

Copy link
Copy Markdown
Member

This PR fixes a problem with using MathJax CommonJS modules in node applications on windows. Apparently the file:// should not be added to absolute paths for CommonJS, but only should be for ESM modules.

Resolves issue mathjax/MathJax#3585.

@dpvc dpvc requested a review from zorkow July 2, 2026 15:43
@dpvc dpvc added this to the v4.1.3 milestone Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.47%. Comparing base (907df71) to head (84ac9c8).

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1519     +/-   ##
==========================================
  Coverage    86.47%   86.47%             
==========================================
  Files          340      340             
  Lines        86170    86176      +6     
  Branches      3210     4856   +1646     
==========================================
+ Hits         74513    74519      +6     
+ Misses       11657    11636     -21     
- Partials         0       21     +21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zorkow zorkow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not test. But lgtm.

@dpvc dpvc merged commit f88d6cc into develop Jul 2, 2026
3 checks passed
@dpvc dpvc deleted the issue3585 branch July 2, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants