Skip to content

Command line config file download util#622

Open
CodeOhms wants to merge 31 commits into
matlo:masterfrom
CodeOhms:master
Open

Command line config file download util#622
CodeOhms wants to merge 31 commits into
matlo:masterfrom
CodeOhms:master

Conversation

@CodeOhms

Copy link
Copy Markdown

Updated the TUI code to use less memory, and added a help menu. Just need to implement autoConfig() functionality. Also thinking of changing the name of the program and moving it under 'utils' directory.

Zac and others added 19 commits August 14, 2018 22:24
Now prints to terminal. Needs fix for downloading as config download …
…y to browse truncated strings using left and right arrow keys.
…enu needs to be implemented, to show the user which buttons to use to navigate this tool. Fixed a fatal mistake where local copy of ttyProgressDialog was being used again for config dl despite going out of scope.
@CodeOhms

CodeOhms commented Aug 9, 2019

Copy link
Copy Markdown
Author

This program is ready, when you are.

@matlo

matlo commented Aug 9, 2019

Copy link
Copy Markdown
Owner

Thanks!

Please fix the remaining compilation warnings: https://travis-ci.com/matlo/GIMX/builds/122616488

@CodeOhms

CodeOhms commented Aug 9, 2019

Copy link
Copy Markdown
Author

Sure

@CodeOhms

Copy link
Copy Markdown
Author

Okay, all compiler warnings have now vanished for my program. Enjoy!

@matlo matlo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review. Main issue is file handling. I'll try to make some shared code to help fixing this.
Please replace tab indentation with 4-space indentation.

Comment thread Makedefs Outdated
Comment thread Makedefs Outdated
Comment thread fetchconfig/Makefile Outdated
Comment thread fetchconfig/configDownload.cpp Outdated
Comment thread fetchconfig/configDownload.cpp Outdated
Comment thread fetchconfig/include/parseArgs.h Outdated
Comment thread fetchconfig/include/easyCurses.h Outdated
Comment thread fetchconfig/include/configDownload.h Outdated
Comment thread fetchconfig/include/configDownload.h Outdated
Comment thread fetchconfig/include/configDownload.h Outdated
@CodeOhms

Copy link
Copy Markdown
Author

Thanks for taking the time to give feedback - means a lot to a beginner! I'll start working on those changes. If you like, I could also pull all the code I copied directly from gimx-launcher into a shared library.

Comment thread Makedefs
Comment thread Makedefs
Comment thread fetchconfig/parseArgs.cpp Outdated
int callOptions(struct option* longOptions, int optionCharacter, int optionIndex)
{
int result = 0;
int result = -1;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parseArgs now stops on first "non-flag" option.

@matlo

matlo commented Aug 13, 2019

Copy link
Copy Markdown
Owner

I tested the manual download. In my opinion page up and page down should be inverted. Page down is usually used to go forward, and page up backward.

@CodeOhms

Copy link
Copy Markdown
Author

Okay

Comment thread fetchconfig/easyCurses.cpp
Comment thread fetchconfig/easyCurses.cpp
@matlo

matlo commented Aug 13, 2019

Copy link
Copy Markdown
Owner

On Ubuntu with a terminal size of 46x13, app crashes when displaying page 10.

@CodeOhms

Copy link
Copy Markdown
Author

I believe this is a rounding error, there should have been 9 pages. While cleaning up my code I noticed how badly it deals with corner cases when lines overflow the screen width. In spare time I've been writing a new mapping system, which is a lot easier to use. It will be fixed soon. I apologise. :)

…e system for handling input text. This means it can handle almost any custom terminal size. Also removed accidentally included binary file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants