Skip to content

fix: Request CAMERA_SETTINGS on zoom and focus#14519

Draft
jnomikos wants to merge 1 commit into
mavlink:masterfrom
jnomikos:camera_fov_fixes
Draft

fix: Request CAMERA_SETTINGS on zoom and focus#14519
jnomikos wants to merge 1 commit into
mavlink:masterfrom
jnomikos:camera_fov_fixes

Conversation

@jnomikos

@jnomikos jnomikos commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

The changes from PR #13612 do not actually end up requesting CAMERA_SETTINGS whenever zoom level or focus changes. Thus, QGC may request CAMERA_SETTINGS (and thus CAMERA_FOV_STATUS) once, but it won't necessarily do so after that. This could result in the FOV stored on QGC not actually reflecting the FOV of the camera after zooming.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/Build changes
  • Other

Testing

  • Tested locally
  • Added/updated unit tests
  • Tested with simulator (SITL)
  • Tested with hardware

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Flight Stacks Tested

  • PX4
  • ArduPilot

Screenshots

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally

Related Issues


By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

@jnomikos jnomikos changed the title fix: Request CAMERA_SETTINGS (& CAMERA_FOV_STATUS) on zoom and focus fix: Request CAMERA_SETTINGS on zoom and focus Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Build results unavailable — artifact download from one or more platform workflows failed (likely artifact retention expiry or transient API error). The combined report cannot be generated for this run.

See the Build Results workflow run for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant