style(FirmwareUpgrade): clang-format FirmwareImage and FirmwareUpgradeController#14532
style(FirmwareUpgrade): clang-format FirmwareImage and FirmwareUpgradeController#14532dakejahl wants to merge 1 commit into
Conversation
…eController These files predate clang-format enforcement and were never reformatted, so any change to them triggers a whole-file reformat that buries the real diff. Reformat them in isolation (clang-format 21.1.7 with the repo's .clang-format) with no functional changes, so follow-up work rebased on top shows a clean, formatting-free diff.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (13.39%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #14532 +/- ##
==========================================
+ Coverage 25.47% 30.64% +5.17%
==========================================
Files 769 772 +3
Lines 65912 66810 +898
Branches 30495 30813 +318
==========================================
+ Hits 16788 20474 +3686
+ Misses 37285 32703 -4582
- Partials 11839 13633 +1794
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 319 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 75 failed, 7 skipped. Test Resultslinux-coverage: 100 passed, 0 skipped Code CoverageCoverage: 65.1% No baseline available for comparison Artifact Sizes
Updated: 2026-06-15 02:45:26 UTC • Commit: bd5d34f • Triggered by: Android |
1 participant
Summary
Apply clang-format (the repo's pinned 21.1.7 config) to FirmwareImage and FirmwareUpgradeController with no functional changes.
Problem
These files predate clang-format enforcement and are not
.clang-format-compliant. Since the pre-commit/CI check formats whole files, any PR that touches them is forced to reformat the entire file, burying the real change under hundreds of lines of pointer-alignment, include-sorting, brace-style and comment-reflow churn. #14530 is the immediate case.Solution
Reformat the files in isolation so the churn lands as a standalone, trivially-verifiable commit. The diff is pure formatting — identical include set, and code token-identical to master ignoring whitespace — and #14530 rebases on top to show a clean, formatting-free diff.