Skip to content

chore(deps): upgrade all deps - #481

Closed
setchy wants to merge 21 commits into
max-mapper:masterfrom
setchy:chore/dep-updates
Closed

chore(deps): upgrade all deps#481
setchy wants to merge 21 commits into
max-mapper:masterfrom
setchy:chore/dep-updates

Conversation

@setchy

@setchy setchy commented Jun 25, 2024

Copy link
Copy Markdown
Contributor
  1. Run ncu -u to update deps
  2. reconfigure typedoc (typedoc.json)
  3. generate new /docs via yarn docs

@setchy

setchy commented Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

pending merge of #478

setchy added 15 commits June 25, 2024 14:02
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Comment thread package.json Outdated
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy

setchy commented Oct 10, 2025

Copy link
Copy Markdown
Contributor Author

@amaury1093 - i've refreshed this pr which bumps all deps to their latest version and renegerates the typedocs. this brings menubar up to electron 38.x

Comment thread src/util/cleanOptions.ts
Comment on lines +7 to +8
import path from 'node:path';
import url from 'node:url';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly worried this will impact some users in some unexpected ways. Can you give me reassurance this won't?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import changes which add 'node: prefix is addressing this biome linter rule: https://biomejs.dev/linter/rules/use-nodejs-import-protocol/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has quite a number of dep upgrades,we could release as a new major or minor version (not patch)

@setchy
setchy requested review from amaury1093 and gobengo October 10, 2025 16:52
@RobbieTheWagner

Copy link
Copy Markdown
Contributor

Would love to have support up to Electron 38! 🎉

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy

setchy commented Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

updated to include electron v39

@RobbieTheWagner

Copy link
Copy Markdown
Contributor

@amaury1093 if you are able to add me as a maintainer, I would be glad to help out with keeping things up to date.

@amaury1093

Copy link
Copy Markdown
Collaborator

@amaury1093 if you are able to add me as a maintainer, I would be glad to help out with keeping things up to date.

I'm not

@RobbieTheWagner

Copy link
Copy Markdown
Contributor

@max-mapper any interest in adding some maintainers?

@tiagotedsky

Copy link
Copy Markdown

Hello,

This package is very important. Do you want another contributor?

Thank you

@afonsojramos

afonsojramos commented Jul 29, 2026

Copy link
Copy Markdown

For context on why this went stale: menubar has had no commits since the 9.5.2 release, so we picked up maintenance in a fork, published as electron-menubar (repo).

The dependency upgrades in this PR are done there, along with Electron 35+ support, electron-positioner ported in (so zero runtime dependencies), Linux SNI context-menu fixes, and a few new options (hideOnClose, escapeToHide, trigger, globalShortcut). It's API-compatible with v9, so it's usually a one-line import swap.

We're treating it as the continuation of this project rather than a private copy: it's in production in two shipping apps (Gitify and Atlassify) across macOS, Windows and Linux, we're hoping to transfer it to electron-userland (see #211), and once more production releases are behind it we plan to submit a Renovate replacement rule so existing users get the migration offered automatically.

Flagging it here for anyone who finds this PR looking for maintained dependencies.

@amaury1093

Copy link
Copy Markdown
Collaborator

Closing as fixed by #492 and published as 9.5.3

@amaury1093 amaury1093 closed this Jul 30, 2026
@setchy

setchy commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Closing as fixed by #492 and published as 9.5.3

Great to see the electron peer dependency be updated.

This PR was also addressing

  • updating all out of date dependencies, not just electron
  • fixing broken/stale type docs
  • linting

These are still open and unaddressed by #492 and v9.5.3... can be raised again in separate new PRs

@setchy

setchy commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

These are still open and unaddressed by #492 and v9.5.3... can be raised again in separate new PRs

raised separately as

@amaury1093

Copy link
Copy Markdown
Collaborator

Smaller targeted PRs are definitely easier for me to review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants