Skip to content

chore(deps): update to electron 43.x.x and drop the peer dependency ceiling #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amaury1093 merged 4 commits into from
Jul 29, 2026
Merged

chore(deps): update to electron 43.x.x and drop the peer dependency ceiling #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1f1f76
chore(deps): update to electron 35.x.x
sverdlov93 Oct 29, 2025
d305d88
chore(deps): update to electron 43.x.x and widen peer range
sverdlov93 Jul 29, 2026
20cc25e
ci: bump Node to 22 for Electron 43 engine requirement
sverdlov93 Jul 29, 2026
14cd805
ci: bump actions/checkout and setup-node to v7
sverdlov93 Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v7
- uses: actions/setup-node@v7
with:
node-version-file: '.nvmrc'
- run: yarn install
Expand Down
27 changes: 25 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,32 @@ jobs:
runs-on: macos-latest

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v7
- uses: actions/setup-node@v7
with:
node-version-file: '.nvmrc'
- run: yarn install
- run: yarn test

electron-compat:
name: Type-check against Electron ${{ matrix.electron }}
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
electron: [35, 37, 39, 41, 43]

# Electron's bundled type definitions are the only part of Electron the
# build touches, so the (large) prebuilt binary is not downloaded here.
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

steps:
- uses: actions/checkout@v7
- uses: actions/setup-node@v7
with:
node-version-file: '.nvmrc'
- run: yarn install
- run: yarn add --dev electron@^${{ matrix.electron }}.0.0
- run: yarn build
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
22
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ The `Menubar` class is an event emitter:

| menubar | Electron | Notes |
| -------- | -------------------------- | -------------------------------------------------------------------------------------------------------------------------- |
| 9.x.x | >= 9.x.x <= 34.x.x | |
| 9.x.x | >= 9.x.x | Continuously type-checked against Electron 35.x.x - 43.x.x in CI |
| 8.x.x | 8.x.xx | |
| 7.x.x | 7.x.xx | |
| 6.x.x | >= 4.x.x < 7.x.x | Not recommended for [security reasons](https://electronjs.org/docs/tutorial/security#17-use-a-current-version-of-electron) |
Expand Down
2 changes: 1 addition & 1 deletion examples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"private": true,
"workspaces": ["arrow", "hello-world", "icon-animation", "native-menu"],
"devDependencies": {
"electron": "^34.3.0"
"electron": "^43.0.0"
}
}
Loading