Writer should use code/iso8601 for date/time/datetime, not inspect - #63
Open
garysweaver wants to merge 1 commit into
Open
Writer should use code/iso8601 for date/time/datetime, not inspect#63garysweaver wants to merge 1 commit into
garysweaver wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #43 and #62, this converts Date, Time, DateTime (and ActiveSupport::TimeWithZone if exists) to code that creates a date using the iso8601 version of each time.
This could use some optimization. A much faster way is just to override inspect on Date, Time, DateTime (and ActiveSupport::TimeWithZone if exists) to return "(the class name).iso8601(#{iso8601.inspect})". However, this patch avoids inspect overrides, and it is doubtful most would want inspect overriden. It is ~3x slower than before. (4043 records took 8.1 sec vs. 2.4 sec and 79808 records took 83 sec vs. 30 sec).
Another option might be to use inspect but only temporarily override inspect on the affected classes (Date, Time, etc.), but I'm not absolutely sure that would work.