deps: update elixir to 1.20.2 - #3237
Conversation
- remove `require Logger` - fix redundant functions - replace `Tuple.append` with `Tuple.insert_at` - fix some type matching changes
- added matching in a few areas for compiler warnings - remove logger backends and include Sentry in application.ex - removed test that is now handled by a compiler warning
rwaskiewicz
left a comment
rwaskiewicz
left a comment
There was a problem hiding this comment.
LGTM - only non-blocking questions/comments
- fix mix.lock file - change logger: :console to :default_formatter
| end | ||
|
|
||
| # Both stop and route are not nil (route type ignored) | ||
| defp informed_entity_to_zone( |
There was a problem hiding this comment.
This seems like it might actually be the compiler unearthing a bug. On L130 the comment for the following clause says "only stop is not nil" (emphasis mine), meaning that the intent was that this clause was only entered if route is nil — however, it doesn't actually match on that. This discrepancy between the apparent intent and the actual implementation is what causes this clause to be unreachable.
There was a problem hiding this comment.
Good catch - I added route: nil to that particular function, added a not_is_nil(route) guard to the one on L144 and removed the one on L149 since it overlaps with this removed function. I re-added this function (with a not is_nil(route) guard) and also fixed tests (by just adding appropriate routes to the LocationContext)
I think this now covers all cases and matches them properly (everything nil, route_type is not nil, stop is not nil, route is not nil, stop and route are not nil).
- fixed `informed_entity_to_zone` function usages - fixed tests associated with those functions
3 participants
Asana task: Update Screens to Elixir 1.20 / OTP 29
Description
@robbie-sundstrom - looking at your previous code, I attempted to do the dependency upgrades but ran into an issue with clashing
hackneyversions fortimex->tzdataandex_aws. I think this is fixable by replacing our fewtimexcalls with something else, but after spending some time trying to replace it I decided that it would be best as a follow up task instead of in this PR.I'll create a ticket/add that code in after this.Ticket here.