-
Notifications
You must be signed in to change notification settings - Fork 23.2k
Update secure contexts guide #45518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+64
−22
Merged
Update secure contexts guide #45518
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bed2e42
Update secure contexts guide
wbamberg a24629a
Editorial
wbamberg 7dbe0d7
Update files/en-us/web/security/defenses/secure_contexts/index.md
wbamberg fcb57e4
Update files/en-us/web/security/defenses/secure_contexts/index.md
wbamberg 3f3d442
Nicer tables
wbamberg 89bb542
For framed documents, origin->URL
wbamberg 14a7fe1
Dedicated workers don't need trusted origin
wbamberg a02d0bb
Revert un-reification of trustworthy origins
wbamberg e6f6ec0
Add &worklets
wbamberg 401336e
Update summary
wbamberg 99c393b
Update files/en-us/web/security/defenses/secure_contexts/index.md
wbamberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a suggestion. We need the origin, but it isn't the important thing. It would be nice to do it something like his.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I see the reason you made this suggestion but I am -1 on it, for a couple of reasons.
First I like the gloss of trustworthy origin in lines 92-96, and moving it makes it inaccessible to people who come to the "Potentially trustworthy URLs" section (which as you say is most of them). I would be happy to de-bullet it though.
Second I think "The precise criteria are covered in the "origin" part of the previous section." is a bit awkward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough!