Repository navigation
Conversation
caugner
force-pushed
the
reusable-pr-check-workflow
branch
from
October 1, 2026 20:05
13f5b4c to
ac295ae
Compare
Use job names that describe the CLI help commands being exercised.
caugner
force-pushed
the
reusable-pr-check-workflow
branch
from
October 7, 2026 10:57
5f93861 to
9b39713
Compare
Dispatch reusable checks through a shared changed-file filter and move concurrency to the caller. Report `all-checks-passed-or-skipped` alongside the separate required `tests` check. Skip the aggregate on cancelled runs, so superseded runs do not schedule a job only to report the cancellation. Use consistent lowercase caller and reusable job names, and point Reviewdog at the aggregate workflow.
Start Reviewdog when PR checks begin and consume lint artifacts as soon as they appear, while other checks continue running. Poll every 15 s after a 30 s head start, since the lint job usually finishes within that window, and give up after 10 minutes with a warning rather than a failure: a slow runner queue is not a problem with the PR. Exclude stale artifacts from earlier attempts.
caugner
force-pushed
the
reusable-pr-check-workflow
branch
from
October 7, 2026 13:45
9b39713 to
753ac92
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update PR checks to run through one aggregate workflow that selects reusable checks by changed files and reports a single aggregate result. Centralize concurrency and standardize job names, including
filecheck-helpandbuild-helpfor the script CLI help checks.Motivation
Require all applicable checks through one aggregate result alongside the separate
testscheck, while allowing checks unrelated to the changed files to be skipped.Additional details
Aggregation removes the standalone lint workflow that triggers Reviewdog. Triggering Reviewdog on completion of the aggregate workflow would delay lint feedback until its longer checks finish. To preserve prompt feedback, Reviewdog starts with PR checks and waits for the lint artifact before posting suggestions.
Required check contexts on
mainbecometestsandall-checks-passed-or-skipped, without workflow-name prefixes.Check names in the PR UI change to
PR checks / <check> / <job>(e.g.PR checks / content / lint).Before merge
testsandall-checks-passed-or-skippedpass on this PR.check-redirectswithall-checks-passed-or-skippedinmainbranch protection, retainingtestsand GitHub Actions as the check source. Merge immediately afterward; this PR no longer reportscheck-redirects.After merge
mainif they do not report the aggregate check.Related issues and pull requests