test(#11246): harden Bikram Sambat test coverage

tests/e2e/default/reports/sidebar-filter.wdio-spec.js

@@ -230,20 +230,23 @@ describe('Reports Sidebar Filter', () => {
     expect(await picker.isDisplayed()).to.be.false;
 
     // 4. Select From and To dates
-    await reportsPage.setSidebarFilterBikFromDate();
-    await reportsPage.setSidebarFilterBikToDate();
+    const fromDayText = await reportsPage.setSidebarFilterBikFromDate();
+    const toDayText = await reportsPage.setSidebarFilterBikToDate();
 
-    // Verify both From and To input fields have selected date values
-    expect(await reportsPage.getFromDateValue()).to.not.equal('');
-    expect(await reportsPage.getToDateValue()).to.not.equal('');
+    // Verify both From and To input fields have selected date values and match selection (B9)
+    const fromDateLabel = await reportsPage.getFromDateValue();
+    const toDateLabel = await reportsPage.getToDateValue();
+    expect(fromDateLabel.split(' ')[0]).to.equal(fromDayText);
+    expect(toDateLabel.split(' ')[0]).to.equal(toDayText);
 
     // Dismiss the open picker so we can test reopening it
     await browser.keys(['Escape']);
 
-    // 5. Reopen active selection verification
+    // 5. Reopen active selection verification (B4)
     await reportsPage.clickSidebarFilterToDate();
-    // Verify that the active selected date is highlighted correctly
+    // Verify that the active selected date is highlighted correctly and has the correct day text
     expect(await reportsPage.isNepaliDatePickerActiveCellDisplayed()).to.be.true;
+    expect(await reportsPage.getNepaliDatePickerActiveCellText()).to.equal(toDayText);
 
     // Dismiss it
     await browser.keys(['Escape']);
@@ -254,6 +257,19 @@ describe('Reports Sidebar Filter', () => {
     expect(await reportsPage.leftPanelSelectors.reportByUUID(pregnancyDistrictHospital._id).isDisplayed()).to.be.true;
     expect(await reportsPage.leftPanelSelectors.reportByUUID(visitDistrictHospital._id).isDisplayed()).to.be.true;
 
+    // 6. Clear Nepali date filter leg (B11)
+    const clearDateFilterChip = await reportsPage.sidebarFilterSelectors.clearDateFilterBtn();
+    await clearDateFilterChip.waitForDisplayed();
+    await clearDateFilterChip.click();
+
+    await commonPage.waitForPageLoaded();
+
+    // Verify labels are reset, the filter chip is gone, and the report list goes back to original length
+    expect(await reportsPage.getFromDateValue()).to.equal('बाट');
+    expect(await reportsPage.getToDateValue()).to.equal('सम्म');
+    expect(await reportsPage.sidebarFilterSelectors.dateFilterChip().isExisting()).to.be.false;
+    expect(await reportsPage.leftPanelSelectors.allReports().length).to.equal(reports.length);
+
     await browser.setCookies({ name: 'locale', value: 'en' });
     await browser.refresh();
   });

tests/integration/cht-form/default/bikram-sambat-widget.wdio-spec.js

@@ -1,3 +1,4 @@
+/* global window */
 const mockConfig = require('../mock-config');
 
 describe('cht-form web component - Bikram Sambat Widget', () => {
@@ -167,4 +168,39 @@ describe('cht-form web component - Bikram Sambat Widget', () => {
     const closeBtn = await picker.$('.close-btn');
     await closeBtn.click();
   });
+
+  it('asserts that a pre-existing date widget is removed', async () => {
+    const widgets = await $$('.bikram-sambat-widget');
+    for (const widget of widgets) {
+      const parent = await widget.parentElement();
+      const standardDateWidget = await parent.$('.widget.date');
+      expect(await standardDateWidget.isExisting()).to.be.false;
+    }
+  });
+
+  it('asserts that the picker renders completely within the viewport', async () => {
+    const widgets = await $$('.bikram-sambat-widget');
+    const firstWidget = widgets[0];
+    const calBtn = await firstWidget.$('.calendar-btn');
+    await calBtn.click();
+
+    const picker = await $('.nepali-date-picker');
+    expect(await picker.isDisplayed()).to.be.true;
+
+    const viewportSize = await browser.execute(() => ({
+      width: window.innerWidth,
+      height: window.innerHeight,
+    }));
+    const location = await picker.getLocation();
+    const size = await picker.getSize();
+
+    expect(location.x).to.be.at.least(0);
+    expect(location.y).to.be.at.least(0);
+    expect(location.x + size.width).to.be.at.most(viewportSize.width);
+    expect(location.y + size.height).to.be.at.most(viewportSize.height);
+
+    // Close picker
+    const closeBtn = await picker.$('.close-btn');
+    await closeBtn.click();
+  });
 });

tests/page-objects/default/reports/reports.wdio.page.js

@@ -67,6 +67,8 @@ const sidebarFilterSelectors = {
   dateAccordionBody: () => $('#date-filter-accordion mat-panel-description'),
   toDate: () => $('#toDateFilter'),
   fromDate: () => $('#fromDateFilter'),
+  dateFilterChip: () => $('#date-filter-accordion mat-expansion-panel-header .chip'),
+  clearDateFilterBtn: () => $('#date-filter-accordion mat-expansion-panel-header .chip .fa-times'),
   formAccordionHeader: () => $('#form-filter-accordion mat-expansion-panel-header'),
   formAccordionBody: () => $('#form-filter-accordion mat-panel-description'),
   facilityAccordionHeader: () => $('#place-filter-accordion mat-expansion-panel-header'),
@@ -358,13 +360,19 @@ const setSidebarFilterBikDate = async (fieldPromise, prevClicks, cellIndex) => {
   const cells = await picker.$$('table tbody td.current-month-date:not(.disable)');
   if (cellIndex === 'last') {
     if (cells.length > 0) {
-      await cells[cells.length - 1].click();
+      const cell = cells[cells.length - 1];
+      const text = (await cell.getText()).trim();
+      await cell.click();
+      return text;
     } else {
       throw new Error('No enabled cells found in the Nepali date picker');
     }
   } else {
     if (cells.length > cellIndex) {
-      await cells[cellIndex].click();
+      const cell = cells[cellIndex];
+      const text = (await cell.getText()).trim();
+      await cell.click();
+      return text;
     } else {
       throw new Error(`Requested cell index ${cellIndex} is not available. Only ${cells.length} cells are enabled.`);
     }
@@ -634,4 +642,5 @@ module.exports = {
   verifyReport,
   openFirstReport,
   waitForReportsLoaded,
+  sidebarFilterSelectors,
 };

webapp/tests/karma/ts/services/format-date.service.spec.ts

@@ -503,24 +503,29 @@ describe('FormatDate service', () => {
     });
 
     it('correctly handles conversion across timezones and negative offsets', () => {
-      const dateInUTC = moment.utc('2024-06-29T05:00:00Z');
-      const localDate = dateInUTC.local();
-
-      const localDay = localDate.date();
-      const expectedText = localDay === 29 ? '१५ असार २०८१' : '१४ असार २०८१';
-      expect(service.date(localDate)).to.equal(expectedText);
+      // Stub moment.fn.local to return a moment with a fixed -360 (GMT-6) offset
+      // to ensure a negative offset shift is exercised deterministically
+      const localStub = sinon.stub(moment.fn, 'local').callsFake(function(this: any) {
+        return this.utcOffset(-360);
+      });
+      try {
+        const dateInUTC = moment.utc('2024-06-29T05:00:00Z');
+        expect(service.date(dateInUTC.local())).to.equal('१४ असार २०८१');
+      } finally {
+        localStub.restore();
+      }
     });
 
-    it('correctly handles conversion across Daylight Saving Time (DST) boundaries', () => {
-      const beforeDST = moment('2024-03-10T01:59:59'); // Standard Time
-      const afterDST = moment('2024-03-10T03:00:00'); // DST (02:00:00 doesn't exist)
-
-      expect(service.date(beforeDST)).to.equal('२७ फाल्गुन २०८०');
-      expect(service.date(afterDST)).to.equal('२७ फाल्गुन २०८०');
-    });
+    it('toGreg_text reverse conversion round-trips correctly at month/year boundaries', () => {
+      const bsYear = 2080;
+      const bsMonth = 12;
+      const bsDate = 30;
+
+      // Convert BS to Gregorian string: 2080 Chaitra 30 -> 2024-04-12
+      const gregStr = BikramSambat.toGreg_text(bsYear, bsMonth, bsDate);
+      expect(gregStr).to.equal('2024-04-12');
 
-    it('toGreg_text reverse conversion round-trips correctly at month/year boundaries via the service', () => {
-      const gregStr = '2024-04-12';
+      // Convert back to BS using the service and check it matches original values
       const formatted = service.date(moment(gregStr));
       expect(formatted).to.equal('३० चैत २०८०');
     });