Provide nlohmann/json dependency with multiple headers#1678
Conversation
|
IIRC nlohmann_json is never installed this way and the dependency lookup won't ever work for the general case. Not sure this is a good idea... |
|
What do you mean "this way"? Via wrapdb? I don't follow. I just tested it:
|
|
Me either. I'm looking, and I would rather see if upstream would take an update to their Meson. I'm opening a PR right now for that purpose. (I use this project downstream, so I have some interest in making this better) |
|
OK I see my mistake now. For whatever reason I thought json_fwd.hpp is only available with multiple headers, I completely missed that json_fwd.hpp is in single_include as well. Yes, this is pointless. At least it prompted update upstream. :) |
|
The other factor here is that the usual name is Implementing a new dependency name would mean it only worked as a wrap, but not as a system package, which is a naming wart and probably a leaky internal implementation detail. And implementation details could probably be used by projects that really want them, via It would generally only matter for projects that don't care about the forward declarations, but rather want to overly specify whether they use amalgamated headers. |
meson.build of nlohmann/json contains additional dependency with multiple headers, instead of single one. This PR allows wrapDB users to use it.
Multiple headers are useful eg. if you want to forward-declare nlohmann::json object (see
json_fwd.hpp).