Repository navigation
fix(gestures): a deadline runs after the input stamped before it #11837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vjeux
wants to merge
13
commits into
meta:main
Choose a base branch
from
vjeux:uikit/arena-late-input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+398
−14
Draft
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e7c75e4
test(gestures): a late deadline waits for input queued behind a block
vjeux b547611
fix(gestures): a late deadline waits for input queued behind a block
vjeux a458377
test(gestures): a deadline among a coalesced move's samples
vjeux 6e45960
fix(gestures): a deadline among a coalesced move's samples runs between
vjeux 1f848c9
test(gestures): a deadline due during a late wait runs as it ends
vjeux cf6fa67
fix(gestures): a deadline due during a late wait runs as it ends
vjeux a14908d
docs(gestures): the late wait's comment and changeset in short sentences
vjeux 88132ea
docs(specs): FR16 states the late wait's cost for every recognizer
vjeux 640bbfa
test(gestures): a mouse keeps the late yield; a late wait ends once
vjeux b7e19e3
fix(gestures): only a finger or pen waits; a late wait ends once
vjeux b411003
docs(gestures): the arena header's late-wait sentence in two
vjeux 3503b02
docs(gestures): FR16 states the gate once; comments say why
vjeux ec2e905
Merge main 64806d0bd2 into the arena fix
vjeux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [fix] A touch gesture's deadline now runs after the input stamped before it. Behind a blocked page, a finger's or pen's deadline whose timer runs more than 17 ms late waits 50 ms for input still queued. Each input from before it that comes late keeps it waiting. A mouse's or trackpad's deadline does not wait. A deadline that falls among a coalesced move's samples runs between them. A List reorder hold or a Pager's catch whose finger drifted or lifted in time now ends as it should. | ||
|
|
||
| @vjeux | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss: "A mouse's or trackpad's deadline does not wait" is not what the arena does, and neither is "a finger's or pen's deadline … waits 50 ms": the gate is the latest contact (
isLatestContactFingerOrPen, written inbegan()anduntrackedBegan()and read in the timer's gate), which is also what the amended FR16 says. Probed on this head: a long press begun with a mouse waits the 50 ms once a finger lands elsewhere, and a long press begun with a finger keeps the single-task yield once a mouse press lands, so its drift stamped before the deadline still misses it. Suggested wording: "While the latest contact is a finger or a pen, a deadline whose timer runs more than 17 ms late waits 50 ms for input still queued; with a mouse or trackpad as the latest contact, deadlines keep today's single-task yield."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description now states the record's gate. Its unchanged-path line reads:
The release note changes in this pull request's next push, which merges main once #11450 lands. That commit is ready, and its note uses FR16's words:
It adds: "With a mouse or trackpad as the latest contact, deadlines keep today's single-task yield."