Repository navigation
Conversation
…focus for a field
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
|
/approve-spec f2ad133 |
PR Analysis Report
Generated by PR Enrichment workflow | View current CI run |
There was a problem hiding this comment.
Changes requested: the new WebKit clause needs a Safari result or narrower wording before this can be approved.
- The release note and the new
BottomSheet.doc.mjstext say a sheet with nodata-autofocusfield lands on the panel in WebKit (Safari, iOS Safari included), modal or not, but the pull request shows no Safari result andBottomSheetReplace.test.tsx:1511-1512models a lone non-modal Safari sheet taking no focus, so please state in the description where focus landed in desktop and iOS Safari for a modal and a non-modal sheet without a field, or narrow the clause to what you reproduced.
The data-autofocus instruction matches the component's accessibility contract, and the public API is unchanged.
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim: the docs named only Chromium and Firefox before this change. Verified against the base doc text.
- Claim: WebKit and iOS Safari land on the panel with no field, modal or not. Not shown (the blocking finding above).
- Claim: marking a field
data-autofocusopens on it in every browser. Verified against the accessibility contract and the cross-browser autofocus test. - Claim: the change is docs only, with no behavior, prop or record change. Verified: two files, and the built API surface is identical. The doc edit rewrites one sentence and adds a second.
- Claim: the listed overlapping pull requests do not touch the open-focus sentence. Verified: none edits the description line.
- Claim: the changeset, knowledge and sync checks pass, Prettier is clean and the doc module loads. Verified by rerunning them on this head.
- File
.changeset/bottomsheet-doc-webkit-initial-focus.md: the blocking finding above (its WebKit claim); the format is valid. - File
packages/core/src/BottomSheet/BottomSheet.doc.mjs: the blocking finding above; consistent with the release note.
|
/approve-spec 496b4b3 |
There was a problem hiding this comment.
Approved pending CI: CI has not run on this head yet.
The doc and the release note now name only the case the description measured, a modal sheet in Safari on iOS landing on its panel, and the public API is unchanged.
Claims and files checked
Review mode: incremental; reason: none
- Claim: before this change the docs named only Chromium (the panel) and Firefox (the first focusable control). Verified against the base doc text.
- Claim: in Safari on iOS a modal sheet with no
data-autofocusfield lands on its panel. Verified as stated in the description's iOS simulator run, and consistent with the sheet's open-focus code, which focuses a modal sheet's panel when the native steps leave focus outside it. - Claim: the docs now name that landing and say to mark a field
data-autofocusto open on it in every browser. Verified inBottomSheet.doc.mjs:175; thedata-autofocusrule matches the component's accessibility contract and its cross-browser autofocus test. - Claim: docs only, with no behavior, prop or record change, and the doc ships with the package. Verified: two files, identical built API surfaces, and the package publishes
src; the doc edit rewrites one clause and adds one sentence. - Claim: desktop Safari and a non-modal Safari sheet are not claimed. Verified: the doc and the release note name only the modal sheet on iOS.
- Claim: the listed overlapping pull requests change other lines of the doc file and none touches the open-focus sentence. Verified: none edits the description line.
- Claim: the changeset, knowledge and sync checks pass, Prettier is clean and the doc module loads. Verified by rerunning them on this head.
- Changeset entry: a docs patch for core describing the modal-sheet-on-iOS landing and the
data-autofocusinstruction. Verified against the doc text; the changeset check accepts it. - File
.changeset/bottomsheet-doc-webkit-initial-focus.md: clear. - File
packages/core/src/BottomSheet/BottomSheet.doc.mjs: clear, consistent with the release note.
|
/approve-spec 157ef71 |
There was a problem hiding this comment.
Approved: CI passed on this head.
The doc and the release note name only the case the description measured, a modal sheet in Safari on iOS landing on its panel, and the public API is unchanged.
Claims and files checked
Review mode: same-head; reason: none
- Claim: before this change the docs named only Chromium (the panel) and Firefox (the first focusable control) for where focus lands on open. Verified against the base doc text.
- Claim: in Safari on iOS a modal sheet with no
data-autofocusfield lands on its panel. Verified as stated in the description's iOS simulator run, and consistent with the sheet's open-focus code, which keeps the native landing inside a modal sheet and focuses its panel only when focus is outside it. - Claim: the docs now name that landing and say to mark a field
data-autofocus(a TextInput withhasAutoFocus) to open on it in every browser. Verified inBottomSheet.doc.mjs:178; the rule matches the component's accessibility contract, its cross-browser autofocus test, and TextInput, which marks the field whenhasAutoFocusis set. - Claim: docs only, with no behavior, prop or record change, and the doc ships with the package. Verified: two files, identical built API surfaces, no record touched, and the package publishes
src. - Claim: desktop Safari and a non-modal Safari sheet are not claimed, and the non-modal unit test does not contradict the sentence. Verified: the doc and the release note name only the modal sheet on iOS, and the test models a lone non-modal sheet taking no focus.
- Claim: none of the listed overlapping pull requests touches the open-focus sentence. Verified live: none changes it; four no longer change the doc file, three change only the
heightprop description, and one has merged with a theming-target change only. - Claim: the changeset, knowledge and sync checks pass, Prettier is clean and the doc module loads. Verified by rerunning them on this head.
- Changeset entry: a docs patch for core describing the modal-sheet-on-iOS landing and the
data-autofocusinstruction. Verified against the doc text; the changeset check accepts it. - File
.changeset/bottomsheet-doc-webkit-initial-focus.md: clear. - File
packages/core/src/BottomSheet/BottomSheet.doc.mjs: clear, consistent with the release note.
|
/approve-spec 72653a5 |
User impact
A builder reads BottomSheet's docs to learn where focus lands when a sheet opens with no
data-autofocusfield. The docs named Chromium (the panel) and Firefox (the first focusable control) and said nothing about Safari. In Safari on iOS a modal sheet lands on its panel, as in Chromium, so a builder who expected the first control there got the panel. The docs now name that landing and say to mark the fielddata-autofocus(a TextInput withhasAutoFocus) to open on it in every browser (component:BottomSheetAR4).Docs only: one sentence in
BottomSheet.doc.mjsand a[docs]Changeset, since the doc ships with the package. No behavior, prop or record changes.Evidence
<button>and has nodata-autofocusfield opens; once the rise settles,document.activeElementis the sheet's panel (thetabindex="-1"container inside the<dialog>), not the button.hasScrim={false}) sheet in Safari. The sentence names only the modal sheet on iOS.BottomSheetReplace.test.tsxmodels a lone non-modal Safari sheet taking no focus on open, which the sentence does not contradict.Overlap checked: #12216, #12179, #12081, #12044, #11859, #10462, #8217, #8080 (they change other lines of
BottomSheet.doc.mjs; none touches the open-focus sentence)Test plan
check:changesets,check:knowledgeandcheck:syncpass.