Repository navigation
experimental theme: states Core marks, open parts drawn open, and picture inputs and flyouts #12498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: theme-r15-p01
Are you sure you want to change the base?
Changes from all commits
3d20b5d
9d44445
cd3a9fb
fef7b50
bc13d48
6803f4f
fc89962
f245fb3
48c7dc2
d3ede62
9283091
1b3bb72
97b65a1
55297c3
2786aa9
80025af
98f8b57
e00e7f9
164e6da
618c68b
35974df
f16f7e8
a7998c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/cli': patch | ||
| --- | ||
|
|
||
| [experimental] `astryx experimental theme editor`: a part drawn on another part's element keeps its states to itself. A Button that a pagination cell is drawn on no longer takes the cell's `selected` state, so the button family reads the Button again and a selected look on a list row no longer reaches every Button; a part that always rides another (a list item on its Item) still takes that one's states. | ||
|
|
||
| @josephfarina | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --- | ||
| '@astryxdesign/cli': patch | ||
| --- | ||
|
|
||
| [experimental] `astryx experimental theme editor`: a border asked of a part that draws none goes to the pieces inside it only where those pieces draw borders of their own (a date and time field's two boxes), so "top nav with a 1px bottom border" writes the border on the top nav, not under each nav item, and "sidebar with a 1px right border" on the sidebar, not beside each link. | ||
|
|
||
| - `astryx experimental theme editor` keeps what a change reports to what it did: a border set for light alone no longer reports the dark frame it left as the theme draws it. | ||
|
|
||
| - `astryx experimental theme editor how`: "the active nav item should be a #e8def8 pill" again gives pill corners on the selected item only. There is now a single reader for a color and shape, so the item's state is kept. | ||
|
|
||
| - `astryx experimental theme editor how` now gives a text color for every variant of a part whose variants each take a color of their own ("buttons with white text", "badges with dark text") to each variant only in the modes where it reads; text a part's variants read from shared tokens (a card's) is not measured this way unless the same answer gives them a fill. It measures against the variant's own fill, see-through fills over the page, or the fill the same answer gives it. Variants it can't read on keep their own text, and the answer says which. | ||
|
|
||
| Other fixes: | ||
|
|
||
| - "tinted <color>" fills with the color at a low strength over what's beneath, not the solid color. A text color asked with the tint, on any part it fills (a button variant, a card, a selected nav item), deepens the tint along its own hue until that text reads (to 95% for white on blue); only when no strength of that hue reads is the text kept to the modes it reads in, with a readable ink named. | ||
| - A rule with its own verb said after a part's clause ("3px corners on cards, never use pure black for text") now applies to the whole theme. | ||
|
|
||
| - `astryx experimental theme editor set … --only` always works as an escape from a group: on a member of a group that spreads it keeps the change to that member, and on a part that is styled on its own already (a sub-part, a card) it is taken and said, in place of a refusal; only a group itself, which has no one member to keep to, refuses it. A menu's radio is kept apart from every other radio: "square corners but keep menu radios round" says its circle is left as it is, and a round ask on a menu radio the theme squared offers the undo that gives the circle back. | ||
|
|
||
| - `astryx experimental theme editor`: a part Core marks open is drawn open, so `--state expanded` reaches a dropdown menu's submenu row (open while its flyout is, though it is highlighted too) and a top nav's menu trigger (a control on the page, now kept as drawn open). | ||
|
|
||
| - `astryx experimental theme editor`: the states Core marks on a part's own element are the part's to set. A list item (and so a checkbox list's row) takes `--state selected`, written as the attribute Core marks; a checkbox's or radio's box takes `--state hover` and the other moment states, shown from the part holding its invisible input instead of refused; a state asked of a container names the part inside it that has it, so `--on pagination --state selected` points to the selected page's item (`--on pagination-item --state selected`); and a part the drawing shows open in an overlay records its open state for `--state expanded`. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| - `astryx experimental theme editor show` draws a doc sample's plain HTML text field as the theme's own text input, a submenu's flyout once beside the menu it opens from instead of a second time below it, a control drawn pressed at the moment of its press (a press flash no longer fades back to rest), a command palette with an item highlighted on the open states page, and the mobile navigation drawer's panel inside its cell. | ||
|
|
||
| - The pictures of `astryx experimental theme editor show --png` show their whole page: a page laid out wider than the picture window is pictured to its own width instead of cut at the window's edge; the mobile navigation drawer, which draws nothing closed, has no empty cell on the navigation pictures either; an overlay drawn open after its part (a toolbar's menu) sits under the control that opens it; and a step name cut by less than a pixel is shown whole too. | ||
|
|
||
| - `astryx experimental theme editor how`: rows said of a part that holds no table rows are that part's own rows, the items it draws, so "menus with 32px rows" sizes the menu items and never every table row; and a part word right before a noun the editor knows as nothing ("a radio station", "a button factory", "a card game") begins a compound subject, never the part: it is named and nothing is written for it, and the rest of the ask is read as before. | ||
|
|
||
| - `astryx experimental theme editor` measures a state's fill against the text that state draws, in its own variant: a part that draws no text (a switch's track, a tab's underline) gets no text problem, and a primary button's hover fill is measured against the primary button's own text, not another variant's. A page change that leaves the loading placeholder as faint as the base drew it no longer reports it as a new problem. | ||
|
|
||
| - In a light-only or dark-only theme, a text color set on a part whose own background is an image (a gradient button face) is written for both modes. Inside a lightbox or overlay, which Core draws in the other scheme, the text stays on that face: it no longer turns white on a light gel button. The contrast check measures it the same way. | ||
|
|
||
| @josephfarina | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note describes a fix for a problem no release had. Census states arrive in this same pull request (
addCensusStatesin_parts.mjs), and on the base a Button has noselectedstate,how "button match the theme"offers nothing for it, and a list item takes noselectedat all. People reading the CLI changelog would look for a Button problem they never had. Delete this note, or add one clause to the round note's census line, for example "a state Core marks for one part (a pagination cell'sselected) stays on that part".