Repository navigation
Conversation
- Add sidebar navigation layout with page links - Add example pages (buttons, form) demonstrating XDS components - Configure static export for GitHub Pages deployment - Update generate-pr-comment.js to accept --sandbox-url parameter - Update README with page creation guide and directory structure Note: CI workflow changes (.github/workflows/storybook.yml) need to be applied separately as they require workflow scope permissions. Closes #126 Co-authored-by: Navi <navi@multimango.com>
Contributor
PR Analysis Report📚 Storybook PreviewNo new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: 43 accessibility violation(s) found. XDSAspectRatio - 1 issue(s)
XDSAvatar - 1 issue(s)
XDSBadge - 1 issue(s)
XDSButton - 1 issue(s)
XDSCalendar - 1 issue(s)
XDSCard - 2 issue(s)
XDSCenter - 1 issue(s)
XDSCheckboxInput - 1 issue(s)
XDSCloseButton - 1 issue(s)
XDSDateInput - 1 issue(s)
XDSDialog - 1 issue(s)
XDSDivider - 1 issue(s)
XDSDropdownMenu - 1 issue(s)
XDSField - 1 issue(s)
XDSFontWrapper - 1 issue(s)
XDSGrid - 1 issue(s)
XDSHStack - 1 issue(s)
XDSHeading - 1 issue(s)
XDSHoverCard - 1 issue(s)
XDSIcon - 1 issue(s)
XDSLayout - 2 issue(s)
XDSLink - 1 issue(s)
XDSNumberInput - 1 issue(s)
XDSRadioList - 1 issue(s)
XDSSection - 2 issue(s)
XDSSelector - 1 issue(s)
XDSSkeleton - 1 issue(s)
XDSSlider - 1 issue(s)
XDSStackItem - 1 issue(s)
XDSSwitch - 1 issue(s)
XDSTabList - 1 issue(s)
XDSTable - 1 issue(s)
XDSText - 2 issue(s)
XDSTextArea - 1 issue(s)
XDSTextInput - 1 issue(s)
XDSTimeInput - 1 issue(s)
XDSTooltip - 1 issue(s)
XDSTopNav - 1 issue(s)
XDSVStack - 1 issue(s)
Generated by PR Enrichment workflow | Storybook | View full report |
Contributor
Author
|
I'm making updates to the examples so will revisit this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up the sandbox app for designer vibe exploration per #126.
Changes
Sidebar.tsxcomponent with page links, integrated into the root layoutnext.config.mjswithoutput: 'export',basePathenv var, andimages: {unoptimized: true}for GitHub Pagesgenerate-pr-comment.jsto accept--sandbox-urland render a sandbox preview sectionpagesrule to only ignore root/pages(Pages Router), notsrc/app/pages/(App Router)CI Workflow Changes (needs manual apply)
The workflow file (
.github/workflows/storybook.yml) couldn't be pushed due to OAuth token scope limitations. The changes need to be applied manually or with a token that hasworkflowscope. The diff adds:SANDBOX_BASE_PATHenv var)deploy/${SHORT_HASH}/sandbox/sandbox_urloutput passed to PR enrichmentWorkflow diff
Key additions to the
deployjob:And in deployment:
PR enrichment detects changed sandbox pages:
How to add a new page
apps/sandbox/src/app/pages/<name>/page.tsx:pagesarray insrc/app/Sidebar.tsxThe page appears in the sidebar and gets a unique URL in the PR deployment.
Closes #126
Crafted with care by Navi