Repository navigation
feat(theme): chat surfaces default to the container radius - #12794
Conversation
--radius-chat now defaults to var(--radius-container) instead of 28px. A theme that sets --radius-container but not --radius-chat declares the alias at its root, the way --duration-exit follows --duration-fast, so a nested theme follows its own container. The radius scale gives chat the container step. Butter, Chocolate, Gothic, Matcha, Neutral and Stone set --radius-chat to 28px, and so does the probe fixture, so they look the same. Y2K stays at 0px. The CLI theme copies, the token docs and the native default theme are regenerated.
A radius scale set --radius-chat to its container step as a fixed value, so a theme that set --radius-container over its scale got chat corners that did not match its containers. The scale no longer sets the chat radius: the theme root declares --radius-chat: var(--radius-container), as it does for a theme that sets the container itself.
With chat corners at the container radius, the composer's concentric button radius gave the send button an 8px corner on its 32px box. The send button now declares --_button-radius itself, so it stays circular inside a composer as it is outside one; a theme that sets the button or send-button radius still wins. Butter keeps the 16px corner its 40px send button had, and the docs site keeps its 28px chat corners. Also: comment and Chinese description follow-ups, and the refreshed comment-provenance baseline.
Butter's button comment said the composer rounds its buttons fully; the changeset names both themes whose send button becomes a circle.
Y2K's square chat corners came from its multiplier-0 radius scale. A theme that extends Y2K and sets its own container radius would now follow that container, so Y2K sets --radius-chat: 0px, as the other Astryx themes set 28px.
--radius-chat now defaults to the container radius. The codemod adds --radius-chat to the tokens of each defineTheme that sets neither the token nor extends: 28px, or the page step of a literal radius scale. A theme that extends another theme inherits its value and is left alone. Where it cannot read the theme, it leaves a TODO comment.
…themes and default exports Review follow-ups: an adaptation rule with a radius scale gets its own page step, completed from the theme's scale; a theme with an adaptation rule that changes its radius, or a spread after its container radius, keeps its token; an extending theme with its own scale keeps that scale's page step; a non-literal config and an unreadable adaptation get a TODO; a TODO for a radius scale names the page step; a top-level spread followed by the token needs no TODO; a default-exported theme object is migrated. Fixtures are built with Core and their chat radius compared, at the root and under each adaptation rule, with the value before the default change.
…eports plain objects Review follow-ups: a theme whose container radius equals its old chat radius now gets the token too, so a theme that extends it and sets its own container keeps it. A default-exported object shaped like a theme is not proven to be one: the file stays unchanged and is reported for manual migration with the value to add.
…us TODO Review follow-ups: a spread can bring a radius scale or adaptation rules, so a theme with one always gets the TODO, which now names the adaptation rules' tokens too. The manual-migration report for a default export also names what the file's defineTheme() themes need, since nothing in the file is written. The description no longer counts the send button among the buttons that follow the composer corner.
…t migrate Review follow-ups: an extending theme keeps its base's chat radius only when the base is an Astryx theme or a theme this project defines (a relative or aliased import, a defineTheme() binding in the file, or an inline defineTheme()), which this upgrade migrates. A base from another package, or a value the codemod cannot resolve, gets a TODO. An extending theme with its own radius scale also gets a TODO for its base's adaptation rules, which that scale completes, unless the base is an Astryx theme.
…tation rules Review follow-ups (non-blocking): the TODO for a theme that extends a theme this upgrade does not migrate also asks for the base's adaptation rules, and a theme that already sets the token still gets that part. The header, description and changeset say that a relative or aliased import is trusted to be a theme this project defines.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Analysis Report🔎 Preview ·
|
| Component | Size | LoC | Visual · A11y · RTL |
|---|---|---|---|
| ChatSendButton | 66.8 kB (+16 B) · 10.8 kB CSS (+21 B) | — | — · — · — |
| Toast | 105.6 kB (+24 B) · 11.1 kB CSS (+7 B) | — | — · — · — |
| lab/Comments | 379.4 kB (+31 B) · 2.5 kB CSS (0) | — | — · — · — |
204 more components
| Component | Size | LoC | Visual · A11y · RTL |
|---|---|---|---|
| ChatComposer | 86.0 kB (+12 B) · 12.9 kB CSS (+16 B) | — | — · — · — |
| Lightbox | 149.7 kB (+22 B) · 12.0 kB CSS (+5 B) | — | — · — · — |
| Markdown | 205.3 kB (+24 B) · 22.1 kB CSS (+2 B) | — | — · — · — |
| lab/DialogHeroHeader | 90.4 kB (+25 B) · 372 B CSS (0) | — | — · — · — |
| lab/ListInput | 95.4 kB (+23 B) · 922 B CSS (0) | — | — · — · — |
| lab/CommentThread | 372.3 kB (+22 B) · 2.4 kB CSS (0) | — | — · — · — |
| charts/Chart | 242.0 kB (+19 B) · 516 B CSS (0) | — | — · — · — |
| lab/CommentComposer | 180.6 kB (+15 B) · 1.9 kB CSS (0) | — | — · — · — |
| Overlay | 23.5 kB (+6 B) · 3.9 kB CSS (+4 B) | — | — · — · — |
| ComplexSelector | 78.9 kB (0) · 12.7 kB CSS (+9 B) | — | — · — · — |
| SegmentedControl | 102.5 kB (0) · 7.0 kB CSS (+8 B) | — | — · — · — |
| Badge | 4.4 kB (0) · 4.0 kB CSS (+7 B) | — | — · — · — |
| ChatMessageBubble | 7.6 kB (0) · 3.7 kB CSS (+7 B) | — | — · — · — |
| ChatTokenizedText | 7.6 kB (0) · 4.0 kB CSS (+7 B) | — | — · — · — |
| Code | 3.7 kB (0) · 3.5 kB CSS (+7 B) | — | — · — · — |
| CodeBlock | 81.9 kB (0) · 12.2 kB CSS (+7 B) | — | — · — · — |
| DateInput | 203.3 kB (0) · 18.0 kB CSS (+7 B) | — | — · — · — |
| DateRangeInput | 101.0 kB (0) · 13.3 kB CSS (+7 B) | — | — · — · — |
| MobileNav | 77.6 kB (0) · 11.4 kB CSS (+7 B) | — | — · — · — |
| SideNavCollapseButton | 67.2 kB (0) · 10.9 kB CSS (+7 B) | — | — · — · — |
| Stepper | 68.0 kB (0) · 10.9 kB CSS (+7 B) | — | — · — · — |
| ToggleButton | 93.6 kB (0) · 10.9 kB CSS (+7 B) | — | — · — · — |
| Typeahead | 89.3 kB (0) · 13.5 kB CSS (+7 B) | — | — · — · — |
| Avatar | 46.2 kB (0) · 5.7 kB CSS (+6 B) | — | — · — · — |
| AvatarGroup | 49.0 kB (0) · 5.8 kB CSS (+6 B) | — | — · — · — |
| AvatarGroupOverflow | 52.3 kB (0) · 5.8 kB CSS (+6 B) | — | — · — · — |
| Button | 66.4 kB (0) · 10.8 kB CSS (+6 B) | — | — · — · — |
| Card | 10.1 kB (0) · 6.7 kB CSS (+6 B) | — | — · — · — |
| ChatComposerDrawer | 18.4 kB (0) · 4.7 kB CSS (+6 B) | — | — · — · — |
| ContextMenuItem | 35.9 kB (0) · 7.1 kB CSS (+6 B) | — | — · — · — |
| DateTimeInput | 226.8 kB (0) · 19.8 kB CSS (+6 B) | — | — · — · — |
| DropdownMenuCheckboxItem | 28.8 kB (0) · 7.3 kB CSS (+6 B) | — | — · — · — |
| DropdownMenuItem | 28.0 kB (0) · 6.9 kB CSS (+6 B) | — | — · — · — |
| DropdownMenuRadioItem | 28.8 kB (0) · 7.3 kB CSS (+6 B) | — | — · — · — |
| FileInput | 75.4 kB (0) · 11.8 kB CSS (+6 B) | — | — · — · — |
| IconButton | 66.4 kB (0) · 10.8 kB CSS (+6 B) | — | — · — · — |
| InputGroupText | 6.9 kB (0) · 3.9 kB CSS (+6 B) | — | — · — · — |
| Link | 56.8 kB (0) · 7.1 kB CSS (+6 B) | — | — · — · — |
| MobileNavToggle | 66.7 kB (0) · 10.8 kB CSS (+6 B) | — | — · — · — |
| MultiSelector | 103.4 kB (0) · 17.8 kB CSS (+6 B) | — | — · — · — |
| NumberInput | 104.2 kB (0) · 12.2 kB CSS (+6 B) | — | — · — · — |
| ResizeHandle | 22.3 kB (0) · 4.3 kB CSS (+6 B) | — | — · — · — |
| Tab | 15.0 kB (0) · 4.3 kB CSS (+6 B) | — | — · — · — |
| TableCell | 104.7 kB (0) · 19.3 kB CSS (+6 B) | — | — · — · — |
| TextArea | 92.8 kB (0) · 9.4 kB CSS (+6 B) | — | — · — · — |
| TextInput | 99.1 kB (0) · 12.0 kB CSS (+6 B) | — | — · — · — |
| ToggleButtonGroup | 41.6 kB (0) · 3.7 kB CSS (+6 B) | — | — · — · — |
| Token | 29.7 kB (0) · 4.9 kB CSS (+6 B) | — | — · — · — |
| TopNavMegaMenuItem | 15.3 kB (0) · 4.2 kB CSS (+6 B) | — | — · — · — |
| AspectRatio | 3.9 kB (0) · 3.6 kB CSS (+5 B) | — | — · — · — |
| AvatarStatusDot | 7.6 kB (0) · 3.5 kB CSS (+5 B) | — | — · — · — |
| Blockquote | 3.7 kB (0) · 3.5 kB CSS (+5 B) | — | — · — · — |
| BottomSheet | 75.3 kB (0) · 7.8 kB CSS (+5 B) | — | — · — · — |
| Breadcrumbs | 16.5 kB (0) · 3.4 kB CSS (+5 B) | — | — · — · — |
| ButtonGroup | 44.3 kB (0) · 3.7 kB CSS (+5 B) | — | — · — · — |
| Calendar | 77.5 kB (0) · 11.4 kB CSS (+5 B) | — | — · — · — |
| Center | 4.4 kB (0) · 4.6 kB CSS (+5 B) | — | — · — · — |
| ChatMessage | 17.2 kB (0) · 3.7 kB CSS (+5 B) | — | — · — · — |
| ChatMessageMetadata | 20.5 kB (0) · 4.1 kB CSS (+5 B) | — | — · — · — |
| ChatSystemMessage | 7.1 kB (0) · 3.8 kB CSS (+5 B) | — | — · — · — |
| Citation | 20.8 kB (0) · 4.4 kB CSS (+5 B) | — | — · — · — |
| Collapsible | 29.2 kB (0) · 4.5 kB CSS (+5 B) | — | — · — · — |
| CollapsibleGroup | 7.0 kB (0) · 3.3 kB CSS (+5 B) | — | — · — · — |
| CommandPaletteItem | 13.6 kB (0) · 3.6 kB CSS (+5 B) | — | — · — · — |
| CommandPaletteList | 16.4 kB (0) · 3.4 kB CSS (+5 B) | — | — · — · — |
| DialogHeader | 69.4 kB (0) · 12.5 kB CSS (+5 B) | — | — · — · — |
| Drawer | 54.8 kB (0) · 8.5 kB CSS (+5 B) | — | — · — · — |
| DrawerHeader | 69.6 kB (0) · 14.0 kB CSS (+5 B) | — | — · — · — |
| DropdownMenuRadioGroup | 6.6 kB (0) · 3.3 kB CSS (+5 B) | — | — · — · — |
| FieldStatus | 10.1 kB (0) · 3.6 kB CSS (+5 B) | — | — · — · — |
| Grid | 4.6 kB (0) · 3.8 kB CSS (+5 B) | — | — · — · — |
| InputGroup | 61.4 kB (0) · 7.9 kB CSS (+5 B) | — | — · — · — |
| Item | 20.6 kB (0) · 6.2 kB CSS (+5 B) | — | — · — · — |
| Kbd | 17.2 kB (0) · 3.6 kB CSS (+5 B) | — | — · — · — |
| LayoutPanel | 22.1 kB (0) · 5.1 kB CSS (+5 B) | — | — · — · — |
| MetadataList | 17.3 kB (0) · 3.8 kB CSS (+5 B) | — | — · — · — |
| MetadataListItem | 7.1 kB (0) · 3.5 kB CSS (+5 B) | — | — · — · — |
| Outline | 25.4 kB (0) · 4.1 kB CSS (+5 B) | — | — · — · — |
| OverflowList | 11.0 kB (0) · 3.6 kB CSS (+5 B) | — | — · — · — |
| Pagination | 147.8 kB (0) · 19.1 kB CSS (+5 B) | — | — · — · — |
| Popover | 100.4 kB (0) · 15.2 kB CSS (+5 B) | — | — · — · — |
| ScrollableArea | 11.5 kB (0) · 4.3 kB CSS (+5 B) | — | — · — · — |
| Selector | 114.9 kB (0) · 18.7 kB CSS (+5 B) | — | — · — · — |
| SelectorOption | 24.2 kB (0) · 6.7 kB CSS (+5 B) | — | — · — · — |
| SideNavSection | 7.1 kB (0) · 3.7 kB CSS (+5 B) | — | — · — · — |
| Step | 31.8 kB (0) · 5.6 kB CSS (+5 B) | — | — · — · — |
| TableBody | 3.5 kB (0) · 3.3 kB CSS (+5 B) | — | — · — · — |
| TableFooter | 3.5 kB (0) · 3.3 kB CSS (+5 B) | — | — · — · — |
| TableHeader | 3.5 kB (0) · 3.3 kB CSS (+5 B) | — | — · — · — |
| TableSelectionToolbar | 76.7 kB (0) · 14.1 kB CSS (+5 B) | — | — · — · — |
| TabList | 47.7 kB (0) · 6.5 kB CSS (+5 B) | — | — · — · — |
| Thumbnail | 70.8 kB (0) · 12.4 kB CSS (+5 B) | — | — · — · — |
| TopNav | 79.4 kB (0) · 11.8 kB CSS (+5 B) | — | — · — · — |
| TopNavItem | 14.6 kB (0) · 4.0 kB CSS (+5 B) | — | — · — · — |
| TopNavMegaMenuFeaturedCard | 8.4 kB (0) · 3.6 kB CSS (+5 B) | — | — · — · — |
| TreeList | 46.5 kB (0) · 6.0 kB CSS (+5 B) | — | — · — · — |
| AppShell | 98.9 kB (0) · 14.4 kB CSS (+4 B) | — | — · — · — |
| BaseTypeahead | 79.7 kB (0) · 11.7 kB CSS (+4 B) | — | — · — · — |
| BottomSheetSwitcher | 18.8 kB (0) · 3.4 kB CSS (+4 B) | — | — · — · — |
| ChatDictationButton | 66.9 kB (0) · 10.9 kB CSS (+4 B) | — | — · — · — |
| ChatMessageList | 30.0 kB (0) · 7.1 kB CSS (+4 B) | — | — · — · — |
| ChatToolCalls | 34.0 kB (0) · 8.5 kB CSS (+4 B) | — | — · — · — |
| CheckboxList | 73.5 kB (0) · 7.8 kB CSS (+4 B) | — | — · — · — |
| ClickableCard | 18.9 kB (0) · 7.4 kB CSS (+4 B) | — | — · — · — |
| CommandPaletteEmpty | 6.5 kB (0) · 3.5 kB CSS (+4 B) | — | — · — · — |
| CommandPaletteGroup | 3.7 kB (0) · 3.5 kB CSS (+4 B) | — | — · — · — |
| CommandPaletteInput | 33.5 kB (0) · 7.6 kB CSS (+4 B) | — | — · — · — |
| DropdownMenuGroup | 6.4 kB (0) · 3.4 kB CSS (+4 B) | — | — · — · — |
| Field | 59.9 kB (0) · 7.3 kB CSS (+4 B) | — | — · — · — |
| FieldLabel | 55.7 kB (0) · 5.8 kB CSS (+4 B) | — | — · — · — |
| FormLayout | 6.9 kB (0) · 3.5 kB CSS (+4 B) | — | — · — · — |
| GridSpan | 3.6 kB (0) · 3.4 kB CSS (+4 B) | — | — · — · — |
| Heading | 13.7 kB (0) · 5.5 kB CSS (+4 B) | — | — · — · — |
| NavHeadingMenu | 18.7 kB (0) · 3.5 kB CSS (+4 B) | — | — · — · — |
| NavIcon | 3.7 kB (0) · 3.4 kB CSS (+4 B) | — | — · — · — |
| PowerSearch | 310.6 kB (0) · 25.6 kB CSS (+4 B) | — | — · — · — |
| RadioList | 61.2 kB (0) · 7.4 kB CSS (+4 B) | — | — · — · — |
| Section | 7.8 kB (0) · 6.4 kB CSS (+4 B) | — | — · — · — |
| SegmentedControlItem | 19.0 kB (0) · 4.3 kB CSS (+4 B) | — | — · — · — |
| SelectableCard | 19.1 kB (0) · 7.6 kB CSS (+4 B) | — | — · — · — |
| SideNav | 122.6 kB (0) · 12.2 kB CSS (+4 B) | — | — · — · — |
| SideNavHeading | 83.9 kB (0) · 12.1 kB CSS (+4 B) | — | — · — · — |
| SideNavItem | 78.3 kB (0) · 11.9 kB CSS (+4 B) | — | — · — · — |
| Skeleton | 4.0 kB (0) · 3.8 kB CSS (+4 B) | — | — · — · — |
| Spinner | 26.6 kB (0) · 6.3 kB CSS (+4 B) | — | — · — · — |
| StatusDot | 34.1 kB (0) · 5.4 kB CSS (+4 B) | — | — · — · — |
| Switch | 109.6 kB (0) · 10.0 kB CSS (+4 B) | — | — · — · — |
| TableRow | 7.1 kB (0) · 4.0 kB CSS (+4 B) | — | — · — · — |
| TabMenu | 80.2 kB (0) · 12.0 kB CSS (+4 B) | — | — · — · — |
| Text | 13.2 kB (0) · 5.5 kB CSS (+4 B) | — | — · — · — |
| TimeInput | 178.0 kB (0) · 17.0 kB CSS (+4 B) | — | — · — · — |
| Toolbar | 47.5 kB (0) · 8.2 kB CSS (+4 B) | — | — · — · — |
| Tooltip | 32.5 kB (0) · 4.5 kB CSS (+4 B) | — | — · — · — |
| TopNavHeading | 83.5 kB (0) · 12.0 kB CSS (+4 B) | — | — · — · — |
| TopNavMegaMenu | 77.6 kB (0) · 12.7 kB CSS (+4 B) | — | — · — · — |
| TopNavMenu | 83.0 kB (0) · 12.1 kB CSS (+4 B) | — | — · — · — |
| TypeaheadItem | 6.6 kB (0) · 3.6 kB CSS (+4 B) | — | — · — · — |
| AlertDialog | 129.8 kB (0) · 15.5 kB CSS (+3 B) | — | — · — · — |
| BreadcrumbItem | 98.1 kB (0) · 13.3 kB CSS (+3 B) | — | — · — · — |
| Carousel | 76.5 kB (0) · 11.8 kB CSS (+3 B) | — | — · — · — |
| ChatLayout | 90.0 kB (0) · 11.4 kB CSS (+3 B) | — | — · — · — |
| ChatLayoutScrollButton | 66.9 kB (0) · 11.0 kB CSS (+3 B) | — | — · — · — |
| CheckboxInput | 69.5 kB (0) · 10.2 kB CSS (+3 B) | — | — · — · — |
| CheckboxListItem | 80.4 kB (0) · 12.1 kB CSS (+3 B) | — | — · — · — |
| CommandPalette | 78.8 kB (0) · 12.8 kB CSS (+3 B) | — | — · — · — |
| CommandPaletteFooter | 17.5 kB (0) · 3.7 kB CSS (+3 B) | — | — · — · — |
| Dialog | 25.8 kB (0) · 7.0 kB CSS (+3 B) | — | — · — · — |
| DropdownMenu | 108.9 kB (0) · 18.9 kB CSS (+3 B) | — | — · — · — |
| DropdownMenuSubMenu | 79.1 kB (0) · 10.5 kB CSS (+3 B) | — | — · — · — |
| ListItem | 79.6 kB (0) · 12.1 kB CSS (+3 B) | — | — · — · — |
| MoreMenu | 109.2 kB (0) · 18.9 kB CSS (+3 B) | — | — · — · — |
| Slider | 115.0 kB (0) · 8.9 kB CSS (+3 B) | — | — · — · — |
| Table | 121.7 kB (0) · 19.8 kB CSS (+3 B) | — | — · — · — |
| TableHeaderCell | 104.5 kB (0) · 19.1 kB CSS (+3 B) | — | — · — · — |
| Tokenizer | 106.0 kB (0) · 20.4 kB CSS (+3 B) | — | — · — · — |
| Banner | 68.4 kB (0) · 11.3 kB CSS (+2 B) | — | — · — · — |
| ContextMenu | 103.5 kB (0) · 18.8 kB CSS (+2 B) | — | — · — · — |
| HoverCard | 30.6 kB (0) · 4.5 kB CSS (+2 B) | — | — · — · — |
| InfoTip | 50.7 kB (0) · 5.4 kB CSS (+2 B) | — | — · — · — |
| ProgressBar | 12.0 kB (0) · 6.4 kB CSS (+2 B) | — | — · — · — |
| RadioListItem | 76.5 kB (0) · 10.7 kB CSS (+2 B) | — | — · — · — |
| Timer | 15.3 kB (0) · 6.1 kB CSS (+2 B) | — | — · — · — |
| ChatComposerInput | 83.6 kB (0) · 12.1 kB CSS (+1 B) | — | — · — · — |
| ChatComposerTokenElement | 83.6 kB (0) · 12.1 kB CSS (+1 B) | — | — · — · — |
| Timestamp | 30.8 kB (0) · 11.1 kB CSS (+1 B) | — | — · — · — |
| charts/ChartAxis | 7.0 kB (0) · 112 B CSS (0) | — | — · — · — |
| charts/ChartLegend | 48.4 kB (0) · 224 B CSS (0) | — | — · — · — |
| charts/ChartTooltip | 218.7 kB (0) · 451 B CSS (0) | — | — · — · — |
| lab/ChartDotGL | 7.6 kB (0) · 20 B CSS (0) | — | — · — · — |
| lab/ChartDotGLInteractive | 8.6 kB (0) · 20 B CSS (0) | — | — · — · — |
| lab/ChartHeatmapGL | 8.8 kB (0) · 20 B CSS (0) | — | — · — · — |
| lab/ChartStreamGL | 7.7 kB (0) · 20 B CSS (0) | — | — · — · — |
| lab/ChatEmojiPicker | 122.8 kB (0) · 773 B CSS (0) | — | — · — · — |
| lab/ChatReactionBar | 124.0 kB (0) · 1.1 kB CSS (0) | — | — · — · — |
| lab/ChatReasoning | 7.2 kB (0) · 967 B CSS (0) | — | — · — · — |
| lab/ChatTypingIndicator | 26.3 kB (0) · 612 B CSS (0) | — | — · — · — |
| lab/ChatUnreadDivider | 3.7 kB (0) · 348 B CSS (0) | — | — · — · — |
| lab/ChatVirtualizer | 57.4 kB (0) · 223 B CSS (0) | — | — · — · — |
| lab/CircleCheckIndicator | 4.6 kB (0) · 1.0 kB CSS (0) | — | — · — · — |
| lab/CircularProgress | 9.1 kB (0) · 880 B CSS (0) | — | — · — · — |
| lab/CodeEditor | 14.6 kB (0) · 743 B CSS (0) | — | — · — · — |
| lab/CommentPin | 60.7 kB (0) · 1.2 kB CSS (0) | — | — · — · — |
| lab/DiffViewer | 94.5 kB (0) · 2.1 kB CSS (0) | — | — · — · — |
| lab/EmojiPicker | 118.9 kB (0) · 751 B CSS (0) | — | — · — · — |
| lab/LineClamp | 15.6 kB (0) · 168 B CSS (0) | — | — · — · — |
| lab/LogStream | 8.2 kB (0) · 1.6 kB CSS (0) | — | — · — · — |
| lab/NavigationScreen | 85.4 kB (0) · 1.5 kB CSS (0) | — | — · — · — |
| lab/NavigationStack | 85.4 kB (0) · 1.5 kB CSS (0) | — | — · — · — |
| lab/PageControl | 78.3 kB (0) · 709 B CSS (0) | — | — · — · — |
| lab/Schedule | 116.0 kB (0) · 3.9 kB CSS (0) | — | — · — · — |
| lab/SelectableCardGroup | 69.3 kB (0) · 162 B CSS (0) | — | — · — · — |
| lab/Stat | 4.3 kB (0) · 646 B CSS (0) | — | — · — · — |
| lab/SVGIcon | 7.9 kB (0) · 765 B CSS (0) | — | — · — · — |
| lab/TabBar | 83.7 kB (0) · 1.8 kB CSS (0) | — | — · — · — |
| lab/TabBarItem | 3.9 kB (0) · 1.8 kB CSS (0) | — | — · — · — |
| lab/TabBarMoreList | 102.5 kB (0) · 1.8 kB CSS (0) | — | — · — · — |
| lab/ThreeDScatterGL | 7.9 kB (0) · 20 B CSS (0) | — | — · — · — |
| lab/TourStep | 95.1 kB (0) · 691 B CSS (0) | — | — · — · — |
| lab/TransferList | 136.5 kB (0) · 1.2 kB CSS (0) | — | — · — · — |
| lab/TransferListSelector | 145.4 kB (0) · 1.4 kB CSS (0) | — | — · — · — |
| lab/WeightedSVGIcon | 5.1 kB (0) · 1.1 kB CSS (0) | — | — · — · — |
| richtext/RichTextEditor | 308.1 kB (0) · 2.7 kB CSS (0) | — | — · — · — |
| richtext/RichTextEditorToolbar | 309.3 kB (0) · 454 B CSS (0) | — | — · — · — |
| richtext/RichTextView | 285.3 kB (0) · 2.4 kB CSS (0) | — | — · — · — |
Package size:
- @astryxdesign/cli 5.50 MB packed (+5.0 kB); no new dependencies
- @astryxdesign/core 7.68 MB packed (−167 B); no new dependencies
- @astryxdesign/theme-butter 56.6 kB packed (+461 B); no new dependencies
6 more packages
- @astryxdesign/theme-chocolate 18.2 kB packed (+81 B); no new dependencies
- @astryxdesign/theme-gothic 40.1 kB packed (+73 B); no new dependencies
- @astryxdesign/theme-matcha 29.6 kB packed (+102 B); no new dependencies
- @astryxdesign/theme-neutral 41.3 kB packed (+87 B); no new dependencies
- @astryxdesign/theme-stone 41.2 kB packed (+134 B); no new dependencies
- @astryxdesign/theme-y2k 45.4 kB packed (+143 B); no new dependencies
API changes: core +0 · ~2 · −0; theme-butter +1 · ~0 · −0; theme-chocolate +1 · ~0 · −0; theme-gothic +1 · ~0 · −0; theme-matcha +1 · ~0 · −0; theme-neutral +1 · ~0 · −0; theme-stone +1 · ~0 · −0
8 API changes (advisory)
| Package | Where | Signature | Usage | |
|---|---|---|---|---|
| ~ | core |
. · Values · const radiusDefaults |
--radius-chat: '28px' → --radius-chat: 'var(--radius-container)' |
import {radiusDefaults} from '@astryxdesign/core' |
| ~ | core |
. · Values · const radiusVars |
const radiusVars: stylex.VarGroup<Readonly<{ readonly '--radius-none': "0px"; readonly '--radius-inner': "4px"; readonly '--radius-element': "8px"; readonly '--radius-container': … #146a4918 → const radiusVars: stylex.VarGroup<Readonly<{ readonly '--radius-none': "0px"; readonly '--radius-inner': "4px"; readonly '--radius-element': "8px"; readonly '--radius-container': … #f0f73ad8 |
import {radiusVars} from '@astryxdesign/core' |
| + | theme-butter |
Stylesheets · var --radius-chat (./theme.css) |
var --radius-chat (./theme.css) |
.my-scope { --radius-chat: …; } |
| + | theme-chocolate |
Stylesheets · var --radius-chat (./theme.css) |
var --radius-chat (./theme.css) |
.my-scope { --radius-chat: …; } |
| + | theme-gothic |
Stylesheets · var --radius-chat (./theme.css) |
var --radius-chat (./theme.css) |
.my-scope { --radius-chat: …; } |
| + | theme-matcha |
Stylesheets · var --radius-chat (./theme.css) |
var --radius-chat (./theme.css) |
.my-scope { --radius-chat: …; } |
| + | theme-neutral |
Stylesheets · var --radius-chat (./theme.css) |
var --radius-chat (./theme.css) |
.my-scope { --radius-chat: …; } |
| + | theme-stone |
Stylesheets · var --radius-chat (./theme.css) |
var --radius-chat (./theme.css) |
.my-scope { --radius-chat: …; } |
Wide change (shared styles: packages/core/src/theme/expandRadiusScale.ts, packages/core/src/theme/statusRoleDefaults.ts, packages/core/src/theme/tokens.stylex.ts, and 8 more): add ci:run-visual for Visual, ci:run-a11y for Accessibility, ci:run-rtl for RTL.
CI impact: 0 job-min per update · pool 0% · standard runners · 1 CI action or script file changed (not measured)
| Before | After | Change | |
|---|---|---|---|
| Job-minutes per PR update | 173.5 | 173.5 | 0 |
| Runner pool, runner-minutes a day | 51,781 | 51,781 | 0 (0%) |
| Average concurrent jobs | 36 | 36 | 0 |
| Time to green (median → this run) | — | 46.1 min | — |
| Runs a day | 298 | 298 | 0 |
Not measured (the jobs that use these keep their recent minutes above): .github/scripts/visual-gate/lib/probe-axes.mjs.
Assumptions: before is each job's average over the last 20 pull-request runs; after keeps that for unchanged jobs and uses this run's minutes for added or changed ones, weighted by how often each changed job ran in those runs; runs a day averages the seven whole days before today; time to green compares this run with the median of those runs that ran the same jobs.
Generated by PR Enrichment workflow | View full report
|
AI review status for this pull request.
|
There was a problem hiding this comment.
Approval waits on an engineering owner: no current spec record sets the default of --radius-chat, the alias a theme root now writes for it, or how a radius scale treats it. What must be settled is whether --radius-chat defaults to var(--radius-container), which is 12px instead of 28px for a page with no theme and a scaled theme's container step instead of its page step. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request; the author may do so if they are an engineering owner.
Still required once that is settled:
- The description says nothing changes for people using the shipped themes, and the CLI changeset says
astryx upgradekeeps each theme's chat corners, but a page that sets--radius-chaton an ancestor such as:rootnow gets the theme's 28px (20px to 28px under Neutral in Chromium), so add the core changeset's "set the token in the theme" caveat to both.
Claims and files checked
Review mode: full; reason: no-earlier-review
Claims:
- The chat radius defaulted to 28px and now follows the container radius: verified (
tokens.stylex.ts:258-259,expandRadiusScale.test.ts:67-72, bubbles 28px to 12px with no theme in Chromium). - The shipped themes set the token, so nothing changes for people using them: false for a page that sets the token above the theme (Neutral bubbles 20px to 28px); otherwise verified (Neutral and Butter frames identical, all seven themes identical on touch).
- The upgrade writes each existing theme's old value: verified for every tested shape (32 tests; the 18 built fixtures' before-values match the base's own output; nine more shapes keep their value or get a TODO), with the same exception as the claim above.
- No current record sets the token's default, and the alias record speaks of status roles: verified.
- A theme that sets its container but not the chat radius writes the alias at its root, a nested theme follows its own container, and a theme that sets or inherits the token keeps it: verified (
statusRoleDefaults.ts:55,expandRadiusScale.test.ts:74-126). - A radius scale no longer sets the token: verified (
expandRadiusScale.ts:88-95,expandRadiusScale.test.ts:18). - Six themes, the probe fixture and the docs-site theme set 28px, and Y2K sets 0px because its square corners came from its zero-multiplier scale: verified (theme sources;
y2kTheme.ts:270). - The send button stays circular inside a composer, and a theme's button or send-button radius still wins: verified (
ChatSendButton.tsx:67-71; the new test fails on the base; Butter's rule wins in Chromium). - Butter keeps its 16px send-button corner with a composer-scoped rule, and other composer buttons keep the concentric corner: verified (
butterTheme.ts:509-513, Chromium probes). - The codemod's handling of extended, unreadable and default-exported themes: verified (
preserve-chat-radius.mjs:273-341,:371-415,:473-512; tests at:87-157,:196-249). - The CLI theme copies, radius token docs and native default theme are regenerated: verified (identical copies, token-docs check, Swift
chat: 12). - The changed-pixel counts with no theme and zero changes across the shipped-theme states: direction verified in 17 captured states; the counts were not recounted.
- The stated test runs and repository checks pass: verified for the suites and checks rerun.
- The branch carries the two earlier pull requests' commits rebased onto main, with the alias pair moved to its new file: verified.
- Core changeset (who changes, the composer's buttons, the send button, how to keep 28px, a theme scope replacing an inherited value): verified.
- CLI changeset (what the codemod writes, trusts and reports): verified, except "keeps each theme's chat corners" (above).
Files:
.changeset/astryx-upgrade-keeps-the-28px-chat-corners-of-a--0qsj.md: finding (claim above).changeset/chat-surfaces-now-default-to-the-container-radiu-q0fy.md: clear.github/scripts/visual-gate/lib/probe-axes.mjs: clearapps/docsite/src/themes/astryxTheme.ts: clearinternal/eslint-plugin-astryx/no-comment-provenance.baseline.json: clear (regenerated)packages/cli/assets/codemods/transforms/next/__tests__/preserve-chat-radius.test.mjs: clearpackages/cli/assets/codemods/transforms/next/index.mjs: clearpackages/cli/assets/codemods/transforms/next/preserve-chat-radius.mjs: clearpackages/cli/assets/docs/author-a-theme.doc.mjs: clearpackages/cli/assets/docs/tree/tokens-radius.doc.mjs: clear (regenerated)packages/cli/assets/templates/themes/{butter,chocolate,gothic,matcha,neutral,stone,y2k}(7 files): clear (identical to the theme sources)packages/cli/assets/theme.template.ts: clearpackages/core/src/Chat/ChatComposer.doc.mjs: clearpackages/core/src/Chat/ChatComposer.tsx: clearpackages/core/src/Chat/ChatMessageBubble.tsx: clearpackages/core/src/Chat/ChatSendButton.test.tsx: clearpackages/core/src/Chat/ChatSendButton.tsx: clearpackages/core/src/theme/expandRadiusScale.test.ts: clearpackages/core/src/theme/expandRadiusScale.ts: awaits the owner decisionpackages/core/src/theme/statusRoleDefaults.ts: awaits the owner decisionpackages/core/src/theme/tokens.stylex.ts: awaits the owner decisionpackages/native/apple/Sources/Astryx/Theme/Generated/DefaultTheme.swift: clear (regenerated)packages/themes/{butter,chocolate,gothic,matcha,neutral,stone,y2k}/src/*Theme.ts(7 files): clearpackages/themes/probe/src/probeConfig.ts: clear
…eme no longer reaches it
There was a problem hiding this comment.
Approval waits on an engineering owner to decide what no current spec record settles: whether --radius-chat defaults to var(--radius-container) (12px instead of 28px for a page with no theme), whether a theme that sets its container radius but not the chat radius writes that alias at its root, and whether a radius scale stops writing the token. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request; the author may do so if they are an engineering owner. The earlier wording request is resolved, because the CLI changeset and the description now say that a --radius-chat set above a theme no longer reaches it, and no other change is required.
- Optional:
packages/core/src/Chat/Chat.doc.mjsstill says every button inside the composer follows--_chat-composer-radius, though the send button no longer does, and the new comment inChatSendButton.tsxwould read better in active voice (inline suggestion).
Claims and files checked
Review mode: full; reason: author-not-engowner
Claims:
- Carries two earlier pull requests' commits rebased onto main, with the theme-root alias pair moved to main's alias-table file: verified (both merged into stacked branches, not main; same commit series;
statusRoleDefaults.ts:55). - The chat radius defaulted to 28px and now follows the container radius: verified (
tokens.stylex.ts:259; Chromium bubbles and composer 28px to 12px with no theme). - Shipped themes set the token, so nothing changes for people using them, except a value set on an ancestor such as
:root, which the theme now replaces (20px to 28px under Neutral): verified (identical composer frames for all eight themes; Neutral:rootprobe 20px to 28px). - The upgrade writes each existing theme's old value, so an app keeps its corners: verified (32 codemod tests; 18 fixtures built with Core match the old output at the root and per adaptation rule; TODO paths as described).
- No current record sets the token's default, and the alias record speaks only of status roles: verified.
- A theme that sets its container but not chat writes the alias at its root, a nested theme follows its own container, and a theme that sets or inherits the token keeps it: verified (new radius tests, four of which fail on the base).
- A radius scale no longer sets the token: verified (
expandRadiusScale.ts:88-95). - Six themes, the Probe fixture and the docs-site theme set 28px, and Y2K sets 0px because its square corners came from its zero-multiplier scale: verified (theme sources; Y2K
radius: {base: 4, multiplier: 0}). - The send button stays circular inside a composer, and a theme that sets the button or send-button radius still wins: verified (
ChatSendButton.tsx:70; the new test fails on the base; Butter's rule computes 16px). - Butter keeps its 16px send-button corner with a composer-scoped rule, and the other composer buttons keep the concentric corner: verified (
butterTheme.ts:511-512; Chromium probes). - The codemod's handling of extended, unreadable and default-exported themes: verified (tests; aliased and namespace imports are edited, and shadowed, type-only and re-exported names are left alone).
- The CLI theme copies, the radius token docs and the native default theme are regenerated: verified (identical copies; the token-docs check passes; the Swift generator reproduces the files).
- Changed-pixel counts with no radius set: the direction is verified in Chromium frames; the counts were not recounted.
- Zero changed pixels for every shipped theme: verified for all eight themes at rest in light mode; the other listed states were not recaptured.
- The stated test runs and repository checks pass: verified for the reruns (theme and Chat UI suites, the node suites, codemod tests, changesets, token docs, provenance baseline).
- Core changeset (who changes, the composer's buttons, when the send button becomes a circle, which themes look the same, how to keep 28px, a theme scope replacing an inherited value): verified.
- CLI changeset (what the codemod writes, which bases it trusts, its TODOs and manual report, the ancestor caveat): verified.
Files:
.changeset/astryx-upgrade-keeps-the-28px-chat-corners-of-a--0qsj.md: clear (the earlier caveat finding is fixed).changeset/chat-surfaces-now-default-to-the-container-radiu-q0fy.md: clear.github/scripts/visual-gate/lib/probe-axes.mjs: clearapps/docsite/src/themes/astryxTheme.ts: clearinternal/eslint-plugin-astryx/no-comment-provenance.baseline.json: clear (regenerated)packages/cli/assets/codemods/transforms/next/__tests__/preserve-chat-radius.test.mjs: clearpackages/cli/assets/codemods/transforms/next/index.mjs: clearpackages/cli/assets/codemods/transforms/next/preserve-chat-radius.mjs: clearpackages/cli/assets/docs/author-a-theme.doc.mjs: clearpackages/cli/assets/docs/tree/tokens-radius.doc.mjs: clear (regenerated)packages/cli/assets/templates/themes/{butter,chocolate,gothic,matcha,neutral,stone,y2k}(7 files): clear (identical to the theme sources)packages/cli/assets/theme.template.ts: clearpackages/core/src/Chat/ChatComposer.doc.mjs: clearpackages/core/src/Chat/ChatComposer.tsx: clearpackages/core/src/Chat/ChatMessageBubble.tsx: clearpackages/core/src/Chat/ChatSendButton.test.tsx: clearpackages/core/src/Chat/ChatSendButton.tsx: non-blocking comment wordingpackages/core/src/theme/expandRadiusScale.test.ts: clearpackages/core/src/theme/expandRadiusScale.ts: awaits the owner decisionpackages/core/src/theme/statusRoleDefaults.ts: awaits the owner decisionpackages/core/src/theme/tokens.stylex.ts: awaits the owner decisionpackages/native/apple/Sources/Astryx/Theme/Generated/DefaultTheme.swift: clear (regenerated)packages/themes/{butter,chocolate,gothic,matcha,neutral,stone,y2k}/src/*Theme.ts(7 files): clearpackages/themes/probe/src/probeConfig.ts: clear
| // Declared on the button itself, so it stays circular inside a composer, | ||
| // whose concentric radius reaches other buttons by inheritance. A theme | ||
| // that sets the button or send-button radius still wins. |
There was a problem hiding this comment.
Non-blocking: this comment opens with a passive fragment and joins two topics. A shorter version that keeps the reason:
// The send button sets this variable itself. The composer's concentric
// radius then reaches only the other buttons. A theme's button or
// send-button radius still wins.|
/approve-spec 757ce67 |
Carries #12482 and #12483 onto
main. Both merged into their stacked base branches instead ofmain, so only #12481 reachedmain. These are the same commits, rebased ontomain. The one conflict:mainmoved the theme-root alias table intopackages/core/src/theme/statusRoleDefaults.ts, so the new['--radius-chat', '--radius-container']pair is there now.User impact
--radius-chatdefaulted to 28px, so chat surfaces (the composer, its drawer and status bar, message bubbles) were rounder than everything else in a theme that did not set it, whatever its container radius. They now default to the theme's container radius. The shipped themes set--radius-chatthemselves, so nothing changes for people using them; a theme that does not set it gets chat corners that match its cards.astryx upgradewrites each existing theme's old value into its tokens, so an app keeps its corners until its author removes the token. One exception: a page that sets--radius-chaton an ancestor of the theme, such as:root, loses that value inside the theme, because the theme (or the upgrade) now declares the token at the theme root; under Neutral, a 20px:rootvalue becomes 28px. Setting the token in the theme keeps it.Visual authority
Choose one and link it:
DDrow reused or amended.Design decisionstable by a team design owner.docs/design/.None yet. Design owner decision (@kentonquatman): chat surfaces default to the container radius. No current record sets the default of
--radius-chat, so this needs an engineering owner's approval.architecture:theme-compilationINV16 describes the generated root alias in terms of status roles; this adds one token to the same mechanism.What changes:
--radius-chatdefaults tovar(--radius-container)instead of28px.--radius-containerbut not--radius-chatdeclares--radius-chat: var(--radius-container)at its root, the way--duration-exitfollows--duration-fast, so a nested theme follows its own container. A theme that sets or inherits--radius-chatkeeps it.--radius-chat(it set the page step, base × 7 × multiplier), so chat follows the container also where a theme sets its container over the scale.--radius-chat: 28px, and so do the Probe fixture and the docs site's theme. Y2K sets0px: its square corners came from its multiplier-0 radius scale, so a theme that extends it and sets its own container stays square.component:ChatSendButtonFR7 requires: it declares--_button-radius: var(--radius-full)itself, so the composer's concentric radius no longer reaches it; a theme that sets the button or send-button radius still wins. Butter keeps the 16px corner of its 40px send button with achat-send-buttonrule scoped to the composer. The other buttons in the composer keep the concentric corner.astryx upgradecodemod,preserve-chat-radius, keeps each theme's old chat corners (reviewed as feat(cli): upgrade codemod keeps a theme's 28px chat corners #12483):defineTheme()imported from Astryx gets--radius-chatin its tokens: 28px, or the page step of its literal radius scale. Each adaptation rule with a radius scale gets its own page step, completed from the theme's scale, as Core does.spec:AST-040FR1). The upgrade reports it as a manual migration with the values to add.Before and after
Chromium, compared pixel by pixel with
mainbefore this change:Release note: a theme that does not set
--radius-chatchanges, from 28px to its container radius, unlessastryx upgradeadds the token. Add--radius-chat: 28pxto its tokens to keep the old corners by hand. Set the token in the theme rather than on an ancestor such as:root: a theme scope that declares it now replaces an inherited value.State matrix
lgbreakpoint, where Neutral, Butter and Chocolate change their type scale)Each gallery covers the composer with header, footer and send actions, the drawer expanded and collapsed, status above and below, compact, flat, disabled with Stop, a drawer and send buttons outside a composer, and single, grouped and compact message bubbles. The comparisons were run on #12482's content, which this branch carries unchanged.
Scope
Components: ChatComposer, ChatComposerDrawer, ChatSendButton, ChatMessageBubble (through the token), theme compilation, radius scale,
astryx upgrade(codemodpreserve-chat-radius)astryx upgradestep is this change's migration: it keeps existing themes unchanged, so it ships with it.Testing
On this branch, rebased onto
main:vitest run --project ui packages/core/src/theme packages/core/src/Chat packages/core/src/Button: 2598 passed. Includes the newexpandRadiusScale.test.tscases (the default, the alias in a theme that sets only its container, the alias with a radius scale and with a container set over the scale, and a theme that sets or inherits the token) and the newChatSendButton.test.tsxcase, which fails without the fix.vitest run --project node packages/cli/assets/codemods packages/themes packages/native check-theme-template check-cli-theme-bundle theme-package-module-format: 1455 passed. Includespreserve-chat-radius.test.mjs(32 cases; 18 build each migrated fixture with Core and compare its chat radius, at the root and under each adaptation rule, with the value before the default change).check:repo,check:changesets,check:knowledge,visual:probe-theme:check, and the comment-provenance baseline check.