Repository navigation
spec(TextInput): React Native platform record - #12821
imdreamrunner wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, and four requirements need fixing first.
To fix:
- FR7 shows a
tooltipstatus as a detached message in the system box that the defaultrender="auto"picks, but the input-field family requires every input to offertooltipand a platform may not accept a value it only partly honors, so keep Astryx's field for atooltipstatus (as for a start icon) or draw the status icon outside the box. - FR10, AR4 and the disabled-with-a-reason state open a disabled field's reason on a long press and attribute that to core, but core's touch behavior opens a disabled control's reason on a tap (Tooltip FR5), so use a tap and cite that clause.
- FR14 says Return always calls
onEnter, which drops core FR10's exception for a Return that commits an input-method conversion, an exception the record's own verification row still expects. - FR6 is marked
settled, but its bases (AST-112 FR21, AST-126 FR2 and FR5) are not current records, so mark ithuman decision.
Owner decision: the record adds requirements no current record states, and FR6 names the text-box choice render where the public component API calls a surface choice presentation with adaptive-… values. An engineering owner approves or amends the record, including that naming, by commenting /approve-spec <full head SHA> on the head that carries the fixes; the author may do so as an engineering owner.
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim: builds on the platform-records change, whose head is this pull request's base: verified.
- Claim: cites four other open draft records and merges after them: verified; all four are open drafts.
- Claim: core TextInput keeps the keyboard props in the web contract and a platform carries one only where its field applies it: verified (core FR16 names the Swift contract; the native-first surfaces spec FR3 states the general rule).
- Claim: the Swift record carries
text,passwordandemailand no keyboard props: verified (Swift FR6). - Claim: the native-controls draft owns the system text box and the shapes that stay drawn: verified in its open pull request (FR2, FR5).
- Claim: the foundation amendment's FR21 defines
renderand records thepresentationspelling as a gap: verified in its open pull request. - Claim: the native-first surfaces spec's FR3, FR4, FR7, FR17 and DEC-14 cover the contracts, portable forms, base props and icon names: verified.
- Claim: no other open pull request carries a React Native TextInput record: consistent with a repository search.
- Claim: each decision bullet matches the record (FR1–FR17, AR1–AR6, the gap lines): verified; four of those requirements are the findings above.
- Claim: specification only, with no implementation: verified (one Markdown file).
- Claim: writing rubric results R1–R7: verified against the record.
- Claim: no internal context in public text: verified.
- Claim: the knowledge check, Prettier and the whitespace check are clean: verified at this head.
- File:
docs/specs/components/TextInput/TextInput.react-native.spec.md: the four findings above.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, and one requirement needs fixing first.
To fix:
- Miss: in the system box that the default
render="auto"picks, anattachedstatus (core TextInput's default) colours only the border and shows no status glyph (FR7, AV3), but core TextInput requires every status to carry a cue other than colour, so showattachedthere asdetached, with its glyph in the message box, and say what cue a status with no message keeps.
Owner decision: the record adds requirements no current record states, and FR6 names the text-box choice render where the public component API calls a surface choice presentation with adaptive-… values. An engineering owner approves or amends the record, including that naming, by commenting /approve-spec <full head SHA> on the head that carries the fix; the author may do so as an engineering owner.
The earlier four fixes are in: FR6's review state, the tooltip placement, the tap that opens a disabled reason, and Return during an input-method conversion. A non-blocking point: the native-controls draft's list of shapes that keep Astryx's field does not yet include the tooltip placement this record adds.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: builds on the platform-records change, whose head is this pull request's base: verified.
- Claim: cites four other open draft records and merges after them: verified; all four are open drafts.
- Claim: core TextInput keeps the touch-keyboard props in the web contract and a platform carries one only where its field applies it: verified (core FR16; the native-first surfaces spec's FR3).
- Claim: the Tooltip record opens a disabled control's reason on a tap under touch: verified (Tooltip FR5).
- Claim: the Swift record carries
text,passwordandemailand no keyboard props: verified (Swift FR6). - Claim: the input-field family owns the labelled field, status placements, the clear control and grouped admission: verified.
- Claim: the native-controls draft owns the system text box and lists the shapes that stay drawn (inside an
InputGroup, a start icon on Android): verified in its open pull request (FR2, FR5). - Claim: the foundation amendment's FR21 defines
renderand records thepresentationspelling as a gap: verified in its open pull request. - Claim: the native-first surfaces spec's FR3, FR4, FR7, FR17 and DEC-14 cover the contracts, portable forms, base props and icon names: verified.
- Claim: no other open pull request carries a React Native TextInput record: consistent with a repository search.
- Claim: each decision bullet matches the record (FR1–FR17, AR1–AR6, AV3, the gap lines): verified; the system box's
attachedstatus is the finding above. - Claim: no rejected alternatives are recorded: verified.
- Claim: specification only, with no implementation: verified (one Markdown file).
- Claim: writing rubric results R1–R7: verified against the record.
- Claim: the knowledge check, Prettier and the whitespace check pass: verified at this head.
- Claim: no internal context in public text: verified.
- File:
docs/specs/components/TextInput/TextInput.react-native.spec.md: one finding (FR7, AV3) and one non-blocking note (FR6); the rest conforms or waits on the owner decision.
There was a problem hiding this comment.
Approval waits only on an engineering owner's decision on this draft record: the earlier fix is in, as the record now gives every status in the system box its glyph below the box (FR7, AV3), and no record fix remains.
Owner decision: the record adds requirements no current record states, and FR6 names the text-box choice render where the public component API calls a surface choice presentation with adaptive-… values; an engineering owner approves or amends the record, that naming included, by commenting /approve-spec <full head SHA> on this head, and the author may do so as an engineering owner.
Non-blocking: the native-controls draft's list of shapes that keep Astryx's field does not yet include the tooltip placement FR6 adds.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: builds on the platform-records change, whose head is this pull request's base, and merges after it: verified.
- Claim: cites four other open draft records and merges after them: verified; all four are open drafts.
- Claim: core TextInput keeps the touch-keyboard props in the web contract and a platform carries one only where its field applies it: verified (core FR16; the native-first surfaces spec's FR3).
- Claim: the Tooltip record opens a disabled control's reason on a tap under touch: verified (Tooltip FR5).
- Claim: the Swift record carries
text,passwordandemailand no keyboard props: verified (Swift FR6). - Claim: the input-field family owns the labelled field, status placements, the clear control and grouped admission: verified.
- Claim: the native-controls draft owns the system text box and its rule for when a field uses it, including the shapes that stay drawn: verified in its open pull request (FR2, FR5).
- Claim: the foundation amendment's FR21 defines
renderand records thepresentationspelling as a gap: verified in its open pull request. - Claim: the native-first surfaces spec's FR3, FR4, FR7, FR17 and DEC-14 cover the contracts, portable forms, base props and icon names: verified.
- Claim: no other open pull request carries a React Native TextInput record: consistent with a repository search.
- Claim: each decision bullet matches the record (FR1–FR17, AR1–AR6, the system-box status shown as
detachedwith its glyph, the gap lines): verified. - Claim: no rejected alternatives are recorded: verified.
- Claim: specification only, with no implementation: verified (one Markdown file).
- Claim: writing rubric results R1–R7: verified against the record.
- Claim: the knowledge check, Prettier and the whitespace check pass: verified at this head.
- Claim: no internal context in public text: verified.
- File:
docs/specs/components/TextInput/TextInput.react-native.spec.md: no blocking finding; one non-blocking note (FR6 against the native-controls draft's list); the rest conforms or waits on the owner decision.
Stacked on #12592; merges after it.
Merge order: this record also cites
spec:AST-126(#12556, the system text box and when a host exists),spec:AST-127(#12555, icons),spec:AST-129(#12552, the keyboard) and the AST-112 amendment (#12563), whose FR21 definesrenderand the theme'srender.default. It merges after those too.Exact decision needed
How React Native presents TextInput: which core props each platform offers, which text box draws the field (the system text box or Astryx's field) and what each draws, and how the field's states, keyboard and accessibility behave on iOS and Android.
Existing authority searched
component:TextInput(docs/specs/components/TextInput/TextInput.spec.md): the props, states and words this record keeps; its FR16 puts the touch-keyboard props in the web contract and lets a platform carry one where its field applies it.component:TooltipFR5: a disabled control's reason opens on a tap under touch.component:swift/TextInput: the Swift record, which carriestext,passwordandemailand no keyboard props; no React Native rendering.family:input-fields: the labelled field, status placements, the clear control and grouped admission, which this record keeps.spec:AST-126(open draft): owns the system text box's native contract and FR2's rule for when a field uses it, including the shapes that stay drawn (inside anInputGroup, a start icon on Android).spec:AST-112amendment (open draft): FR21 definesrender(auto,system,drawn) and records the package'spresentationspelling as a gap.spec:AST-082FR3, FR4, FR7, FR17 and DEC-14: the core and platform contracts, portable forms, base props and icon names.Decision
docs/specs/components/TextInput/TextInput.react-native.spec.md(component:react-native/TextInput,platform_of: component:TextInput):TextInputunder its core name with core's props and meanings.changeAction,onKeyDown,htmlName,autoComplete,widthand thecontainer*/control*styling inputs stay in the web contract, each with its reason (FR2).onChangereceives the value alone;startIcontakes an icon name.onFocusandonBlur(no argument, any focus source),render, and anInputHandleref (DEC-1).previousis an Android Return key only, andhasSpellCheckis iOS only, since Android's spelling marks follow autocorrect (FR4). Unset, capitalization and correction follow the type.typetakestext,passwordandemail;inputModebrings up the search, phone and URL keyboards. Whethertypealso takessearch,telandurlis OQ1.render="auto"is the system text box wherever a host exists, asspec:AST-126FR2 states; the field stays Astryx's field inside anInputGroup, withstatusVariant="tooltip"(the system box has no status icon to carry the message), and with a start icon the system box cannot draw (FR6, markedhuman decisionsince its bases are open drafts). In the system box, the label, description and status stay Astryx's; anattachedordetachedstatus shows as core'sdetachedplacement, with its glyph below the box, so every status keeps a cue other than colour (FR7, AV3).TextInputin the field family's control box; its height grows with the text size, and its placeholder is drawn text that wraps and is never cut (FR8, FR9, DEC-2).component:TooltipFR5 states for touch. The theme reaches the system box only throughspec:AST-126FR11's list (FR17).FRn gaplines say so: thepresentationspelling and its default, a start icon, atooltipstatus and a status with no message in the system box,enterKeyHint="previous"on iOS,hasSpellCheckon Android,inputMode="none"in the system box, and the disabled reason (a long press in Astryx's field, none in the system box).Rejected alternatives
None recorded in the record.
Claim scope and non-goals
The record covers only what React Native adds to
component:TextInputor does differently. The system text box's native contract,render, icons, the keyboard and the field family's shared rules stay with their owners, which the ownership lines name.Evidence and implementation relationship
The record is a specification only and has no implementation in this pull request. It was read against the React Native package's TextInput, its generated contract, the field family's shared pieces and the platform text box, and against React Native's own
TextInputprops (spellCheckis iOS only;previousis an Android return key). The gap lines state where the package differs from the requirements.Writing rubric results
Rejected:lines.FRn gaplines; "not yet released" appears only in the template's lifecycle field and readiness cell.Scope
Components: TextInput (React Native)
Validation
node scripts/check-knowledge.mjs: knowledge templates and records are aligned; no finding in this record.--checkclean on the record.git diff --check: clean.