Repository navigation
spec(Slider): React Native platform record - #12837
imdreamrunner wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, and two fixes are needed regardless.
The record states new React Native requirements that no current record states, several resting on spec:AST-124, spec:AST-126, spec:AST-130 and the AST-112 amendment, none of which is on main yet; the owner decides whether React Native trades formatValue and the range form for valueText, accessibilityStep and backGesture; whether Android draws the slider instead of using Material 3's; and the drawn slider's disabled look, which uses no opacity. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner.
Required fixes:
- FR2 (line 121) and the Platform control paragraph (lines 198–201) always draw the slider on Android because "the native slider has no Android host", which contradicts
spec:AST-093FR2 andspec:AST-082FR11 while Open questions reads "None.", so either name Material 3's slider and why it does not fit, or state the departure and carryspec:AST-126OQ2 here as an open question. - FR5 (line 124) gives a touch that starts off the thumb and moves to the scrolling parent, while FR6 (line 125) and DEC-3 give every drag along the track to the slider, so scope FR6 and DEC-3 to drags that start on the thumb, or limit FR5's handoff to movement across the track.
Smaller points: label the AR2 gap against a keyboard requirement this record states, add a largest-text-size check for AR5, say why React Native drops formatValue instead of keeping it beside valueText, record the disabled look as a React Native decision, and cite a record for MediaScrubber.
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim: the pull request is stacked on the React Native platform-records tooling change. Verified: the base branch is that change's head.
- Claim: the cited records and clauses exist as described (Slider FR1–FR7 and AR1, AST-082 FR3, FR4 and FR7, AST-093 FR2–FR4, AST-126 FR2, FR4, FR9 and FR11–FR14, AST-124 FR3, AST-130 FR6, AST-112 FR21). Verified, but AST-124, AST-126, AST-130 and AST-112 FR21 are still open drafts.
- Claim: the Decision bullets describe the record. Verified.
- Claim: rubric R5 (no pull request references) and R7 ("not yet released" only in template fields). Verified.
- Claim: rubric R6 (Open questions reads "None."). Literally true, but it leaves out the Android question (first required fix).
- Claim: the public text holds no internal context. Verified over the added lines, title, body, branch and commit message.
- Claim: the knowledge check passes, Prettier is clean, and the whitespace check is clean. Verified at this head.
- Claim: the other open React Native records do not cover a slider, and no Slider React Native record exists. Not checked.
- File:
docs/specs/components/Slider/Slider.react-native.spec.md. Two required fixes and five smaller points, above.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, and two fixes are needed regardless.
The record states React Native requirements that no current record states, several resting on the AST-124, AST-126, AST-130 and AST-112 drafts; an engineering owner decides React Native's props (valueText, accessibilityStep and backGesture in place of formatValue and the range form), the drawn slider on Android (OQ1) and the disabled look without opacity, and records the decision by commenting /approve-spec <full head SHA> on this pull request, which the author may do as an engineering owner. The Android departure, the touch ownership along the track, the keyboard requirement and the largest-text check raised last time are fixed.
Required fixes:
- Miss: FR1 (line 120) lists React Native's props without
render, which FR2, ORD4 and the FR2 verification row require, so addrender(auto,system,drawn; defaultauto) to FR1 and the Public contract row. - Miss: FR5 (line 124) fires
onChangeEnd"when the drag is released", which the gap lines (65–70) call a gap against core's coast and rendered-value rules, so state the lift, the coast and the rendered value in FR5 and its verification row, or record that React Native does not coast and drop those gap lines.
Smaller points: name the value display in the iOS representative state (a miss, line 141), say why React Native drops formatValue instead of keeping it beside valueText, record the disabled look as a React Native decision, cite a record for MediaScrubber, add AST-126 FR13 and AST-112 FR15 and FR21 to the governing rules, and test the off-thumb drag along the track under FR6.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the pull request is stacked on the platform-records tooling change and merges after it. Verified: the base branch is that change's head.
- Claim: the record also cites the AST-126, AST-124 and AST-130 drafts and the AST-112 amendment, whose FR21 defines
renderand the theme'srender.default. Verified: all four are open drafts, and FR21 andrender.defaultare in the amendment. - Claim: Slider's core record covers its parts,
onChangeEnd's value, the drag by travel and the keyboard model, with no React Native rendering. Verified. - Claim: the cited AST-082, AST-093, AST-126, AST-124 and AST-130 clauses say what the record uses them for. Verified, but FR1 leaves out the
renderprop that AST-126 FR2 gives Slider (first required fix). - Claim: the open React Native records for TopNav, TabBar, FileInput and Item do not cover a slider, and no other Slider React Native record or pull request exists. Verified from their titles and a title search.
- Claim: the Decision bullets describe the record. Verified, but FR5's text and its gap lines disagree on when
onChangeEndfires (second required fix). - Claim: the implementation lives outside this repository. Verified: the native package says its React Native binding is not built.
- Claim: rubric R1 to R7 (no narration, no Rejected lines, no pull request references, OQ1 keeps its options, status wording only in template fields). Verified.
- Claim: the public text holds no internal context. Verified over the added lines, both commits, the title, the body and the branch.
- Claim: the knowledge check, Prettier and the whitespace check pass. Verified at this head.
- File:
docs/specs/components/Slider/Slider.react-native.spec.md. Two required fixes and six smaller points, above.
…and rendered value
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, and one fix is needed regardless.
The record states React Native requirements that no current record states, several resting on the AST-124, AST-126, AST-130 and AST-112 drafts; an engineering owner decides React Native's props (valueText, accessibilityStep, backGesture and render in place of formatValue and the range form), the drawn slider on Android (OQ1) and the disabled look without opacity, and records the decision by commenting /approve-spec <full head SHA> on this pull request, which the author may do as an engineering owner. The two fixes raised last time, render in FR1 and onChangeEnd after the coast with the rendered value in FR5, are made.
Required fix:
- FR5 (line 124) lifts and settles the drawn thumb on "the theme's springs", but AST-108 gives a theme only its motion knobs and keeps spring roles internal, and Theme values read (lines 211–216) lists no motion, which AST-093 FR4 requires, so name core's
springs.sliderLift,springs.sliderDropandsprings.sliderReleaseand the theme's motion knobs that shape them, and list those knobs in Theme values read.
Smaller points: say why React Native drops formatValue instead of keeping it beside valueText, record the disabled look as a React Native decision, and cite a record for MediaScrubber.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the pull request is stacked on the platform-records tooling change and merges after it. Verified: the base branch is that change's head.
- Claim: the record also cites the AST-126, AST-124 and AST-130 drafts and the AST-112 amendment, whose FR21 defines
renderand the theme'srender.default. Verified: all four are open drafts, and FR21 andrender.defaultare in the amendment. - Claim: the drawn drag, the value's words and the screen-reader step are stated in the record itself. Verified in FR5, FR4 with ORD2, and ORD3 with AR2.
- Claim: Slider's core record covers its parts and targets,
onChangeEnd's value, the drag by travel and the keyboard model, with no React Native rendering. Verified. - Claim: the cited AST-082, AST-093, AST-126, AST-124 and AST-130 clauses and the Field and FieldStatus records say what the record uses them for. Verified.
- Claim: the open React Native records for TopNav, TabBar, FileInput and Item do not cover a slider, and no other Slider React Native record or pull request exists. Verified from their titles and a title search.
- Claim: the Decision bullets describe the record, including
renderin the props and the drawn drag's lift, coast and rendered value. Verified, but FR5 takes that motion from theme springs (the required fix). - Claim: the gap lines list where today's React Native slider differs. Verified: each names its clause and the mismatch.
- Claim: the implementation lives outside this repository. Verified: the native package says its React Native binding is not built.
- Claim: rubric R1 to R7 (no narration, no Rejected lines, no pull request references, OQ1 keeps its options, status wording only in template fields). Verified.
- Claim: the public text holds no internal context. Verified over the added lines, all three commits, the title, the body and the branch.
- Claim: the knowledge check, Prettier and the whitespace check pass. Verified at this head.
- File:
docs/specs/components/Slider/Slider.react-native.spec.md. One required fix and three smaller points, above.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record; nothing else blocks it.
The record states React Native requirements that no current record states, several resting on the AST-124, AST-126, AST-130 and AST-112 drafts: an engineering owner decides React Native's props (valueText, accessibilityStep, backGesture and render in place of formatValue and the range form), the drawn slider on Android (OQ1) and the disabled look without opacity, and records the decision by commenting /approve-spec <full head SHA> on this pull request, which the author may do as an engineering owner. The fix raised last time is made: FR5 now names core's slider springs, shaped by the theme's tempo and character, and Theme values read lists the motion knobs.
Smaller points, none blocking: say in FR5 that a theme whose reducedMotion is 'always' drops the lift, rather than listing reducedMotion among the knobs that shape the springs (line 216); say why React Native drops formatValue instead of keeping it beside valueText; record the disabled look as a React Native decision; and cite a record for MediaScrubber.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the pull request is stacked on the platform-records tooling change and merges after it. Verified: the base branch is that change's head.
- Claim: the record also cites the AST-126, AST-124 and AST-130 drafts and the AST-112 amendment, whose FR21 defines
renderand the theme'srender.default. Verified: all four are open drafts, and FR21 andrender.defaultare in the amendment. - Claim: the drawn drag, the value's words and the screen-reader step are stated in the record itself. Verified in FR5, FR4 with ORD2, and ORD3 with AR2.
- Claim: Slider's core record covers its parts and targets,
onChangeEnd's value, the drag by travel and the keyboard model, with no React Native rendering. Verified. - Claim: the cited AST-082, AST-093, AST-126, AST-124 and AST-130 clauses and the Field and FieldStatus records say what the record uses them for. Verified.
- Claim: the open React Native records for TopNav, TabBar, FileInput and Item do not cover a slider, and no other Slider React Native record or pull request exists. Verified from their titles and a title search.
- Claim: the Decision bullets describe the record, including
renderin the props and the drawn drag's lift, coast and rendered value. Verified; FR5 now takes that motion from core's springs and the theme's motion knobs. - Claim: the gap lines list where today's React Native slider differs. Verified: each names its clause and the mismatch.
- Claim: the implementation lives outside this repository. Verified: the native package says its React Native binding is not built.
- Claim: rubric R1 to R7 (no narration, no Rejected lines, no pull request references, OQ1 keeps its options, status wording only in template fields). Verified.
- Claim: the public text holds no internal context. Verified over the added lines, all four commits, the title, the body and the branch.
- Claim: the knowledge check, Prettier and the whitespace check pass. Verified at this head.
- File:
docs/specs/components/Slider/Slider.react-native.spec.md. No blocking finding; four smaller points, above.
| `color.textPrimary`, `color.textSecondary`, `color.textDisabled`, the light and | ||
| dark ink on the inverted surface, `radius.full`, `radius.inner`, `space.s0_5`, | ||
| `space.s1`, `space.s1_5`, the medium shadow, the label and supporting type, | ||
| the theme's mode, `render.default`, the motion knobs (`tempo`, `character`, `reducedMotion`) that shape the lift, drop and release springs, and the haptic tokens. |
There was a problem hiding this comment.
Non-blocking: reducedMotion does not shape the springs. spec:AST-108 FR1 gives it another job ('always' applies design:reduced-motion DR1–DR3 for everyone), and FR5 (line 124) says only "under Reduce Motion it does not lift", so an implementer keeps the lift under a theme set to 'always'. Suggested: here, "tempo and character, which shape the lift, drop and release springs, and reducedMotion"; in FR5, "under Reduce Motion, or a theme whose reducedMotion is 'always' (spec:AST-108 FR1), it does not lift"; and add spec:AST-108 to system_specs (line 21) beside the other system specs the record cites.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, which adds React Native requirements for Slider (FR1–FR9, AR1–AR6, ORD1–ORD4, PR1, DEC-1–DEC-5) that no current spec states, several of them resting on React Native drafts not yet on main (AST-124, AST-126, AST-130 and the AST-112 amendment). DEC-5 now makes render an iOS-only prop, which the record itself calls a departure from spec:AST-082 FR3 (a prop scoped to one platform never makes an app branch by platform for behavior that could adapt), so an owner either keeps render on Android as draft AST-126 FR2 does or amends AST-082 FR3, because approving this record does not change FR3. An engineering owner records the decision by commenting /approve-spec <full head SHA>, and the author may do so as an engineering owner. Two wording points are not blocking: the Governing rules row (line 36) still ends at DEC-4, and Theme values read (line 221) still lists reducedMotion as shaping the springs, as the earlier inline comment there describes.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the pull request is stacked on the knowledge-tooling pull request and merges after it. Verified: the base branch is that pull request's head, which admits
react-nativerecords. - Claim: the record cites four open drafts (AST-126, AST-124, AST-130 and the AST-112 amendment, whose FR21 defines
render). Verified: all four are open drafts; the amendment's FR21 definesrender. - Claim: React Native keeps core's single-value props, adds
valueText,accessibilityStepandbackGesture, putsrenderin the iOS contract only, and lists the departure from AST-082 FR3 and AST-126 FR2 under Current-state impact. Verified: FR1 (line 124), DEC-5 (lines 302–313), lines 76–79. - Claim: the control follows AST-126 FR2, with the drawn slider on Android and for the shapes UISlider cannot show, and OQ1 carries the Android question. Verified: FR2 (line 125), ORD4 (line 164), lines 208–214, OQ1 (lines 317–321).
- Claim: the drawn slider draws core's parts from theme tokens, shows the value in a bubble or beside the label, drags by travel with core's lift, coast and rendered
onChangeEndvalue, and sets a tapped value on lift. Verified: FR3–FR5 (lines 126–128). - Claim: a drag along the track is the slider's,
backGesturehands the back direction over, an off-thumb drag changes nothing and a drag across the track reaches a scroller. Verified: FR5, FR6 (lines 128–129), DEC-3. - Claim: the ends play
edgeand detents playselect. Verified: FR7 (line 130), DEC-4. - Claim: screen readers get one adjustable element named, valued and stepped as described, and a hardware keyboard steps it by core's key model. Verified: AR1–AR6 (lines 176–195).
- Claim: gap lines name where today's slider differs (no
render, theonChangeEndvalue, no lift or coast, a render per move, the second back-swipe prop, no key handling). Verified: lines 61–82. - Claim: no rejected alternatives are recorded, the record has no pull request or issue references, and "not yet released" appears only in the lifecycle field and readiness cell. Verified: lines 34 and 51; no such references.
- Claim: no other Slider React Native record or pull request exists, and the four named React Native records cover other components. Verified: repository search; the four are open drafts for TopNav, TabBar, FileInput and Item.
- Claim: the knowledge check, Prettier and the whitespace check pass. Verified: all three re-run clean at this head.
- File
docs/specs/components/Slider/Slider.react-native.spec.md: two non-blocking wording points (lines 36 and 221); DEC-5 and the rest of the draft wait on an owner decision.
| `backGesture="always"`, which it ignores when `backGesture` is set. | ||
| - `spec:AST-082` FR3 departure: `render` is in the iOS contract only (DEC-5), | ||
| where FR3 keeps a prop on every platform that has an honest behavior for it; | ||
| code shared by iOS and Android sets `render` under the iOS condition. |
There was a problem hiding this comment.
This line says code shared by iOS and Android sets render under the iOS condition. spec:AST-082 FR3 scopes a prop to one platform only when no honest behavior exists on that language's other platforms, and says such a prop never makes an app branch by platform for behavior that could adapt; draft spec:AST-126 FR2 already gives Slider render on Android, where every value draws the Astryx slider. Approval waits on an engineering owner choosing between keeping render on Android (dropping DEC-5 and this line) and amending AST-082 FR3; an /approve-spec on this record alone does not change FR3.
| | Builder impact | A builder passes the value's words with `valueText` instead of a formatter, and a coarser screen-reader step with `accessibilityStep` where one step per swipe is too fine. A range slider has no React Native form. | | ||
| | Compatibility/readiness | Not yet released; additive. Draft. Where the slider differs from this record or `component:Slider`, a gap line under Current-state impact says so. | | ||
| | Review checks | Reject a thumb that jumps to the finger, a value change on a press that never moved, a swipe across the track that does not reach the scroller, a visual value not from the theme, opacity for the disabled look, a screen-reader step that ignores `accessibilityStep`, words read in place of `valueText`, or a prop the slider accepts and ignores. | | ||
| | Governing rules | `component:Slider` FR1, FR4, FR5, FR7 and AR1; `spec:AST-126` FR2, FR4, FR9, FR11–FR14; `spec:AST-112` FR15, FR21; `spec:AST-124` FR3; `spec:AST-130` FR6; `spec:AST-082` FR3, FR4, FR7, FR11; `spec:AST-093` FR2–FR4; DEC-1–DEC-4 below. | |
There was a problem hiding this comment.
Non-blocking: this row ends at "DEC-1–DEC-4 below", but DEC-5 (line 302) now carries FR1, FR2 and ORD4. Suggested: "DEC-1–DEC-5 below".
Stacked on #12592; merges after it.
Merge order: this record also cites
spec:AST-126(#12556),spec:AST-124(#12562),spec:AST-130(#12553) and the AST-112 amendment (#12563), whose FR21 definesrenderand the theme'srender.default. It merges after those too. The rules it uses most (the drawn drag, the value's words, the screen-reader step) are stated in the record itself.Exact decision needed
How React Native runs Slider: its props and the props it adds, which control shows it (UISlider or the drawn slider), the drawn slider's anatomy, drag, drag ownership and haptics, and how it reads to VoiceOver and TalkBack.
Existing authority searched
component:Slider(docs/specs/components/Slider/Slider.spec.md): parts and targets (FR1–FR4),onChangeEnd's value (FR5), the drag by travel (FR7) and the APG keyboard model (AR1); no React Native rendering.spec:AST-126(native controls, open draft): the native slider (UISlider on iOS), howrenderresolves for Slider and which shapes it cannot show (FR2, FR4, FR9, FR11–FR14).spec:AST-124(gestures, open draft): the gesture owner view behind the drawn slider's drag ownership andbackGesture.spec:AST-130(system modules, open draft): haptic kinds and the theme's haptic tokens.spec:AST-082FR3, FR4, FR7 andspec:AST-093FR2–FR4: one name, the portable subset of a wider web type, base props, platform control and theme values.component:Fieldandcomponent:FieldStatus: the label, description and status around the slider.Decision
docs/specs/components/Slider/Slider.react-native.spec.md(component:react-native/Slider,platform_of: component:Slider):Sliderwith core's single-value props (valueis a number, DEC-1) and addsvalueTextandaccessibilityStep(DEC-2),backGesture(DEC-3); the iOS contract addsrender(spec:AST-112FR21,spec:AST-126FR2), and Android, where every value would show the drawn slider, has norender(DEC-5). That departs fromspec:AST-082FR3 and fromspec:AST-126FR2, which offersrenderon both platforms; the record lists the departure under Current-state impact. The range form,formatValueand the web's styling and form props stay in the web contract (FR1).spec:AST-126FR2: UISlider on iOS where it can show the shape, Astryx's drawn slider on Android and for vertical, marked, disabled-reason and tooltip-value shapes (FR2, FR8). Showing the drawn slider on Android departs fromspec:AST-082FR11; OQ1 carriesspec:AST-126OQ2 (Material 3's slider as an Android host, or the drawn slider).onChangeEnd's rendered value from core's FR5 and FR7; a tap on the track sets the value on lift (FR3–FR5).backGesturehands the back direction over; one that starts off the thumb changes nothing, and a drag across the track goes to a scrolling parent (FR5, FR6, DEC-3).edgehaptic and detents (marks, or each step of a slider with at most ten steps) playselect(FR7, DEC-4).valueTextor the number, adjusted byaccessibilitySteporstep; a hardware keyboard steps it as core's key model says (AR1–AR6).component:Slidertoday, a gap line under Current-state impact says so: norenderprop (the theme's and the app's presentation choice instead),onChangeEnd's value, no lift or coast, a render per move, theisBackSwipeAllowedsecond prop, and no key handling of its own (AR6).Rejected alternatives
None recorded in the record.
Claim scope and non-goals
The record covers only what React Native adds to
component:Slideror does differently. The native slider, gesture views, haptic kinds and the field around the slider stay with their owners, which the record's ownership lines name.Evidence and implementation relationship
The record is a specification only and has no implementation in this pull request; the React Native implementation lives outside this repository. The gap lines state where that implementation differs from this record and
component:Slider.Writing rubric results
Rejected:lines.component:Sliderare stated asFRn gapandARn gaplines; "not yet released" appears only in the template's lifecycle field and readiness cell.Scope
Components: Slider (React Native)
Validation
node scripts/check-knowledge.mjs: knowledge templates and records are aligned; no finding in this record.--checkclean on the record.git diff --check: clean.