Repository navigation
spec(TabList): React Native platform record - #12863
imdreamrunner wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, and three fixes are needed whatever that decision is.
Needs fixing:
- The basis cells for FR1–FR5 and the Governing rules cell cite clauses that do not state those requirements (
component:TabListFR2 and FR3–FR4,spec:AST-082FR5), and Governing rules also listsspec:AST-130FR6, which is not onmain, andspec:AST-093OQ1, which is an open question. - The record makes itself the owner of the tab indicator and drops it under a "stacked" tab, while
component:Tabowns the indicator (FR7 draws it under every selected tab) and no record defines a stacked tab, so name this collision for the owner or move the stacked look to where a tab's look is owned. - The description lists
component:TabBaras current, but that record is a draft onmain.
Owner decision: the record adds requirements no current record states, so an engineering owner records the decision by commenting /approve-spec with the full head commit SHA, which the author may do as an engineering owner, or asks for amendments. What must be settled: overflow="menu" as a React Native-only value of a core prop, the strip always reading as tabs with role left to the web, the haptic that depends on spec:AST-130, and the Android rules while spec:AST-093 leaves Android guidance open.
Non-blocking: FR7 should say whether tabs in More and TabMenu parts count toward a tab's place, and the FR3/FR4 verification row should limit "a fill strip that scrolls" to auto.
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim: the record is stacked on the pull request that adds the React Native platform language — verified (this pull request's base adds it;
mainaccepts only Swift records). - Claim: the selection haptic cites the open system-modules record — verified (that record is still an open draft and not on
main). - Claim: TabList's current record covers only the edge geometry and the edge alias — verified.
- Claim: the Tab, TabMenu, MoreMenu and container-padding records are current — verified.
- Claim: the TabBar record is current — false (draft).
- Claim: open React Native records exist for TabBar, Button and CheckboxInput, and none for TabList — verified.
- Claim: the cited native-surface and native-guideline clauses are current — verified (the platform-props clause covers props, not platform-only values).
- Claim: the Decision bullets describe the record — verified.
- Claim: the writing rubric finds no narration, research, pull request references, open questions or project status — verified; "every basis cell names records and claims" is true as worded, but see the basis finding.
- Claim: the pull request holds specification records only and no internal context — verified.
- Claim: every ownership collision is resolved or called out — false (the indicator).
- Claim: the knowledge check, Prettier and the whitespace check pass — verified.
- File:
docs/specs/components/TabList/TabList.react-native.spec.md— two findings (basis cells, indicator ownership) and two non-blocking notes.
…that state each rule; place words counted
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, and the fixes below are needed whatever that decision is.
Needs fixing:
- FR2's basis cites the native-surfaces rule that a platform never changes the meaning of a core prop (
spec:AST-082FR3), which does not support a React Native-onlyoverflowvalue, so its basis should beDEC-2 (proposal)alone. - FR5's basis cites
component:TabFR7, which has every tab render its own indicator, for one bar the strip slides between tabs, so mark the slide and the strip-drawn bar as proposal and name that departure from Tab FR7 in a decision. - Miss: FR7's basis cites
component:TabListAR1, which only keepsbleedfrom changing the tab or navigation pattern, and FR9's basis citescomponent:TabList, which states neither the strip's height nor the divider's colour, so cite DEC-1 for FR7 and core's source plus "proposal" for FR9. - The description's rubric line R3 says every basis cell names records and claims, but FR4 and FR6 name only core's docs or a proposal and FR9 names a record without a claim, so reword it.
Owner decision: the record adds requirements no current record states, so an engineering owner records the decision by commenting /approve-spec with the full head commit SHA (the author may do so as an engineering owner), or asks for amendments. What must be settled: overflow="menu" as a React Native-only value of a core prop, the strip always reading as tabs with role left to the web, the haptic that depends on a system-modules record not yet on main, the Android rules while spec:AST-093 leaves Android guidance open, and the stacked tab and strip-drawn indicator that narrow component:Tab FR7.
Non-blocking: drop "open" from the system-modules reference in FR6 and Native pieces, say whether the bar and the haptic cover a selected TabMenu option, and say whether a scrolling strip keeps core's edge fades.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record is stacked on the pull request that adds the React Native platform language and merges after it — verified (this pull request's base is that branch;
mainaccepts only Swift records). - Claim: the selection haptic plays through the haptics module of the open system-modules record — verified (that record is an open draft and not on
main). - Claim: TabList's current record covers the edge geometry and the edge alias, with no React Native rendering — verified.
- Claim: Tab and TabMenu are current, and Tab FR7 owns the indicator, which DEC-4 narrows for stacked tabs for Tab's owner to decide — verified.
- Claim: the TabBar record is a draft on
mainand an open React Native TabBar record exists — verified. - Claim: MoreMenu and container-padding are current — verified.
- Claim: the cited native-surface and native-guideline clauses are current and Android guidelines are an open question — verified.
- Claim: open React Native records exist for Button and CheckboxInput, and none for TabList — verified.
- Claim: the Decision bullets describe the record — verified.
- Claim: no rejected alternatives are recorded — verified.
- Claim: the rubric finds no narration, research, pull request references, open questions or build status — verified; R3's "every basis cell names records and claims" — false (FR4, FR6, FR9).
- Claim: every ownership collision is resolved or called out — false (FR5's strip-drawn bar against Tab FR7).
- Claim: the pull request holds specification records only and no internal context — verified.
- Claim: the knowledge check, Prettier and the whitespace check pass — verified.
- File:
docs/specs/components/TabList/TabList.react-native.spec.md— three blocking basis findings, one description finding, three non-blocking notes.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft React Native TabList record; the basis and description fixes from the last review are all in.
The record adds requirements that no current record states. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, or asks for amendments; the author may do so if they are an engineering owner. What must be settled:
overflow="menu"as a React Native-only value of core'soverflowprop, against the native-surfaces rules that a platform contract never changes the meaning of a core prop and a platform prop never reuses a core prop name.- Dropping
roleon React Native so the strip always reads as tabs (buttons with a selected state on iOS), while core defaults to a navigation landmark and the native-surfaces record keeps accessibility semantics the same on every platform. - The selection haptic, which plays through a system-modules record that has not landed.
- The Android rules (tab roles, Material 3's Tabs page) while Android guidelines are still an open question.
- The stacked tab with no indicator (DEC-4) and the one strip-drawn sliding bar (DEC-5), both departures from Tab's per-tab indicator.
Four non-blocking gaps are noted inline: FR9 and core's divider gap, the strip's own accessible name, where the bar goes when a TabMenu option is selected, and core's edge fades.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record depends on the stacked knowledge-tooling change for its React Native id form — verified:
main's tooling accepts only Swift platform records, and the base adds React Native. - Claim: the selection haptic plays through the system-modules record's haptics module, named without citing a claim — verified (FR6, Native pieces).
- Claim: the authority searched (core TabList's
bleedgeometry andedge/isFullBleed; Tab, TabMenu and MoreMenu current; the bottom tab bar's record draft; the native-surfaces and native-guidelines rules; Android guidelines open) — verified against those records onmain. - Claim: Tab's per-tab indicator collides with DEC-5's strip-drawn bar and DEC-4's stacked tab, left to Tab's owner — verified (DEC-4, DEC-5).
- Claim: each Decision bullet (props with
roleandxstyleweb-only,overflow="menu", scrolling and reveal, the indicator and haptic, tab reading,bleed) — verified against FR1–FR8 and DEC-1–DEC-5. - Claim: no rejected alternatives and no open questions in the record — verified.
- Claim: rubric R1–R7 — verified; every basis cell names its source or says proposal, and "not yet released" appears only in the lifecycle field and the readiness cell.
- Claim: specification records only, one durable decision, owners and collisions named, no internal context — verified (one added record, no internal references).
- Claim: the knowledge check, Prettier and whitespace checks are clean — verified on this head.
- File: the React Native TabList record — four non-blocking gaps (inline); otherwise clear.
| | FR2 | React Native's `overflow` MUST add `menu` (DEC-2): on a `hug` strip, the tabs that do not fit beside a trailing More button move, from the end, into that button's menu, where choosing one selects it; the selected tab always stays in the row, and a `TabMenu` part never moves. Each tab returns to the row when it fits again. On a `fill` strip the tabs share the width and nothing moves; a development build warns once. `menu` is a value of React Native's contract only. | DEC-2 (proposal) | verify | | ||
| | FR3 | With `overflow="auto"`, a `hug` strip MUST scroll sideways when its tabs do not fit, with no scroll indicator, and a `fill` strip keeps to its width, its tabs sharing it equally and their labels truncating. `scroll` always scrolls, and `visible` lets the tabs spill out of the strip, as core's values say. A scrolling strip shows no arrow controls: under a finger a swipe reaches every tab. | `component:TabList` FR2 (overflow controls and scroll access preserved); core TabList's documented `overflow` values; proposal for the rest | verify | | ||
| | FR4 | A scrolling strip MUST keep the selected tab in view: a new selection slides it into view, and mounting, a new viewport width or a selected tab past the edge on mount places it there at once. In right-to-left, the strip starts at the right edge and every offset counts from the logical start. | core TabList's documented scroll-into-view; proposal | verify | | ||
| | FR5 | The strip MUST draw the selected tab's indicator as one bar, `color.accent` in core's height with fully rounded ends, that slides from the previous tab to the new one on the theme's motion, on the UI thread (DEC-5); under Reduce Motion it moves at once. In right-to-left it runs from the logical start. A stacked tab, drawn with its icon above its label because it is a `fill` tab with an icon, shows no indicator (DEC-4). | DEC-4, DEC-5 (proposal) | verify | |
There was a problem hiding this comment.
Non-blocking: component:TabMenu FR2 has the trigger show the selected indicator when one of its options is selected. With DEC-5 the strip draws the only bar, so say whether the bar slides to a TabMenu trigger whose option is selected, and (in FR6) whether choosing a TabMenu option plays the select haptic.
| | FR4 | A scrolling strip MUST keep the selected tab in view: a new selection slides it into view, and mounting, a new viewport width or a selected tab past the edge on mount places it there at once. In right-to-left, the strip starts at the right edge and every offset counts from the logical start. | core TabList's documented scroll-into-view; proposal | verify | | ||
| | FR5 | The strip MUST draw the selected tab's indicator as one bar, `color.accent` in core's height with fully rounded ends, that slides from the previous tab to the new one on the theme's motion, on the UI thread (DEC-5); under Reduce Motion it moves at once. In right-to-left it runs from the logical start. A stacked tab, drawn with its icon above its label because it is a `fill` tab with an icon, shows no indicator (DEC-4). | DEC-4, DEC-5 (proposal) | verify | | ||
| | FR6 | A new selection by a press or by the More menu MUST call `onChange` once with the new value and play the theme's `select` haptic, through the system-modules record's haptics module (`AstryxHaptics`); choosing the selected tab again plays nothing. | proposal; the system-modules record's haptics module | verify | | ||
| | FR7 | The strip MUST read as a tab list of tabs that each expose their selected state and their place among the tabs ("2 of 3") as words in their value, one catalog message for the place, counting every `Tab` in the strip, those in More included, and no `TabMenu` part. On Android the strip has the tab list role and each tab the tab role. On iOS each tab is a button with its selected state and the strip carries no trait, because UIKit's tab-bar trait treats a strip's tabs unevenly (DEC-3). The strip has no navigation landmark: React Native has none. | `component:Tab`; `architecture:internationalization` INV1a; DEC-1, DEC-3 | verify | |
There was a problem hiding this comment.
Non-blocking. Miss: core names the strip with the catalog message @astryx.tabList.label ("Tabs") unless the caller labels it, and spec:AST-082 FR3 keeps a component's name the same on every platform. FR7 and DEC-3 do not say whether the strip keeps that name on React Native, or where iOS reads it when the strip carries no trait. State it beside the role ruling.
| | FR6 | A new selection by a press or by the More menu MUST call `onChange` once with the new value and play the theme's `select` haptic, through the system-modules record's haptics module (`AstryxHaptics`); choosing the selected tab again plays nothing. | proposal; the system-modules record's haptics module | verify | | ||
| | FR7 | The strip MUST read as a tab list of tabs that each expose their selected state and their place among the tabs ("2 of 3") as words in their value, one catalog message for the place, counting every `Tab` in the strip, those in More included, and no `TabMenu` part. On Android the strip has the tab list role and each tab the tab role. On iOS each tab is a button with its selected state and the strip carries no trait, because UIKit's tab-bar trait treats a strip's tabs unevenly (DEC-3). The strip has no navigation landmark: React Native has none. | `component:Tab`; `architecture:internationalization` INV1a; DEC-1, DEC-3 | verify | | ||
| | FR8 | `edge="bleed"` MUST apply core's `bleed` geometry to the React Native stack around the strip: the strip cancels the stack's inline padding, a `hasDivider` rail spans that wider box, and the row pads back by the part of the padding the edge tabs' own padding does not supply, so the edge labels stay on the content line. It never clips a tab, the indicator, the divider or the More button. | `component:TabList` FR1, FR2, AR2; `architecture:container-padding` INV9–INV11 | verify | | ||
| | FR9 | The strip MUST keep its tabs' height, never growing in a parent that stretches it, and `hasDivider` draws a hairline in the theme's border colour under the whole strip. | core TabList's source; proposal | verify | |
There was a problem hiding this comment.
Non-blocking. Miss: the strip "keeps its tabs' height", but core's hasDivider reserves a gap of --spacing-1 plus the border width under the tabs, which grows the strip and drops the selected indicator onto the rail. That is the source this basis cites. Say whether React Native keeps the gap and where the bar sits over the hairline.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft React Native TabList record; no blocking fix is needed.
The record adds requirements that no current record states. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, or asks for amendments; the author may do so if they are an engineering owner. What must be settled:
overflow="menu"as a React Native-only value of core'soverflowprop, against the native-surfaces rules that a platform contract never changes the meaning of a core prop and a platform prop never reuses a core prop name.- Dropping
roleon React Native so the strip always reads as tabs (buttons with a selected state on iOS), while core defaults to a navigation landmark and the native-surfaces record keeps accessibility semantics the same on every platform. - The selection haptic, which plays through a system-modules record that has not landed.
- The Android rules (tab roles, Material 3's Tabs page) while Android guidelines are still an open question.
- The stacked tab with no indicator (DEC-4) and the one strip-drawn sliding bar (DEC-5), both departures from Tab's per-tab indicator.
Five non-blocking gaps are noted inline: the new Current-state impact describes "the package" without naming it, and no React Native code is in this repository to check it against; plus the bar under a TabMenu part, the strip's own accessible name, FR9 and core's divider gap, and core's edge fades.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record depends on the stacked knowledge-tooling change for its React Native id form — verified:
main's tooling accepts only Swift platform records, and the base adds React Native. - Claim: the selection haptic plays through the system-modules record's haptics module, named without citing a claim — verified (FR6, Native pieces).
- Claim: the authority searched (core TabList's
bleedgeometry andedge/isFullBleed; Tab, TabMenu and MoreMenu current; Tab's per-tab indicator against DEC-4 and DEC-5; the bottom tab bar's draft record; the edge vocabulary; the native-surfaces and native-guidelines rules; Android guidelines open) — verified against those records onmain. - Claim: each Decision bullet (props with
roleandxstyleweb-only,overflow="menu", scrolling and reveal, the indicator and haptic, tab reading,bleed) — verified against FR1–FR8 and DEC-1–DEC-5. - Claim: no rejected alternatives, no open questions, and a scope limited to what React Native adds — verified.
- Claim: specification only, with no implementation in this pull request — verified (one added record).
- Claim: the Current-state impact lists where the current package differs (no
edge; the place words) — the section says so, but no React Native package is in this repository, so those differences could not be checked. - Claim: rubric R1–R7 — verified; the gap lines use the requirement-gap form, and "not yet released" appears only in the lifecycle field and the readiness cell.
- Claim: specification records only, one durable decision, owners and collisions named, no internal context — verified.
- Claim: the knowledge check, Prettier and whitespace checks are clean — verified on this head.
- File: the React Native TabList record — five non-blocking gaps (inline); otherwise clear.
| - FR1 gap: the package does not offer `edge`; it takes `isFullBleed` alone. | ||
| - FR8 gap: `edge="bleed"` is not offered, so its geometry applies only through | ||
| `isFullBleed`. | ||
| - FR7 gap: the place words count a `TabMenu` part as a tab, and the `TabMenu` | ||
| part reads a place of its own; under `overflow="menu"` they count the tabs | ||
| left in the row and the More button instead of every `Tab` in the strip. |
There was a problem hiding this comment.
Non-blocking: these gap lines describe "the package", but no React Native TabList is in this repository (the base pull request gives react-native no source root because the repository holds no React Native component code), so a reader or an approving owner cannot check them or see when they stop being true. Name the package by its public name, or drop the section until its code is here. The FR8 line repeats the FR1 line, and core has no edge prop yet either (component:TabList FR3), so one line covers both.
Stacked on #12592; merges after it.
Merge order: none beyond #12592. The selection haptic plays through the haptics module of the open system-modules record (#12553), which the record names without citing a claim.
Exact decision needed
How React Native renders core's TabList: which of core's props it offers and the one
overflowvalue it adds, how the strip scrolls, keeps the selected tab in view and collapses into a More menu, and how the indicator, selection feedback and accessibility behave on a phone.Existing authority searched
component:TabList(docs/specs/components/TabList/TabList.spec.md, current): thebleedgeometry and the canonicaledgeprop with the deprecatedisFullBleedalias this record keeps; no React Native rendering.component:Tabandcomponent:TabMenu(current): the parts the strip holds.component:TabFR7 has every tab render its own indicator; this record's DEC-5 draws one sliding bar on the strip instead and DEC-4 drops it under a stacked tab, a collision the owner ofcomponent:Tabdecides.component:TabBar(draft on main) and the open React Native TabBar record (spec(TabBar): React Native platform record #12686): the app's bottom tab bar, which this record leaves to them.component:MoreMenu(current): the More button and its menu.architecture:container-padding(current): the edge vocabulary.spec:AST-082FR3, FR4, FR7 andspec:AST-093FR2–FR4 (current): which props a platform offers, portable forms, base props and the platform-control rule; Android guidelines are an open question ofspec:AST-093.Decision
docs/specs/components/TabList/TabList.react-native.spec.md(component:react-native/TabList,platform_of: component:TabList):edgeand its deprecatedisFullBleedalias;roleandxstylestay on the web, since React Native has no landmark and always reads the strip as tabs (FR1, DEC-1).overflowaddsmenu: the tabs that do not fit move into a trailing More menu, the selected tab andTabMenuparts stay in the row (FR2, DEC-2).hugstrip scrolls sideways with no arrows and keeps the selected tab in view, sliding on a new selection and jumping on mount or resize; afillstrip shares its width (FR3, FR4).selecthaptic (FR5, FR6).Tab, those in More included; on iOS each tab is a button with its selected state because UIKit's tab-bar trait treats tabs unevenly (FR7, DEC-3).edge="bleed"meets the React Native stack's padding with core's geometry and clips nothing (FR8).Rejected alternatives
None recorded in the record.
Claim scope and non-goals
The record covers only what React Native adds to
component:TabListor does differently. Tabs, menu tabs, the More menu, the bottom tab bar and the edge vocabulary stay with their owners.Evidence and implementation relationship
The record is a specification only and has no implementation in this pull request. Its Current-state impact section lists where the current package differs from the requirements: no
edgeprop (onlyisFullBleed), soedge="bleed"is reached only through the alias (FR1, FR8); and the place words count aTabMenupart as a tab and, underoverflow="menu", the tabs left in the row plus More rather than everyTab(FR7).Writing rubric results
Rejected:lines.FR1,FR7andFR8gap lines under Current-state impact; "not yet released" appears only in the template's lifecycle field and readiness cell.Scope
Components: TabList (React Native)
Validation
node scripts/check-knowledge.mjs(with this branch's knowledge-path tooling): knowledge templates and records are aligned; no finding in this record.--checkclean on the record.git diff --check: clean.