Repository navigation
spec(AST-112): follow-ups after merge - #12974
imdreamrunner wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
Approval waits on two owner steps, and three fixes to the record are needed.
- The edited Decider lines of DEC-11 and DEC-17 to DEC-20 in
spec:AST-112needcixzhang's approval at this head, as an approving review or a/approve-spec <full head SHA>comment, because a record's approval lines change only with the original decider's approval. - The draft requirement edits (FR21's system-drawn button rule and its fallback, DEC-3's reason, the boundary rule and the FR2 verification row) need an engineering owner to comment
/approve-spec <full head SHA>on this pull request; the author may do so as an engineering owner.
Blocking fixes:
- The Current-state impact (
spec.md:758-760) relies onspec:AST-082DEC-2 "as amended", but DEC-2 onmainhas nosurfacesentence yet and the amendment in #12801 givessurfacetwo values that override the theme'smaterialintent rather than FR21's three, so keep the base entry until #12801 lands and then align FR21 with it. - FR21's "the theme's
materialmember decides only drawn surfaces" (spec.md:642-643) narrowsspec:AST-082FR10, which has every native platform realizematerialwith system materials, without a Current-state impact entry, while FR21's own second bullet still saysmaterialdecides how a surface looks. - FR21's new fallback, where the controls record draws the button itself for a
surfacevalue the platform's button cannot show (spec.md:644-646), is missing from the description, which says no requirement is added, and the open controls proposal in #12556 does not state it.
Non-blocking: the second "and" in the boundary rule and FR2 row (spec.md:778, :785) can read as a separate expo item, and the push-notification non-goal now says "out of scope" while DEC-17 still says "for v0".
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim: five Decider lines gain a time and the decision text is unchanged. Verified for the text (only the Decider lines change); one time matches the earlier pull request's description, and the other four need the decider's confirmation.
- Claim: the decider's approval of this head covers those edits. Not given yet.
- Claim: DEC-3 gains its reason. Verified (
spec.md:840-843). - Claim: the impact entry relies on the amended DEC-2 and no other record's text changes. No other record changes (verified); the amendment is not on
main(false today). - Claim: the boundary rule and FR2 row scope the dependency rules. Verified in intent; the wording is ambiguous (non-blocking).
- Claim: FR21 says who decides a system-drawn button's look. Verified; it also adds an unlisted fallback.
- Claim: OQ8 lists every type condition the native surfaces record makes public. Verified against its FR5 and FR6.
- Claim: the non-goals drop release-phase words. Verified; DEC-17 keeps them.
- Claim: only these edits, with no requirement added or removed. False (FR21's fallback).
- Claim: no other open pull request edits the record. Verified across the open record pull requests that mention it.
- Claim: the knowledge check, Prettier and the whitespace check pass. Verified on the head.
- Claim: writing rubric results. Consistent for the changed lines; no status phrases added.
- File
docs/specs/AST-112-react-native-foundation/spec.md: three blocking findings and two non-blocking notes.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on two draft requirement edits; the blocking findings from the earlier review are fixed.
- DEC-3's added reason and the package-boundary rule with the FR2 verification row in
spec:AST-112add requirement text to a draft record, so an engineering owner records the decision by commenting/approve-spec <full head SHA>on this pull request; the author may do so as an engineering owner.
Non-blocking:
- Miss: the boundary rule (
spec.md:776) no longer lists that@astryxdesign/react-native-expotakes no third-party dependency other thanexpo, which FR2 and its verification row state; adding that clause keeps the three lists in step. - Miss: OQ8 now names all five type conditions, but the Current-state impact entry it pairs with (
spec.md:768-774) still names onlyios,androidandshared. - The push-notification non-goal now says "out of scope" while DEC-17 still says "for v0".
Claims and files checked
Review mode: full; reason: spec-record
- Claim: DEC-3 gains the reason Astryx writes its own native code. Verified (
spec.md:838-841). - Claim: the boundary rule and FR2 row scope the dependency rules to the main package and allow
expoas the Expo wrapper's peer. Verified (spec.md:776,:783); the boundary rule also drops the wrapper's other-dependency rule (non-blocking). - Claim: FR21 says the theme's
materialmember decides the look of drawn and system-drawn buttons. Verified (spec.md:642-643), consistent with the native surfaces record's theme intent rule. - Claim: OQ8 lists every public platform type condition and the shared condition. Verified against the native surfaces record.
- Claim: the non-goals drop release-phase words. Verified (
spec.md:45-50); DEC-17 keeps them (non-blocking). - Claim: the DEC-2 citation stays on the base entry. Verified (
spec.md:755-758). - Claim: no requirement, open question or decision is added or removed, and no other record changes. Verified: one file, and the same requirement, question and decision headings as the base.
- Claim: no other open pull request edits this record. Verified across every open pull request that mentions it.
- Claim: the knowledge check, Prettier and the whitespace check pass. Verified on the head.
- Claim: writing rubric results. Consistent with the changed lines; no status phrase added.
- File
docs/specs/AST-112-react-native-foundation/spec.md: no blocking finding; three non-blocking notes.
|
|
||
| - Push notifications and background work are out of scope for v0; apps get | ||
| them from their host platform or a third-party SDK. | ||
| - Push notifications and background work are out of scope; apps get them |
There was a problem hiding this comment.
Non-blocking: this non-goal now reads "out of scope", while DEC-17 still says "out of scope for v0"; an amendment appended after DEC-17's unchanged Decider line can align them.
…tions; the Expo wrapper's dependency rule
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on draft requirement edits to spec:AST-112; the earlier review's notes on the boundary rule and the platform conditions are fixed.
- DEC-3's added reason, the package-boundary rule with the FR2 verification row, and FR20's new sentence on Expo's prebuild add requirement text to a draft record, so an engineering owner records the decision by commenting
/approve-spec <full head SHA>on this pull request; the author may do so as an engineering owner.
Non-blocking:
- The FR20 verification row builds an Expo app but its failure expectation names app-shell pieces missing only from a generated app; adding "or an Expo app" gives the new Expo sentence a failure signal.
- The push-notification non-goal now says "out of scope" while DEC-17 still says "for v0"; an amendment after DEC-17's unchanged Decider line can align them.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: DEC-3 gains the reason Astryx writes its own native code. Verified (
spec.md:841-844). - Claim: the boundary rule and FR2 row scope the dependency rules to the main package, allow only
expoas the Expo wrapper's third-party dependency, and allow it as that package's peer. Verified (spec.md:779,:786). - Claim: FR21 says the theme's
materialmember decides how drawn and system-drawn buttons look. Verified (spec.md:644-645), consistent with the native surfaces record's theme intent rule. - Claim: OQ8 and its impact entry list every public platform type condition and the shared condition. Verified (
spec.md:770-777,:1067-1073) against the native surfaces record. - Claim: the non-goals drop release-phase words. Verified (
spec.md:45-50); DEC-17 keeps them (non-blocking). - Claim: FR20 names what supplies an Expo app's app-shell pieces. Verified (
spec.md:620-626); its verification row lacks the Expo failure case (non-blocking). - Claim: the DEC-2 citation stays on the base entry. Verified (
spec.md:757-760, unchanged). - Claim: no requirement, open question or decision is added or removed, and no other record changes. Verified: one file, and the same requirement, question and decision headings as the base.
- Claim: no other open pull request edits this record. Verified across every other open pull request that mentions it.
- Claim: the record is a specification only, with no implementation here. Verified: the only changed file is the record.
- Claim: the knowledge check, Prettier and the whitespace check pass. Verified on the head.
- Claim: writing rubric results. Consistent with the changed lines; no status phrase added.
- File
docs/specs/AST-112-react-native-foundation/spec.md: no blocking finding; two non-blocking notes.
| generated app's native projects, Expo's prebuild writes them into an Expo | ||
| app's projects through `@astryxdesign/react-native-expo`'s configuration | ||
| plugin (FR11), and an app with its own native projects keeps its own |
There was a problem hiding this comment.
Non-blocking: this sentence puts an Expo app's app-shell pieces on the prebuild path, but the FR20 verification row's failure expectation names shell pieces only "in an app with its own native projects or missing from a generated app", while its own Verification column treats a generated app and an Expo app as two kinds. Suggested: "... or missing from a generated app or an Expo app", so an Expo app without the lifecycle calls fails the row.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on draft requirement edits to spec:AST-112, and one description fix is needed.
- Regression: the description says no other open pull request edits
spec:AST-112, but #12998, opened since the last review, edits the same record, so the description should name it and say the two edits touch separate sections.
The draft edits waiting on an owner are the removal of the render rule (FR21, FR5's platform-prop sentence, the FR21 gap, the two proposed spec:AST-082 amendments and the render captures), DEC-3's added reason, the package-boundary rule with the FR2 verification row, and FR20's Expo prebuild sentence. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner. Non-blocking: FR21 still asks for drawn and system-drawn buttons, but with render gone nothing says which is which (inline note), and the earlier notes on the FR20 verification row and DEC-17's "v0" still stand.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record merged as a draft before this change: verified.
- Claim: the citation of the native-surfaces record's DEC-2 stays on its existing entry: verified, the entry is unchanged.
- Claim: DEC-3 gains its reason in neutral words: verified in the record's DEC-3.
- Claim: the
renderrule leaves the record and FR21 keeps everysurfaceandmaterialstatement: verified. - Claim: the boundary rule and the FR2 verification row scope the dependency rules to each package: verified.
- Claim: FR21 says the theme's
materialdecides drawn and system-drawn buttons: verified. - Claim: OQ8 and its Current-state impact entry list every public type condition: verified.
- Claim: the non-goals drop the release-phase words: verified.
- Claim: FR20 names Expo's prebuild as the path for an Expo app's shell pieces: verified.
- Claim: no requirement, open question or decision is added, and no other record changes: verified.
- Claim: no other open pull request edits the record, and overlapping open work is named: false, #12998 edits it.
- Claim: the writing rubric results hold: verified.
- Claim: the knowledge check, Prettier and the whitespace check pass: verified.
- File
docs/specs/AST-112-react-native-foundation/spec.md: one new non-blocking note (FR21 drawn and system-drawn buttons) and two earlier notes still open.
| picks the surface that fits where the button sits. A drawn button draws | ||
| that surface, and a system-drawn button shows it as the platform's | ||
| matching button style. | ||
| matching button style. On both, the native theme's `material` member |
There was a problem hiding this comment.
Non-blocking: with render removed, this bullet and FR21's verification row still want each surface on a drawn and a system-drawn button, but nothing in the record now says which a button is, so the captures cannot be written. FR2 and DEC-9 have the same gap for bars and buttons. Suggested: cite spec:AST-082 FR11 here (the platform's own control where one satisfies the contract, a drawn one only where the platform has none), and say which Button and IconButton cases are system-drawn on each platform.
Follow-up edits to
spec:AST-112after #12563 merged as a draft record. The citation ofspec:AST-082DEC-2 stays on the base DEC-2 entry; it moves to the amended DEC-2, with FR21'ssurfacevalues aligned, only after #12801 merges, in a separate change.Exact decision needed
Whether these follow-up edits to the draft React Native foundation record stand:
Existing authority searched
spec:AST-112onmain(merged as a draft record in spec(AST-112): React Native commands are one astryx rn group; package shape (Expo wrapper, default linking, named features) #12563), and the last automated review's non-blocking notes on that pull request.spec:AST-082DEC-2 onmain; the open amendment docs(spec): Button and IconButton take a surface prop for glass on native; other native looks stay theme intent #12801 (Button and IconButton take asurfaceprop) is not cited until it merges.architecture:knowledge-contractsINV32 (no release phases in records).AST-112,surface,v0,macos,windows.spec:AST-112runtime boundaries, open draft) edits the same record in separate sections (DEC-10, FR3, FR4, FR5, FR11, Platform support, the verification rows it adds, and new DEC-21 and DEC-22); neither pull request edits text the other changes.Decision
docs/specs/AST-112-react-native-foundation/spec.md(spec:AST-112):renderrule is removed from the record; FR21, now "Glass and materials are a look", keeps everysurfaceandmaterialstatement.@astryxdesign/react-native, no third-party dependency of@astryxdesign/react-native-expoother thanexpo, and the only peers outside Astryx are React, React Native and, for@astryxdesign/react-native-expo,expo.surfaceas the platform's matching button style, and on drawn and system-drawn buttons alike the native theme'smaterialmember decides how the surface looks (spec:AST-082FR10).spec:AST-082FR5's public type conditions (ios,android,macos,windows) and FR6'ssharedcondition.@astryxdesign/react-native-expo's configuration plugin (FR11), besideastryx rn shellfor a generated app and an app's own native projects.Rejected alternatives
None recorded in the record.
Claim scope and non-goals
Only the edits above. No requirement, open question or decision is added, and no other record changes.
Evidence and implementation relationship
The record is a specification only and has no implementation in this pull request.
Writing rubric results
Rejected:lines.Scope
Validation
node scripts/check-knowledge.mjs: knowledge templates and records are aligned (exit 0).--checkclean on the record.git diff --check: clean.