Skip to content

chore: land 2 reviewed pull requests together (batch 78) - #12976

Merged
josephfarina merged 6 commits into
mainfrom
josephfarina/land-batch-78
Nov 19, 2026
Merged

josephfarina merged 6 commits into
mainfrom
josephfarina/land-batch-78

Conversation

@josephfarina

@josephfarina josephfarina commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Merges two reviewed pull requests onto current main, each as its own --no-ff merge, in this order. Each member keeps its own description, tests and review history, and each record edit below has an engineering owner's /approve-spec on its member and at this branch's head.

Scope

Release notes: two accessibility fixes' Changesets name the old behavior and their WCAG 2.2 target (SC 4.1.2), as AST-017 FR53 asks (#12967).

CLI search docs: two packages' docs sections of one title both stay, unless an authored id addresses one; a later colliding section reads as <provider key>-<title key> (#12900).

Records

Writing rubric results

Each member's record lines are scored in its own description: present tense, no change references, research or project status; verification rows name tests.

When this merges, each pull request above is closed with a note that names this one.

…he old behavior

The release notes of the Item aria-current move and the MultiSelector
trigger's aria-required removal now name the behavior they replace and
the accessibility target they serve (WCAG 2.2 SC 4.1.2), as AST-017 FR53
asks of an accessibility behavior fix.

[skip ci]
…r package's section of the same title

Across packages, a section replaces another only when one carries an
authored id that is the other's key; a title, or two keys titles
derive, never match. Of two packages' sections whose titles derive one
key, the one placed later is read by its provider key, a hyphen, and
its title key. Search hides an experimental extension's sections by
provider and key. AST-046 FR11 states the rule.

[skip ci]
@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 19, 2026 9:59pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2026
@astracat-bot

astracat-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 19, 2026, 10:10 PM UTC

@github-actions github-actions Bot added the needs:spec-owner-review Current knowledge records await owner approval label Nov 19, 2026
@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 13d5b47
Covers component:Table FR25 (#12941, HQ ruling), and the doctor and README records as #12886 and #12887 state them.

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 13d5b47

@josephfarina

Copy link
Copy Markdown
Contributor Author

Owner decision (engineering owner, recorded for this batch and #12941): Table's default cell renderer shows an invalid Date (one whose time is NaN) as an empty cell, the same as null and undefined, instead of the text "Invalid Date". This is the display half of the rule decided on #12921, where useTableSortableState sorts an invalid Date with the missing values. No other value's display changes.

@github-actions github-actions Bot removed the needs:spec-owner-review Current knowledge records await owner approval label Nov 19, 2026

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested: one fix is needed before this batch can merge. The other four changes have no findings.

  • component:Table FR25 says a column without renderCell shows an Invalid Date as an empty cell and a valid date as ISO text, but in a tree table with expandable rows the tree column still prints Invalid Date (and a valid date as Date.toString() text) through its own String(value ?? '') fallback in packages/core/src/Table/plugins/tree/useTableTreeData.tsx (lines 706-714), and no test covers it: render that fallback with defaultCellRenderer(item, col.key) and add a tree-table test, or narrow FR25 and its verification row to the flat columns and approve the record again.

Optional: the isInvalidDate comment wording (inline), and the globals.css setups in astryx docs styling-overview, which still leave out the fonts.css import the README now adds.

Claims and files checked

Review mode: full; reason: no-earlier-review

  • Description, five reviewed pull requests merged onto main as separate merges in the stated order: verified (five clean merges in that order, each at its pull request's current head).
  • Description, the README and doctor pull requests form a stack: verified (both carry the same Stack line, and the doctor head contains the README head).
  • Description, each record edit has an engineering owner's approval on its member and at this head: verified (the Table record change is approved on its member's head and on this head).
  • Description and changesets, the two accessibility notes name the old behavior and WCAG 2.2 SC 4.1.2: verified (.changeset/item-current-on-focus-target.md:5, .changeset/multiselector-search-required.md:5; the earlier fixes moved aria-current off the row root and aria-required off the trigger).
  • Description and changeset, the default cell renderer shows an Invalid Date as an empty cell like null and undefined and no longer throws: verified for the default renderer (columnUtils.ts:296, Table.test.tsx:110-127); false for the tree column of a tree table (blocking finding).
  • Changeset, sorting already treats an Invalid Date as missing: verified (the same check was inline in useTableSortableState.tsx on main).
  • Description, the Table record's new requirement (missing values render empty, never throw, sort last ascending and first descending, renderCell and comparators override): verified for flat columns and the sort (useTableSortableState.tsx:38-44, its NaN, null and Invalid Date tests); false for the tree column (blocking finding).
  • Description and changeset, the StyleX docs name @stylexjs/unplugin for Vite and the template note points to that section: verified (styling-overview.doc.mjs:151-155, tokens-and-setup.doc.mjs:90-91, template-needs.mjs:480); the Rollup plugin's failure under Vite was not reproduced in this review.
  • Description and changeset, the README's three Next.js boxes import the theme's fonts.css first, as astryx theme add does, and without it the page uses the system font stack: verified (README.md:109, :164, :258; theme add writes the font import; the theme's font tokens end in a system stack).
  • Description and changeset, doctor --built reads a stylesheet that only imports Astryx CSS as wiring and still flags one with its own rules, a @layer block or another package's import: verified (built-checks.mjs:668-700, :800; built-checks.test.mjs:409).
  • Description, no record changes in the release-note and Vite pull requests, and each member scores its record lines in its own description: verified.
  • .changeset/core-readme-theme-fonts.md, .changeset/doctor-setup-stylesheet.md, .changeset/item-current-on-focus-target.md, .changeset/multiselector-search-required.md, .changeset/table-cell-invalid-date.md, .changeset/vite-stylex-plugin-doc.md: clear.
  • docs/specs/components/Table/Table.spec.md: FR25 and its verification row claim more than the tree column does (blocking).
  • packages/cli/api/doctor/_adapter.mjs, built-checks.mjs, built-checks.test.mjs, doctor.doc.mjs: clear.
  • packages/cli/assets/docs/styling-overview.doc.mjs: clear; its globals.css snippet still has no fonts.css (optional).
  • packages/cli/assets/docs/tree/tokens-and-setup.doc.mjs, packages/cli/foundation/discovery/template-needs.mjs, packages/cli/test/__golden__/no-icon-set/docs-topics.json: clear.
  • packages/core/README.md: clear.
  • packages/core/src/Table/Table.test.tsx: clear; no tree-table case (part of the blocking finding).
  • packages/core/src/Table/columnUtils.ts: clear; comment wording (optional).
  • packages/core/src/Table/plugins/sortable/useTableSortableState.tsx: clear.

Automated review (maintainer link)

Comment thread packages/core/src/Table/columnUtils.ts Resolved
@josephfarina josephfarina changed the title chore: land 5 reviewed pull requests together (batch 78) chore: land 4 reviewed pull requests together (batch 78) Nov 19, 2026
@josephfarina
josephfarina force-pushed the josephfarina/land-batch-78 branch from 13d5b47 to 4049a3c Compare November 19, 2026 19:22
@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 4049a3c
Covers the doctor and README records as #12886 and #12887 state them; #12967 and #12893 change no record.

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 4049a3c

…n authored id addresses one

The merge and the section-key check share one title-fragment test.
AST-046 FR11 uses the record's term "title fragment", states the
retitled-section match, and the changeset names the case-variant key
change.

[skip ci]

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested: one wording fix in the Core README font note is needed before this batch can merge. The doctor, StyleX Vite docs and release-note changes have no findings.

  • Regression: packages/core/README.md (line 115) says the theme's fonts.css holds a remote @import and that leaving it out avoids external font requests, and .changeset/core-readme-theme-fonts.md says it goes first "so bundlers keep its font @import", but since main started shipping each built-in theme's fonts inside the package, every theme's fonts.css is local @font-face rules with no @import and no network request, so replace those two README sentences with "fonts.css declares the theme's font faces from font files the package ships. Without it the page falls back to the system font stack." and drop the @import clause from the Changeset.

Optional: the globals.css boxes in astryx docs styling-overview still leave out the fonts.css import the README now adds.

Claims and files checked

Review mode: full; reason: history

  • Description, four reviewed pull requests merged onto current main as separate merges in the stated order: verified (four merges in that order, each at its pull request's current head).
  • Description, the README and doctor pull requests form a stack: verified (both carry the same Stack line, and the doctor head sits on the README head).
  • Description, each record edit has an engineering owner's approval on its member and at this head: no knowledge record changes at this head, so none needs one; approvals are present on both stacked members and on this head.
  • Description, no record changes in the release-note and Vite pull requests: verified.
  • Description, the doctor and README records as the two stacked pull requests state them: neither pull request changes or states a record.
  • Description, each member scores its record lines in its own description: no member has record lines to score.
  • Description and Changesets, the two accessibility notes name the old behavior and WCAG 2.2 SC 4.1.2: verified (.changeset/item-current-on-focus-target.md:5, .changeset/multiselector-search-required.md:5; the earlier fixes moved aria-current to the focus target and removed the trigger's aria-required).
  • Description and Changeset, the StyleX docs name @stylexjs/unplugin (stylex.vite()) for Vite and the template note points to that section: verified (styling-overview.doc.mjs:151-155, tokens-and-setup.doc.mjs:90-91, template-needs.mjs:480); the Rollup plugin's failure under Vite was not reproduced.
  • Changeset, the README's three Next.js boxes import fonts.css as astryx theme add does: verified (README.md:109, :164, :258; theme add writes the font stylesheet import).
  • Changeset, fonts.css goes first so bundlers keep its font @import: false (blocking finding).
  • Changeset, before this a page set up from those boxes fell back to the system font stack: verified.
  • Description and Changeset, doctor --built reads a stylesheet that only imports Astryx CSS as wiring and still flags one with its own rules, a @layer block or another package's import: verified (built-checks.mjs:657-688, :797-801; the new case at built-checks.test.mjs:409 passes here and fails without the change).
  • Description, each member is closed with a note when this merges: a merge-time step, not checkable in the code.
  • .changeset/core-readme-theme-fonts.md: false @import clause (blocking).
  • .changeset/doctor-setup-stylesheet.md, .changeset/item-current-on-focus-target.md, .changeset/multiselector-search-required.md, .changeset/vite-stylex-plugin-doc.md: clear.
  • packages/cli/api/doctor/_adapter.mjs, built-checks.mjs, built-checks.test.mjs, doctor.doc.mjs: clear.
  • packages/cli/assets/docs/styling-overview.doc.mjs: clear; its globals.css boxes still have no fonts.css (optional).
  • packages/cli/assets/docs/tree/tokens-and-setup.doc.mjs, packages/cli/foundation/discovery/template-needs.mjs, packages/cli/test/__golden__/no-icon-set/docs-topics.json: clear.
  • packages/core/README.md: the fonts.css explanation on line 115 is false at this head (blocking).

Automated review (maintainer link)

Comment thread packages/core/README.md Resolved
Comment thread .changeset/core-readme-theme-fonts.md Resolved
@josephfarina josephfarina changed the title chore: land 4 reviewed pull requests together (batch 78) chore: land 2 reviewed pull requests together (batch 78) Nov 19, 2026
@josephfarina
josephfarina force-pushed the josephfarina/land-batch-78 branch from 4049a3c to 23ed72e Compare November 19, 2026 19:45
@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 23ed72e

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: CI has not finished on this head yet. Both changes match the rules that govern them and have no blocking findings: the two accessibility release notes now name the behavior they replace and their WCAG target, and the StyleX setup docs name a Vite plugin that loads astryx.css, with the template note pointing at that section.

  • Miss (optional): the Vite cell in packages/cli/assets/docs/styling-overview.doc.mjs (line 153) sets the width of the whole terminal table, so astryx docs styling-overview stylex-own-code pads the other rows with about 480 bytes of spaces; keeping the cell as short as the tokens-and-setup one and moving the Rollup-plugin warning into the prose under the table keeps the warning without the padding.
Claims and files checked

Review mode: full; reason: history

  • Claim (description): two reviewed pull requests are merged onto current main, each as its own merge, release notes first and then the Vite docs: verified; each merge's change equals its member's own patch at that member's current head.
  • Claim (description): every record edit has an engineering owner's spec approval on its member and at this head: no knowledge record changes, so none is needed; an approval at this head is present.
  • Claim (description and Changesets): the two accessibility release notes name the old behavior and WCAG 2.2 SC 4.1.2: verified (.changeset/item-current-on-focus-target.md:5, .changeset/multiselector-search-required.md:5).
  • Claim (Item note): the current marker now sits on the element that takes focus and before sat on the row's root; rows whose root takes focus and non-interactive rows keep it on the root; a selected row keeps data-selected and its fill while travelling: verified (Item.tsx:789-792, :1062, :1070; travelling.stylex.ts:60).
  • Claim (MultiSelector note): the search trigger no longer carries aria-required, which a button may not have, and before it did; the label marker or a hidden "Required" description and the open search box carry the required state, as in Selector: verified (MultiSelector.tsx:2545-2567, :2057; Selector.tsx:2168).
  • Claim (description and Changeset): the StyleX docs name @stylexjs/unplugin (stylex.vite()) for Vite and keep the Rollup plugin for Rollup: verified (styling-overview.doc.mjs:151-155, tokens-and-setup.doc.mjs:90-91).
  • Claim (Changeset): under Vite the Rollup plugin fails on astryx.css, so a StyleX page template stayed blank: supported by both plugins' source (the Rollup plugin runs Babel on any module whose text contains stylex, with no file-type filter, and astryx.css contains such selectors; @stylexjs/unplugin transforms only JavaScript-like files); the end-to-end Vite run was not repeated.
  • Claim (Changeset): the template note points to the setup section: verified (template-needs.mjs:480; the section is at styling-overview.doc.mjs:121).
  • Claim (description): neither pull request changes a record: verified.
  • Claim (description): each member scores its record lines in its own description: no member has record lines.
  • Claim (description): each member pull request is closed when this merges: a step after merge, not checkable at this head.
  • File .changeset/item-current-on-focus-target.md: clear.
  • File .changeset/multiselector-search-required.md: clear.
  • File .changeset/vite-stylex-plugin-doc.md: clear.
  • File packages/cli/assets/docs/styling-overview.doc.mjs: clear (optional note above on the Vite cell's length).
  • File packages/cli/assets/docs/tree/tokens-and-setup.doc.mjs: clear; same Vite and Rollup split as styling-overview.
  • File packages/cli/foundation/discovery/template-needs.mjs: clear; the note's existing test passes.
  • File packages/cli/test/__golden__/no-icon-set/docs-topics.json: clear; regenerated digest, the docs-topics test passes.

Automated review (maintainer link)

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · d3375ca

Storybook · Sandbox · built from this PR's head

Package size: measured; main has no measurement of the merge base to compare yet.

API changes: unknown (base surface unavailable): richtext, theme-chocolate, theme-gothic, theme-stone

Wide change (shared styles: packages/themes/butter/src/butterTheme.ts, packages/themes/matcha/src/matchaTheme.ts, packages/themes/neutral/src/neutralPaletteRefs.generated.ts, and 2 more): add ci:run-visual for Visual, ci:run-a11y for Accessibility, ci:run-rtl for RTL.


Generated by PR Enrichment workflow | View full report

@josephfarina josephfarina changed the title chore: land 2 reviewed pull requests together (batch 78) chore: land 5 reviewed pull requests together (batch 78) Nov 19, 2026
@josephfarina
josephfarina force-pushed the josephfarina/land-batch-78 branch from 23ed72e to d3375ca Compare November 19, 2026 21:01
@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec d3375ca
Covers the theme:butter, theme:neutral and theme:y2k amendments under spec:AST-020 FR1 (#12276, HQ ruling) and spec:AST-046 FR11's three sentences (#12900, Search owner's OK).

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec d3375ca

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested: two text fixes in this pull request's description and release notes. The code, the record amendments and the tests have no blocking findings.

  • The description says each member scores its record lines in its own description, but the themes pull request (#12276) has an empty description, so the theme:butter, theme:neutral and theme:y2k lines have no writing rubric results: add the R1–R7 lines for those three records here or on #12276.
  • .changeset/cli-bundled-themes-pressed-text-contrast.md says the bundled Butter, Neutral, Matcha and Y2K themes' accent text now reads at 4.5:1, but only Butter's accent text changed (the other three change only nav item text): reword it, for example "The bundled Butter theme's accent text and secondary and ghost button labels, and the bundled Butter, Neutral, Matcha and Y2K themes' nav item text, read at 4.5:1 on pressed fills and the accent tint."

The release-note edit is a new commit, so the new head needs a fresh /approve-spec for the record amendments. Still optional from the earlier review: the long Vite cell in styling-overview.doc.mjs widens the whole terminal table.

Claims and files checked

Review mode: full; reason: history

  • Claim (description): five reviewed pull requests merge onto current main, each as its own merge, in the stated order: verified; each merge's change equals that member's own patch at its current head.
  • Claim (description): each member keeps its own description, tests and review history: verified; all five stay open at the merged heads.
  • Claim (description): each record edit has an engineering owner's spec approval on its member and at this head: verified for the themes member, the docs-sections member and this head.
  • Claim (description): a copy of the swizzle-proof fix gives Lab's MediaPlayer a sample with its required label, so the test shards pass on main: verified (samples.mjs:632-641; the samples test passes).
  • Claim (description): two accessibility release notes name the old behavior and their WCAG 2.2 target: verified (both notes, line 5).
  • Claim (description): Butter, Neutral, Matcha and Y2K text reads at 4.5:1 on pressed fills and the accent tint: verified; the contrast guard passes at this head and fails 15 rows on the base themes.
  • Claim (description): the lift rule lives in Core's palette mapping and the CLI engine is regenerated from it: verified (mapping.ts:270, :378; the engine test reports a byte-identical copy).
  • Claim (description): in Butter light, selected and unselected TopNav items share a color and weight marks the selected one: verified; both render #194ce8, at weight 600 for the current page and 500 for the others.
  • Claim (description and release note): two packages' same-title docs sections both stay unless an authored id addresses one, and a later collision reads by a provider-prefixed key: verified; the new CLI test passes at this head and fails on the base.
  • Claim (description and release note): the StyleX docs name the Vite plugin: verified (styling-overview.doc.mjs:151-155, tokens-and-setup.doc.mjs:90-91).
  • Claim (description): the three theme records gain stops and measured ratios under the accessibility baseline, with the guard in their verification lists: verified; each stated ratio equals the guard's measurement.
  • Claim (description): the docs-tree record gains three sentences on cross-package matching: verified.
  • Claim (description): the other three members change no record: verified.
  • Claim (description): each member scores its record lines in its own description: false; the themes member's description is empty.
  • Claim (description): each member is closed when this merges: a step after merge, not checkable at this head.
  • Claim (CLI bundled-themes release note): the four bundled themes' accent and nav item text read at 4.5:1: false in part; only Butter's accent text changed.
  • Claim (theme editor release note): the editor lifts top nav item text on the pressed fill, keeps it on a new accent and moves it on a new neutral: verified (theme-accent-lift.test.mjs, both cases pass).
  • Claim (Item release note): the current marker sits on the focused element and before sat on the root: verified (Item.tsx:782-814).
  • Claim (MultiSelector release note): the search trigger no longer carries the required attribute, as in Selector: verified (useResolvedRequired.ts:136-140, used by both).
  • Claim (Butter release note): accent text, secondary and ghost labels and nav text take accent stop 35, a step deeper than the fill: verified (butterTheme.ts:51, :213, :571, :599; fill at stop 40).
  • Claim (Core palette release note): themePalette() lifts top nav item text on the pressed fill as Neutral does: verified (themePalette.ts:152-159; the drift guard ties the lifted parts to Neutral).
  • Claim (Matcha release note): nav secondary text takes the next stop in light and reads on the pressed fill over the page: verified (4.34:1 to 5.62:1).
  • Claim (Neutral release note): nav secondary text takes the next lighter stop in dark: verified (4.11:1 to 4.79:1 on the surface bar).
  • Claim (Y2K release note): nav secondary text takes the selected-row stop in light: verified (4.29:1 to 5.15:1).
  • Claim (Vite release note): under Vite the Rollup plugin fails on astryx.css, and the template note points to the setup section: the note is verified (template-needs.mjs:480); the Vite failure rests on the member's own reproduction.
  • Files .changeset/cli-bundled-themes-pressed-text-contrast.md: finding above. The other ten .changeset/*.md files: clear.
  • File docs/specs/AST-046-docs-tree/spec.md: clear; the three sentences match the merge and key code.
  • Files packages/cli/api/docs/_adapter.mjs, packages/cli/api/search/_gather-docs.mjs, packages/cli/foundation/discovery/docs-discovery.mjs, docs-section-key.mjs, packages/cli/foundation/doc-compiler/compile.mjs: clear; one contributor value reaches the merge, the key stamp and search.
  • Files packages/cli/clients/cli/commands/docs.package-sections.test.mjs, docs-discovery.test.mjs, docs-section-key.test.mjs, doc-compiler.test.mjs, doc-loads.test.mjs: clear; they pass.
  • Files packages/cli/api/theme-edit/_palette.mjs, theme-accent-lift.test.mjs, theme-contrast-scope-change-carries.test.mjs, theme-palette.test.mjs: clear.
  • File packages/core/src/palette/mapping.ts: clear.
  • Files packages/cli/api/theme/palette/generate/mapping.mjs, the five packages/cli/assets/templates/themes/ copies, packages/themes/neutral/src/neutralPaletteRefs.generated.ts, ButterTheme.swift, docs-topics.json: clear; each regenerates identically.
  • Files packages/themes/butter/src/butterTheme.ts, matcha/src/matchaTheme.ts, neutral/src/neutralTheme.ts, y2k/src/y2kTheme.ts, butter/src/butterTheme.test.ts: clear.
  • Files packages/themes/butter/butter.spec.md, neutral/neutral.spec.md, y2k/y2k.spec.md: clear in content; rubric results missing (finding above).
  • Files scripts/check-text-contrast-by-role.test.mjs, scripts/generate-neutral-palette-refs.test.mjs: clear.
  • Files packages/cli/assets/docs/styling-overview.doc.mjs, tree/tokens-and-setup.doc.mjs, packages/cli/foundation/discovery/template-needs.mjs: clear (optional note on the Vite cell).
  • File packages/cli/test/swizzle-proof/samples.mjs: clear.

Automated review (maintainer link)

@josephfarina josephfarina changed the title chore: land 5 reviewed pull requests together (batch 78) chore: land 3 reviewed pull requests together (batch 78) Nov 19, 2026
@josephfarina
josephfarina force-pushed the josephfarina/land-batch-78 branch from d3375ca to d1842ba Compare November 19, 2026 21:38
@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec d1842ba
Covers spec:AST-046 FR11's three sentences (#12900, Search owner's OK).

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec d1842ba

@github-actions github-actions Bot removed the needs:design-review Affects visuals — Design should review label Nov 19, 2026
@josephfarina josephfarina changed the title chore: land 3 reviewed pull requests together (batch 78) chore: land 2 reviewed pull requests together (batch 78) Nov 19, 2026
@josephfarina
josephfarina force-pushed the josephfarina/land-batch-78 branch from d1842ba to 185d0ee Compare November 19, 2026 21:49
@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 185d0ee
Covers spec:AST-046 FR11's three sentences (#12900, Search owner's OK).

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 185d0ee

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: CI has not finished on this head yet, so this approval does not mean the pull request is ready to merge. Both merged pull requests match the records that govern them and have no blocking findings, and the docs-tree record amendment has an engineering owner's spec approval at this head.

Claims and files checked

Review mode: full; reason: history

  • Claim (description): two reviewed pull requests merge onto main, each as its own merge, in the stated order: verified; each merge's change equals that member's own patch.
  • Claim (description): each member keeps its own description, tests and review history: verified; both stay open.
  • Claim (description): each record edit has an engineering owner's spec approval on its member and at this head: verified, on the docs member's head and on this head.
  • Claim (description): two accessibility release notes name the old behavior and their WCAG 2.2 target, SC 4.1.2, as the release-policy record asks: verified (both notes, line 5).
  • Claim (description): two packages' same-title docs sections both stay unless an authored id addresses one, and a later colliding section reads by a provider-prefixed key: verified; the new CLI tests pass at this head and fail on the base.
  • Claim (description): the docs-tree record gains three sentences on cross-package section matching: verified (three sentences added to its integrations requirement).
  • Claim (description): the release-notes member changes no record: verified.
  • Claim (description): each member's record lines are scored in its own description: verified; the docs member's description carries the seven rubric results, and the release-notes member has no record lines.
  • Claim (description): each member is closed when this merges: a step after merge, not checkable at this head.
  • Claim (CLI release note): two packages that add a section with one title to a docs topic or guide both keep it: verified (docs.package-sections.test.mjs, a topic and a placed guide).
  • Claim (CLI release note): across packages, a section replaces another only when an authored id is the other's key or a fragment of its title: verified (docs-discovery.mjs:980-991; the compiler's id and title pair tests).
  • Claim (CLI release note): a later colliding section reads by a key that starts with its provider key, so reads, the index, namespace reads and search show both: verified (docs-section-key.mjs:250-262; the CLI tests).
  • Claim (CLI release note): a later case-variant title read as install-2 before and now reads by its provider key: verified (the base gives install-2; the head test gives acme-two-install).
  • Claim (CLI release note): every other collision keeps its numeric suffix, and the topic's own sections still take a replacement from any package, the last configured winning: verified (docs-section-key.test.mjs, docs-discovery.test.mjs, the compiler's Props/PROPS case).
  • Claim (Item release note): the current marker sits on the element that takes focus, and before sat on the row's root: verified (Item.tsx:957, :971, :1062; the root carried it before the fix).
  • Claim (Item release note): a selected row keeps data-selected on its root and its fill while it slides: verified (Item.tsx:1070, travelling.stylex.ts:60-70).
  • Claim (MultiSelector release note): the search trigger no longer carries aria-required, which it carried before; its name or a hidden description states the required state, the open search box carries it, and Selector matches: verified (useResolvedRequired.ts:112-145, MultiSelector.tsx:2057, :2545-2567, :2741, Selector.tsx:2180).
  • Files .changeset/docs-package-sections-collide.md, .changeset/item-current-on-focus-target.md, .changeset/multiselector-search-required.md: clear.
  • File docs/specs/AST-046-docs-tree/spec.md: clear; the three sentences match the merge and key code.
  • Files packages/cli/foundation/discovery/docs-discovery.mjs, packages/cli/foundation/discovery/docs-section-key.mjs, packages/cli/foundation/doc-compiler/compile.mjs, packages/cli/api/docs/_adapter.mjs, packages/cli/api/search/_gather-docs.mjs: clear; one contributor value reaches the merge, the key stamp, the doctor check and search.
  • Files packages/cli/clients/cli/commands/docs.package-sections.test.mjs, packages/cli/foundation/discovery/docs-discovery.test.mjs, packages/cli/foundation/discovery/docs-section-key.test.mjs, packages/cli/foundation/doc-compiler/doc-compiler.test.mjs, packages/cli/foundation/doc-compiler/doc-loads.test.mjs: clear; they pass at this head and the new cases fail on the base.

Automated review (maintainer link)

This branch was successfully deployed

1 active deployment
Preview — 185d0eed Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant