Repository navigation
test(cli): sample the MediaPlayer root so swizzle proof slice 8 renders it - #13006
Closed
astracat-bot[bot] wants to merge 1 commit into
Conversation
astracat-bot
Bot
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
November 19, 2026 21:08
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
AI review status for this pull request.
|
Contributor
Author
There was a problem hiding this comment.
Approved pending CI: CI has not finished on this head yet.
The new lab__MediaPlayer sample gives the swizzle proof the root's required label, so the slice-8 proof now passes for every target, on the server and in Chromium, and samples.test.mjs passes where it failed before. #12991 adds the identical entry, and #13001 plus several batch pull requests add a variant at the same line, so only one of them should land.
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claims:
- With the fix, the slice-8 proof and the samples test pass for all 22 slice-8 targets: verified by a local run of both on this head (also with the Chromium leg).
- Without the fix the slice-8 proof fails: verified on the release check at the merge base and by the samples test failing on the base.
- Prettier accepts the changed file: verified.
- The release check's slice 8 failed only because the MediaPlayer root had no sample for its required label: verified from that check's failure annotation.
- The media-player family shipped samples for its parts but not its root, whose doc marks label required: verified in the sample table and the MediaPlayer doc.
- The proof refuses to render a target with a required prop and no sample: verified in the proof's sample check.
- The sample renders the copied root with a label around a video element from the copy, else the package, like the part samples: verified.
- Only a test fixture changes, with no component, assertion or exemption change: verified (one file, nine added lines).
- A sibling pull request makes the same change, either fixes both tests, and this one is redundant if that lands first: verified (identical patch, both tests read the same sample table).
- Eight other open pull requests also change this file: verified from each one's file list.
- Files:
packages/cli/test/swizzle-proof/samples.mjs: clear
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validation: ran
SWIZZLE_PROOF_ALL=1 pnpm test:node packages/cli/test/swizzle-proof/swizzle-proof.8.test.mjs packages/cli/test/swizzle-proof/samples.test.mjstwice with the fix: 2/2 passed (6/6 tests, slice 8 ejected, type-checked, bundled and server-rendered all 22 targets with 0 failures). Without the fix, the slice-8 command failed 2/2.pnpm exec prettier --check packages/cli/test/swizzle-proof/samples.mjspassed. The Chromium leg (SWIZZLE_PROOF_BROWSER=1) was not run: the browser could not be installed in the fix environment.What failed
The release-check
release-swizzle-proof (8/8)leg (run 44610467395, commit 0bfa86c) failedpackages/cli/test/swizzle-proof/swizzle-proof.8.test.mjswith a single swizzle-proof failure:lab__MediaPlayer [sample] swizzle target lab__MediaPlayer has no sample in samples.mjs, and its doc gives no default for its required prop(s) labelCause
e2b63ae (#9832) added the lab media-player family. It added samples for every part (
lab__MediaPlayerElement,lab__MediaPlayButton, ...), but not for the rootlab__MediaPlayer, which requireslabel. The proof (spec:AST-110 FR7) cannot render a target with a required prop and no sample, so it reports it by name.Fix
Add a
lab__MediaPlayersample topackages/cli/test/swizzle-proof/samples.mjs. It renders the ejected root (C) withlabel: 'Clip'around a videoMediaPlayerElement(the ejected module's own export, else the package's), in the same way as the existing media-part samples. This is a test-fixture change only. No component, assertion or exemption changes.Notes
See also #12991. It makes the same
samples.mjschange for the siblingsamples.test.mjsfailure, and either PR fixes both tests. If #12991 merges first, this one is redundant. I did not run the Chromium render leg locally, so the browser step of this leg is covered only by CI.#11082 by Rajatendu1 also changes this test file.
#12891 by nynexman4464 also changes this test file.
#12964 by josephfarina also changes this test file.
#12965 by josephfarina also changes this test file.
#12976 by josephfarina also changes this test file.
#12992 by josephfarina also changes this test file.
#12993 by josephfarina also changes this test file.
#13001 by josephfarina also changes this test file.