Skip to content

chore: land 2 reviewed pull requests together (batch 86) - #13014

Open
josephfarina wants to merge 4 commits into
mainfrom
josephfarina/land-batch-86
Open

josephfarina wants to merge 4 commits into
mainfrom
josephfarina/land-batch-86

Conversation

@josephfarina

@josephfarina josephfarina commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Merges two reviewed pull requests onto current main, each as its own --no-ff merge, in this order. Each member keeps its own description, tests and review history.

Scope

CLI docs: the icon-sets overview describes meaning groups and replaces (#12889).

Tests: a template contract test pins the placeholder # calls to action and the one folder doctor's button check does not judge (#13007).

Records

Writing rubric results

Each member's record lines are scored in its own description: present tense, no change references, research or project status; verification rows name tests.

When this merges, each pull request above is closed with a note that names this one.

josephfarina and others added 2 commits November 19, 2026 02:27
…bout

A test runs doctor's own button finder over every page template and block
folder. A block gives the check nothing to warn about. A page template
gives it only the seven named calls to action that keep a placeholder #
link. Each folder is read in full and only the named folders go unjudged,
so a new warning, a new # link, or a folder the check cannot judge fails
the test.

[skip ci]
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2026
@astracat-bot

astracat-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Nov 19, 2026, 9:44 PM UTC

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 16ec17c
Covers the theme:butter, theme:neutral and theme:y2k amendments under spec:AST-020 FR1 (#12276, HQ ruling).

@github-actions github-actions Bot added the needs:design-review Affects visuals — Design should review label Nov 19, 2026
@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 16ec17c

@josephfarina josephfarina changed the title chore: land 3 reviewed pull requests together (batch 86) chore: land 2 reviewed pull requests together (batch 86) Nov 19, 2026
@josephfarina
josephfarina force-pushed the josephfarina/land-batch-86 branch from 16ec17c to 88ee760 Compare November 19, 2026 21:44
@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 19, 2026 9:54pm UTC

Request Review

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec 88ee760

@github-actions github-actions Bot removed the needs:design-review Affects visuals — Design should review label Nov 19, 2026

This branch was successfully deployed

1 active deployment
Preview — 88ee7600 Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant