Skip to content

chore: land 3 reviewed pull requests together (batch 94) - #13045

Open
josephfarina wants to merge 8 commits into
mainfrom
josephfarina/land-batch-94
Open

josephfarina wants to merge 8 commits into
mainfrom
josephfarina/land-batch-94

Conversation

@josephfarina

Copy link
Copy Markdown
Contributor

Merges three reviewed pull requests onto current main, each as its own --no-ff merge, in this order. Each member keeps its own description, tests and review history, and each record edit below has an engineering owner's /approve-spec on its member and at this branch's head.

Scope

CLI template: a template path that leaves the project gets the same refusal plus one suggestion, the same write run from the path's nearest folder, keeping the caller's write options such as --overwrite (#12710).

CLI doctor: outside a project, doctor warns about each issue of an integration installed for the computer, and the integration-issue nudge leads to those issues (#13002); doctor integration validate finds an integration installed for the computer and checks the folder's own source as the package being made (#13010). #13010 stacks on #13002.

Records

Writing rubric results

DEC-20 (#12710): R1 present tense. R2 none. R3 none. R4 none. R5 none. R6 none. R7 none.
FR12 (#13002): R1 present tense. R2 none. R3 none. R4 none. R5 none. R6 none. R7 none.

When this merges, each pull request above is closed with a note that names this one.

josephfarina and others added 8 commits November 19, 2026 12:10
… folder's CLI invocation; record DEC-20

[skip ci]
… installed for the computer

Outside a project, component, template, search, discover and theme print
one line when an integration installed for the computer has issues in its
contributions, and send the reader to doctor. Doctor's computer-integrations
check passed and named nothing, so the pointer led nowhere. It now warns and
names each issue. Its fix says that a newer release of the package must fix
it, with the command that updates a third-party package beside a CLI
installed for the computer, or that a tool's package set updates it. Doctor
reads no Core outside a project, so it leaves out the issues that compare
components with Core components.

[skip ci]
…for the computer

Outside a project, doctor's computer-integrations check names
`doctor integration validate <package>` for an integration installed for
the computer that it cannot load. That command looked only in the
node_modules at or above the folder, so it reported package_not_found.
Outside a project it now checks the copy the folder uses, as Project.load
decides it: the folder's own source or a package it declares, else the
copy installed for the computer. Outside any package, its docs line about
TypeScript names no install step.

[skip ci]
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 20, 2026 2:57am UTC

Request Review

@astracat-bot

astracat-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Nov 20, 2026, 2:57 AM UTC

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec b9cc641
Covers architecture:cli-surface DEC-20 (#12710, text identical to the decided wording) and spec:AST-081 FR12's doctor sentence and verification row (#13002).

@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec b9cc641

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 20, 2026

This branch was successfully deployed

1 active deployment
Preview — b9cc6419 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant