Repository navigation
chore: land 3 reviewed pull requests together (batch 94) - #13045
Open
josephfarina wants to merge 8 commits into
Open
josephfarina wants to merge 8 commits into
josephfarina wants to merge 8 commits into
Conversation
…at writes the path from its own folder
… folder's CLI invocation; record DEC-20 [skip ci]
… installed for the computer Outside a project, component, template, search, discover and theme print one line when an integration installed for the computer has issues in its contributions, and send the reader to doctor. Doctor's computer-integrations check passed and named nothing, so the pointer led nowhere. It now warns and names each issue. Its fix says that a newer release of the package must fix it, with the command that updates a third-party package beside a CLI installed for the computer, or that a tool's package set updates it. Doctor reads no Core outside a project, so it leaves out the issues that compare components with Core components. [skip ci]
…for the computer Outside a project, doctor's computer-integrations check names `doctor integration validate <package>` for an integration installed for the computer that it cannot load. That command looked only in the node_modules at or above the folder, so it reported package_not_found. Outside a project it now checks the copy the folder uses, as Project.load decides it: the folder's own source or a package it declares, else the copy installed for the computer. Outside any package, its docs line about TypeScript names no install step. [skip ci]
josephfarina
requested review from
cixzhang and
imdreamrunner
as code owners
November 20, 2026 02:40
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
AI review status for this pull request.
|
Contributor
Author
Contributor
Author
|
/approve-spec b9cc641 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges three reviewed pull requests onto current main, each as its own
--no-ffmerge, in this order. Each member keeps its own description, tests and review history, and each record edit below has an engineering owner's/approve-specon its member and at this branch's head.Scope
CLI template: a template path that leaves the project gets the same refusal plus one suggestion, the same write run from the path's nearest folder, keeping the caller's write options such as
--overwrite(#12710).CLI doctor: outside a project, doctor warns about each issue of an integration installed for the computer, and the integration-issue nudge leads to those issues (#13002);
doctor integration validatefinds an integration installed for the computer and checks the folder's own source as the package being made (#13010). #13010 stacks on #13002.Records
architecture:cli-surfaceDEC-20: a refused template path names the same write from its folder (feat(cli): template's outside-the-project refusal names the command that writes the path from its own folder #12710).spec:AST-081FR12: the doctor sentence for computer-level integrations and its verification row (fix(cli): doctor outside a project names the issues of an integration installed for the computer #13002).Writing rubric results
DEC-20 (#12710): R1 present tense. R2 none. R3 none. R4 none. R5 none. R6 none. R7 none.
FR12 (#13002): R1 present tense. R2 none. R3 none. R4 none. R5 none. R6 none. R7 none.
When this merges, each pull request above is closed with a note that names this one.