Repository navigation
feat(ContextMenu): open from a held finger on iOS 26's timeline #8125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vjeux
wants to merge
96
commits into
meta:main
Choose a base branch
from
vjeux:uikit/c20-contextmenu-press
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,055
−314
Draft
Changes from all commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
2bcc49a
feat(ContextMenu): open from a held finger on iOS 26's timeline
vjeux 812d3a4
test(ContextMenu): the hold's menu commits in its deciding task (red)
vjeux 0776b40
fix(ContextMenu): the hold commits its menu in the task that decides it
vjeux e8f5ca1
test(ContextMenu): the menu mounts, closed, at the hold's commit (red)
vjeux 0fbd309
fix(ContextMenu): the hold mounts the menu at its commit, closed
vjeux 32e75c7
test(ContextMenu): a mouse press closes the menu in its own document
vjeux ba77ca8
Merge commit 'c8b4cba38181263ffa8fcc897975b61154cb91b0' into HEAD
vjeux df6fd04
docs(ContextMenu): PR1 names the outside-press watch and the touch query
vjeux abb70e1
test(ContextMenu): a starved page fails the 735 ms proof by name
vjeux b8a9055
Merge commit '62c7802e873ed3d020192e8218e5e1bcd4f8fad2' into HEAD
vjeux e66ff1d
Merge commit '92784f658939912fae623dd497cd35e499e13878' into HEAD
vjeux 24c03c1
test(ContextMenu): a starved page's late timer fails by name in WebKit
vjeux 339bf7e
docs(ContextMenu): PR1 names each presentation's query subscriptions
vjeux 3d78dae
docs(ContextMenu): the record names the touch open's focus gap
vjeux 20dc83f
Merge branch 'main' into uikit/c20-contextmenu-press
cixzhang a9188e6
Merge main
vjeux a5a0e12
test(ContextMenu): a finger that lifts before 400 ms is a plain tap
vjeux a6253f3
test(ContextMenu): a late drift past 11.5 px, a known Chromium gap
vjeux 3c39a05
test(ContextMenu): a late drift past 11.5 px cancels in every engine
vjeux a4e0404
fix(ContextMenu): the menu waits for the finger's late moves
vjeux 3b76a8c
test(ContextMenu): a finger inside the tolerance at the menu's moment
vjeux 88cc0d8
fix(ContextMenu): the press reads each move's own time from the arena
vjeux 46bc0da
test(ContextMenu): coalesced late samples and an on-time move
vjeux cad79ec
fix(ContextMenu): judge each sample at its time, wait only when late
vjeux 889aded
test(ContextMenu): moves held behind a block decide before the menu
vjeux 45bfb44
fix(ContextMenu): a late menu timer waits for moves behind the block
vjeux d743922
test(ContextMenu): the press's page time comes from the arena's clock
vjeux cae3644
fix(ContextMenu): the press reads the page's time from the arena
vjeux 03eb7d7
refactor(ContextMenu): the touch layer imports its recognizer directly
vjeux f37d633
test(ContextMenu): a drift queued behind a block still ends the hold
vjeux 8575ec7
docs(records): why the press keeps its own wait, and outsidePress types
vjeux 22ae97e
docs(ContextMenu): name the measured table and the moved default
vjeux 7c8cb86
Merge main
vjeux 56b2f62
test(ContextMenu): a finger in a second document on its own clock
vjeux 650a125
Merge main
vjeux fac565a
docs(ContextMenu): the record owns the touch hold's two modules
vjeux 69e6dd8
docs(ContextMenu): the hold's comments match what this code does
vjeux 1375867
docs(layer-runtime): name the layer's prepare and releasePrepared
vjeux 330fcc9
Merge main 6ab0c2ea11 into the press
vjeux dcfa0f8
Merge main 1740654b76 into the press
vjeux f0b0017
test(ContextMenu): a dropped render leaves the commit's mount alone
vjeux e5a2bc9
refactor(ContextMenu): no ref is written during render
vjeux 3ea914d
docs(layer-runtime): the outside-press line names a touch's press too
vjeux 86f89fd
docs(ContextMenu): two more comments match what this code does
vjeux 9cccb47
docs(ContextMenu): the rest of the text matches what ships here
vjeux 21f8156
docs(ContextMenu): the End-user row states the gap, not a status
vjeux e8d6326
Merge main 4d1cb828f6 into the press
vjeux d3621c0
Merge main 50beab9610 into the press
vjeux 5adbafb
test(ContextMenu): the shift cases set how late the page gets the move
vjeux 3632bb3
docs(layer-runtime): ContextMenu's menu uses the outside-press watch
vjeux 26f36d3
docs(ContextMenu): FR10's gap names the hold ContextMenu times itself
vjeux 68be391
test(ContextMenu): the late-move case bounds the wait from above
vjeux 8e34400
Merge main 56680f6a7c into the press
vjeux 06b982f
Merge main 36f68b0da0 into the press
vjeux 21ffc1b
Merge main 4800d992eb into the press
vjeux 9710f27
test(ContextMenu): a held finger on a Table header gets its menu there
vjeux 85d7a36
fix(ContextMenu): a finger's point is measured from the anchor's box
vjeux bb998be
test(ContextMenu): a finger before the touch layer loads waits for it
vjeux 30b6b1e
feat(ContextMenu): the touch layer loads after first paint
vjeux 779d979
test(ContextMenu): a drift before the touch layer loads ends the press
vjeux ffa0950
fix(ContextMenu): a drift before the touch layer loads ends the press
vjeux c6208ca
docs(ContextMenu): the touch loader's comments in short sentences
vjeux df18912
Merge main 6d00dd56fd into the touch hold
vjeux e7c75e4
test(gestures): a late deadline waits for input queued behind a block
vjeux b547611
fix(gestures): a late deadline waits for input queued behind a block
vjeux 7764661
test(ContextMenu): late finger's pointer, heard finger, failed load
vjeux b919d67
fix(ContextMenu): late finger keeps its pointer; failed load recovers
vjeux a458377
test(gestures): a deadline among a coalesced move's samples
vjeux 6e45960
fix(gestures): a deadline among a coalesced move's samples runs between
vjeux 1f848c9
test(gestures): a deadline due during a late wait runs as it ends
vjeux cf6fa67
fix(gestures): a deadline due during a late wait runs as it ends
vjeux 104122d
Merge the arena's late-input handling into the touch hold
vjeux 1a404c9
refactor(ContextMenu): leave late input to the gesture arena
vjeux d73fbbc
docs(layer-runtime): a popover ContextMenu judges a touch at its press
vjeux a14908d
docs(gestures): the late wait's comment and changeset in short sentences
vjeux 81a658c
test(ContextMenu): load on the trigger window; failed load frees finger
vjeux fead7ee
fix(ContextMenu): load on the trigger's window; failed load frees finger
vjeux 88132ea
docs(specs): FR16 states the late wait's cost for every recognizer
vjeux 23afc6e
Merge the arena fix's short sentences and its cost line
vjeux 640bbfa
test(gestures): a mouse keeps the late yield; a late wait ends once
vjeux b7e19e3
fix(gestures): only a finger or pen waits; a late wait ends once
vjeux 320e8a3
Merge the arena fix's finger and pen gate into the touch hold
vjeux b411003
docs(gestures): the arena header's late-wait sentence in two
vjeux 3503b02
docs(gestures): FR16 states the gate once; comments say why
vjeux ec2e905
Merge main 64806d0bd2 into the arena fix
vjeux f9c558f
Merge the arena fix's main merge into the touch hold
vjeux 9e26c1e
docs(specs): the FR16 gap note names the finger-or-pen gate
vjeux db994d9
test(ContextMenu): the lift's click proof waits for the touch layer
vjeux fc46615
test(ContextMenu): a trigger mounting after a failed load loads nothing
vjeux c8446e5
fix(ContextMenu): after a failed load, only a touch asks again
vjeux 9f7be4c
docs(ContextMenu): the pointer-order comment names no engine
vjeux fbe0c1c
chore(ContextMenu): the touch loader's per-copy state is allowed
vjeux add87da
perf(Layer): the public useLayer hides prepare() by type only
vjeux 1acbd8b
test(ContextMenu): a trigger in another document loads nothing either
vjeux f4076cb
fix(ContextMenu): after a failed load, no window schedules another
vjeux 9cfc2fa
docs(Layer): prepare() is hidden from useLayer's type, not its object
vjeux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [fix] ContextMenu closes on an outside press through the layer's outside-press watch. A mouse or pen press closes it at its `mousedown`, in the menu's own document, so a menu in an iframe or a Picture-in-Picture window no longer closes on a press in the page. | ||
|
|
||
| @vjeux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [feat] ContextMenu opens from a held finger on iOS 26's measured timeline where the primary pointer is coarse. The hold keeps UIKit's measured moments. At 400 ms the press takes the finger: its lift no longer sends a click, and the page cannot scroll under it. The menu opens at 735 ms if the finger is still down, or as soon as it lifts after 400 ms. A finger that lifts before 400 ms, or drifts more than 11.5 px on either axis before the menu opens, gets no menu. The page stays free to scroll while the menu is up: a touch outside the menu closes it as it begins to pan, or at its lift. A touch open lights no row: the menu itself takes the focus, as in UIKit (keyboard and pointer opens still focus the first item). A second finger cancels the press before 400 ms; after it, the menu still opens. A fine pointer (a mouse) keeps the right-click menu, and a finger there keeps today's 500 ms long press. The touch code loads after the page first paints, so a page's first load does not carry it; a finger held before then starts the hold once it loads. Pass `presentation="popover"` to keep today's menu: the menu at the pointer, opened by a finger held for 500 ms. | ||
|
|
||
| @vjeux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [fix] A touch gesture's deadline now runs after the input stamped before it. Behind a blocked page, a finger's or pen's deadline whose timer runs more than 17 ms late waits 50 ms for input still queued. Each input from before it that comes late keeps it waiting. A mouse's or trackpad's deadline does not wait. A deadline that falls among a coalesced move's samples runs between them. A List reorder hold or a Pager's catch whose finger drifted or lifted in time now ends as it should. | ||
|
|
||
| @vjeux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.