Repository navigation
feat(core): createReorderable makes List rows reorderable #8139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
cad762b
feat(core): createReorderable makes List rows reorderable
vjeux d0c1590
feat(List): reorder mode's hint, its moves and Done as buttons
vjeux 6ff3d0b
fix(List): a move that renames a row keeps reorder mode
vjeux 66fc409
fix(cli): a create* factory with its own hook lists beside that hook
vjeux 32d137f
docs(List): split comment sentences over 25 words
vjeux 13c6534
fix(List): a finger held on a reorder handle selects no text
vjeux ca8a76b
fix(List): a drag crossing rows reads no layout
vjeux 8de33bf
fix(List): the reorder imports the touch hit area from internal
vjeux e5f5e02
fix(List): the reorder finds its scroller through core's shared walk
vjeux 77fb567
fix(List): a dragged row's preview and line keep its inline start in RTL
vjeux 1baf07c
fix(List): picking a row up lays the page out once
vjeux 28b44c3
spec(AST-103): a held drag near a scroll edge scrolls toward it
vjeux 0abe4b2
fix(List): a dragged row's preview joins no form or radio group
vjeux 4b907b5
fix(List): a scroll during a drag keeps the drop under the pointer
vjeux c89aa9c
spec(react-component-runtime): INV18 allows the reorder's scroll read
vjeux 6beee21
chore(lint): the provenance baseline drops List's two removed citations
vjeux 05c5150
Merge branch 'main' into uikit/c13-list-reorder
cixzhang 9a497c6
fix(List): a drop or key move reads its rows once, before it writes
vjeux 3384ec6
docs(List): a key move's first glides cost a style pass per row
vjeux 7a333bd
Merge main into createReorderable's List reorder
vjeux 4678530
docs(motion): the reorder measurements name no batch label
vjeux ed28397
Merge branch 'main' into uikit/c13-list-reorder
cixzhang ff96b6f
Merge main into createReorderable's List reorder
vjeux 92365e4
refactor(List): the reorder warns once through createDevWarnings
vjeux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/cli': patch | ||
| --- | ||
|
|
||
| [feat] `astryx` lists a `create…` factory documented as a hook, such as `createReorderable`, with the hooks. | ||
|
|
||
| @vjeux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [feat] While a reorderable `List` row is in reorder mode, a hint anchored to its handle, in the keyboard hint's layer and theme roles, shows the moves and Done. Each is a button that does what its key does and leaves the focus on the handle, so a row can be reordered by taps alone: the handle, the moves, then Done. | ||
|
|
||
| @vjeux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [feat] `createReorderable({onReorder, isReorderable})` makes a collection's reorder behavior, and `List` takes it as `reorderable`: each `ListItem` with an `itemKey` gets a reorder handle at its end, and each committed move calls `onReorder({key, to})` once, with the row's key and its index after the move. On a touch screen a finger held still on a handle picks up its row the way an iOS table's reorder control does (a flick on it still scrolls): the row stays in its place, dimmed, while a copy of it follows the finger and an accent line marks where it would land; the other rows stay still, the page scrolls near the edges, and on release the rows rearrange, gliding to their new places. A pen held on a handle picks up its row the same way where the primary pointer is coarse. A mouse, or a pen where the primary pointer is fine, drags a handle at once with the same copy and line, and rows take their places without motion; a cancelled drag puts everything back at once. Without a drag, a click, Space or Enter on a handle turns on reorder mode for its row: the insertion line marks the row's place, each arrow key moves it a place at once, announced with its place and neighbours, and Escape or another activation ends the mode, keeping the moves. The object's `start(key)` enters the same mode from the app's own UI, such as a row's context menu. A List without `reorderable` loads none of the reorder code. | ||
|
|
||
| @vjeux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.